* [Intel-gfx] [PATCH] drm/i915/execlists: Shortcircuit queue_prio() for no internal levels
@ 2020-05-14 20:15 Chris Wilson
2020-05-15 17:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-15 19:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2020-05-14 20:15 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
If there are no internal levels and the user priority-shift is zero, we
can help the compiler eliminate some dead code:
Function old new delta
start_timeslice 169 154 -15
__execlists_submission_tasklet 4696 4659 -37
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/intel_lrc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 87e6c5bdd2dc..2020e35d59b6 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -446,6 +446,9 @@ static int queue_prio(const struct intel_engine_execlists *execlists)
* we have to flip the index value to become priority.
*/
p = to_priolist(rb);
+ if (!I915_USER_PRIORITY_SHIFT)
+ return p->priority;
+
return ((p->priority + 1) << I915_USER_PRIORITY_SHIFT) - ffs(p->used);
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Shortcircuit queue_prio() for no internal levels
2020-05-14 20:15 [Intel-gfx] [PATCH] drm/i915/execlists: Shortcircuit queue_prio() for no internal levels Chris Wilson
@ 2020-05-15 17:17 ` Patchwork
2020-05-15 19:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2020-05-15 17:17 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Shortcircuit queue_prio() for no internal levels
URL : https://patchwork.freedesktop.org/series/77278/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8488 -> Patchwork_17668
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/index.html
Known issues
------------
Here are the changes found in Patchwork_17668 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-cfl-8700k: [PASS][1] -> [INCOMPLETE][2] ([i915#1874])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/fi-cfl-8700k/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/fi-cfl-8700k/igt@i915_selftest@live@execlists.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-whl-u: [INCOMPLETE][3] ([i915#656]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/fi-whl-u/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/fi-whl-u/igt@i915_selftest@live@execlists.html
[i915#1874]: https://gitlab.freedesktop.org/drm/intel/issues/1874
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
Participating hosts (51 -> 44)
------------------------------
Additional (1): fi-kbl-7560u
Missing (8): fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8488 -> Patchwork_17668
CI-20190529: 20190529
CI_DRM_8488: d40ec60813532e485e9c63623c91babf556cfbe3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5655: 2cc4c1edc3065590f9917930b6d049a90c4a38fd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17668: f5f55d06a7b39da48b04ddddec630b6ca8b31c5c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f5f55d06a7b3 drm/i915/execlists: Shortcircuit queue_prio() for no internal levels
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/execlists: Shortcircuit queue_prio() for no internal levels
2020-05-14 20:15 [Intel-gfx] [PATCH] drm/i915/execlists: Shortcircuit queue_prio() for no internal levels Chris Wilson
2020-05-15 17:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-05-15 19:57 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2020-05-15 19:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Shortcircuit queue_prio() for no internal levels
URL : https://patchwork.freedesktop.org/series/77278/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8488_full -> Patchwork_17668_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17668_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17668_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17668_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_softpin@noreloc-s3:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-iclb7/igt@gem_softpin@noreloc-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-iclb3/igt@gem_softpin@noreloc-s3.html
Known issues
------------
Here are the changes found in Patchwork_17668_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_softpin@noreloc-s3:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#69])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-skl7/igt@gem_softpin@noreloc-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-skl6/igt@gem_softpin@noreloc-s3.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#180])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-apl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#108145] / [i915#265])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#173])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-iclb3/igt@kms_psr@no_drrs.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109441]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +6 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Possible fixes ####
* igt@gem_workarounds@suspend-resume-fd:
- shard-skl: [INCOMPLETE][15] ([i915#69]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-skl6/igt@gem_workarounds@suspend-resume-fd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-skl6/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][17] ([i915#180]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-apl6/igt@i915_suspend@fence-restore-untiled.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-apl7/igt@i915_suspend@fence-restore-untiled.html
* {igt@kms_flip@flip-vs-expired-vblank@b-edp1}:
- shard-skl: [FAIL][19] ([i915#79]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* {igt@kms_flip@flip-vs-suspend@a-vga1}:
- shard-snb: [DMESG-WARN][21] ([i915#42]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-snb2/igt@kms_flip@flip-vs-suspend@a-vga1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-snb6/igt@kms_flip@flip-vs-suspend@a-vga1.html
* {igt@kms_flip@flip-vs-suspend@c-dp1}:
- shard-kbl: [DMESG-WARN][23] ([i915#180]) -> [PASS][24] +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
* {igt@kms_flip@plain-flip-fb-recreate@b-edp1}:
- shard-skl: [FAIL][25] ([i915#1883]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-skl6/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-skl5/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][27] ([i915#123] / [i915#69]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-skl8/igt@kms_frontbuffer_tracking@psr-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-skl3/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][29] ([i915#1188]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-skl1/igt@kms_hdr@bpc-switch-dpms.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][31] ([fdo#109642] / [fdo#111068]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-iclb6/igt@kms_psr2_su@frontbuffer.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_primary_render:
- shard-iclb: [SKIP][33] ([fdo#109441]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-iclb4/igt@kms_psr@psr2_primary_render.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-iclb2/igt@kms_psr@psr2_primary_render.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][35] ([i915#31]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-apl1/igt@kms_setmode@basic.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-apl4/igt@kms_setmode@basic.html
- shard-kbl: [FAIL][37] ([i915#31]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-kbl6/igt@kms_setmode@basic.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-kbl6/igt@kms_setmode@basic.html
#### Warnings ####
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][39] ([i915#454]) -> [SKIP][40] ([i915#468])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-tglb5/igt@i915_pm_dc@dc6-dpms.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_content_protection@atomic:
- shard-kbl: [TIMEOUT][41] ([i915#1319]) -> [FAIL][42] ([fdo#110321] / [fdo#110336] / [i915#93] / [i915#95])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-kbl1/igt@kms_content_protection@atomic.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-kbl2/igt@kms_content_protection@atomic.html
- shard-apl: [FAIL][43] ([fdo#110321] / [fdo#110336] / [i915#95]) -> [DMESG-FAIL][44] ([fdo#110321] / [i915#95])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-apl6/igt@kms_content_protection@atomic.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-apl3/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@legacy:
- shard-apl: [FAIL][45] ([fdo#110321] / [fdo#110336]) -> [TIMEOUT][46] ([i915#1319])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-apl3/igt@kms_content_protection@legacy.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-apl1/igt@kms_content_protection@legacy.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-FAIL][47] ([i915#180] / [i915#95]) -> [FAIL][48] ([i915#1121] / [i915#93] / [i915#95])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8488/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1121]: https://gitlab.freedesktop.org/drm/intel/issues/1121
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1883]: https://gitlab.freedesktop.org/drm/intel/issues/1883
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8488 -> Patchwork_17668
CI-20190529: 20190529
CI_DRM_8488: d40ec60813532e485e9c63623c91babf556cfbe3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5655: 2cc4c1edc3065590f9917930b6d049a90c4a38fd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17668: f5f55d06a7b39da48b04ddddec630b6ca8b31c5c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17668/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-15 19:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 20:15 [Intel-gfx] [PATCH] drm/i915/execlists: Shortcircuit queue_prio() for no internal levels Chris Wilson
2020-05-15 17:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-15 19:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.