[LTP] [PATCH v2 1/4] INSTALL: Update requirements

[LTP] [PATCH v2 1/4] INSTALL: Update requirements

[Petr Vorel]

* mention pkgconf in both INSTALL and README.md (many distros migrated
  from pkg-config to pkgconf)
* replace links to old versions to projects' homepage
* modernize text a bit
* remove CVS tag :)

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Changes v1->v2:
* Few pkg-config related changes

@@ -8,12 +8,16 @@ For compilation from tarball
 * make
 https://www.gnu.org/software/make/
 
-For auto configuration from git
 * pkgconf / pkg-config
 https://git.sr.ht/~kaniini/pkgconf
 http://pkgconf.org/
 https://www.freedesktop.org/wiki/Software/pkg-config/
 
+pkgconf / pkg-config is not necesarry for compliation from tarball
+(libraries wont be found), but it's required for compilation from git
+(needed for creating configure file).
+
+For auto configuration when installing from git
 * autoconf
 https://www.gnu.org/software/autoconf/
 


 INSTALL   | 53 +++++++++++++++++++++++++----------------------------
 README.md |  5 +++--
 2 files changed, 28 insertions(+), 30 deletions(-)

diff --git a/INSTALL b/INSTALL
index 8bf6fe005..250330e2b 100644
--- a/INSTALL
+++ b/INSTALL
@@ -1,42 +1,39 @@
-$Id: INSTALL,v 1.36 2010/01/18 23:46:09 yaberauneya Exp $
-
 Requirements
 -------------------
 
-1. In order to compile ltp you must have make 3.80+ (make 3.81 preferred).
-2. In order to compile and use ltp-scanner (a utility in the pan directory),
-   you must have bison/yacc, and flex installed.
-
-bison can be obtained here:
-- http://ftp.gnu.org/gnu/bison/bison-2.4.1.tar.gz
+These tools are needed for LTP compilation. They should be available as a
+package in any Linux distribution (no specific version is required).
 
-Berkeley yacc can be obtained here:
-- ftp://invisible-island.net/byacc/byacc.tar.gz
+For compilation from tarball
+* make
+https://www.gnu.org/software/make/
 
-flex can be obtained here:
-- http://downloads.sourceforge.net/project/flex/flex/flex-2.5.33/flex-2.5.33.tar.bz2
+* pkgconf / pkg-config
+https://git.sr.ht/~kaniini/pkgconf
+http://pkgconf.org/
+https://www.freedesktop.org/wiki/Software/pkg-config/
 
-make 3.81 can be obtained here:
-- http://ftp.gnu.org/gnu/make/make-3.81.tar.bz2
+pkgconf / pkg-config is not necesarry for compliation from tarball
+(libraries wont be found), but it's required for compilation from git
+(needed for creating configure file).
 
-If you want to use auto configuration you also need autoconf-2.61+, automake-1.10+
-and pkg-config.
+For auto configuration when installing from git
+* autoconf
+https://www.gnu.org/software/autoconf/
 
-automake-1.10.2's sources can be downloaded from:
-- ftp://ftp.gnu.org/gnu/automake/automake-1.10.2.tar.bz2
-- ftp://ftp.gnu.org/gnu/automake/automake-1.10.2.tar.gz
+* automake
+https://www.gnu.org/software/automake/
 
-autoconf-2.61's sources can be downloaded from:
-- ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.61.tar.bz2
-- ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.61.tar.gz
+* m4 (autoconf requirement)
+https://www.gnu.org/software/m4/
 
-autoconf-2.61 also requires m4-1.4.7+ be installed. Its sources can be
-downloaded from:
-- http://ftp.gnu.org/gnu/m4/m4-1.4.7.tar.bz2
-- http://ftp.gnu.org/gnu/m4/m4-1.4.7.tar.gz
+For ltp-scanner
+* GNU Bison / Berkeley Yacc
+https://www.gnu.org/software/bison/
+https://invisible-island.net/byacc/byacc.html
 
-pkg-config can be downloaded from:
-- https://pkg-config.freedesktop.org/releases/
+* Flex
+https://github.com/westes/flex
 
 Configuration
 -------------------
diff --git a/README.md b/README.md
index a2a623f40..15f8814c3 100644
--- a/README.md
+++ b/README.md
@@ -37,8 +37,9 @@ on properly functioning systems, they are intended to find (or cause) problems.
 Quick guide to running the tests
 ================================
 
-If you have git, autoconf, automake, m4 and pkg-config, the linux headers and
-the common developer packages installed, the chances are the following will work:
+If you have git, autoconf, automake, m4, pkgconf / pkg-config, linux kernel
+headers and the common developer packages installed, the chances are the
+following will work:
 
 ```
 $ git clone https://github.com/linux-test-project/ltp.git
-- 
2.26.2

[LTP] [PATCH v2 1/4] INSTALL: Update requirements

[Li Wang]

Hi Petr,

As we know most distributions provide the requirements packages already,
so I'm thinking if we can replace the download link only by installing
commands, that will make people easily prepare their test environment.

Which something maybe likes:
--------------------------------------

+       #### Debian/Ubuntu
+       ```
+       sudo apt-get install make
+       sudo apt-get install pkgconf
+       sudo apt-get install autoconf
+       sudo apt-get install automake
+       sudo apt-get install byacc
+       sudo apt-get install flex
+       sudo apt-get install m4
+       ```
+
+       #### OpenSUSE
+       ```
+       sudo zypper install make
+       sudo zypper install pkgconf
+       sudo zypper install autoconf
+       sudo zypper install automake
+       sudo zypper install byacc
+       sudo zypper install flex
+       sudo zypper install m4
+       ```
+       #### Fedora/CentOS/RHEL
+       ```
+       sudo yum install make
+       sudo yum install pkgconf
+       sudo yum install autoconf
+       sudo yum install automake
+       sudo yum install byacc
+       sudo yum install flex
+       sudo yum install m4
+       ```

Anyway, this is a good update for documents, I hope these could be involved
in the newly released.
[CC Cyril to notice this]

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200515/494ac470/attachment-0001.htm>

[LTP] [PATCH v2 1/4] INSTALL: Update requirements

[Petr Vorel]

Hi Li,

thanks for your review!

> As we know most distributions provide the requirements packages already,
> so I'm thinking if we can replace the download link only by installing
> commands, that will make people easily prepare their test environment.

> Which something maybe likes:
> --------------------------------------

> +       #### Debian/Ubuntu
> +       ```
> +       sudo apt-get install make
> +       sudo apt-get install pkgconf
> +       sudo apt-get install autoconf
> +       sudo apt-get install automake
> +       sudo apt-get install byacc
> +       sudo apt-get install flex
> +       sudo apt-get install m4
> +       ```
Maybe this:

Debian / Ubuntu
# apt install gcc make pkgconf autoconf automake bison flex m4 linux-headers-$(uname -r) libc6-dev

OpenSUSE / SLES
# zypper install gcc make pkgconf autoconf automake bison flex m4 linux-glibc-devel glibc-devel

Fedora / CentOS / RHEL
# yum install gcc make pkgconf autoconf automake bison flex m4 kernel-headers glibc-headers

I'd prefer it in simple form (single line) + I thought bison is more common than
byacc (but maybe I'm wrong). I'm not a big fan of sudo (but can add it there).
+ Added headers and gcc. But on the other hand I wanted to have package reference in
travis/*.sh (where are missing some packages which are installed by default with
gcc, e.g. , but it does not harm to have it offline.

Should I remove links to the tools? And we obviously don't list a compiler.

> +
> +       #### OpenSUSE
> +       ```
> +       sudo zypper install make
> +       sudo zypper install pkgconf
> +       sudo zypper install autoconf
> +       sudo zypper install automake
> +       sudo zypper install byacc
> +       sudo zypper install flex
> +       sudo zypper install m4
> +       ```
> +       #### Fedora/CentOS/RHEL
> +       ```
> +       sudo yum install make
> +       sudo yum install pkgconf
> +       sudo yum install autoconf
> +       sudo yum install automake
> +       sudo yum install byacc
> +       sudo yum install flex
> +       sudo yum install m4
> +       ```

> Anyway, this is a good update for documents, I hope these could be involved
> in the newly released.
> [CC Cyril to notice this]
Yep, that was the intention of this late evening patches :).

Kind regards,
Petr

[LTP] [PATCH v2 1/4] INSTALL: Update requirements

[Li Wang]

On Fri, May 15, 2020 at 2:22 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Li,
>
> thanks for your review!
>
> > As we know most distributions provide the requirements packages already,
> > so I'm thinking if we can replace the download link only by installing
> > commands, that will make people easily prepare their test environment.
>
> > Which something maybe likes:
> > --------------------------------------
>
> > +       #### Debian/Ubuntu
> > +       ```
> > +       sudo apt-get install make
> > +       sudo apt-get install pkgconf
> > +       sudo apt-get install autoconf
> > +       sudo apt-get install automake
> > +       sudo apt-get install byacc
> > +       sudo apt-get install flex
> > +       sudo apt-get install m4
> > +       ```
> Maybe this:
>
> Debian / Ubuntu
> # apt install gcc make pkgconf autoconf automake bison flex m4
> linux-headers-$(uname -r) libc6-dev
>
> OpenSUSE / SLES
> # zypper install gcc make pkgconf autoconf automake bison flex m4
> linux-glibc-devel glibc-devel
>
> Fedora / CentOS / RHEL
> # yum install gcc make pkgconf autoconf automake bison flex m4
> kernel-headers glibc-headers
>
> I'd prefer it in simple form (single line) + I thought bison is more
> common than
> byacc (but maybe I'm wrong). I'm not a big fan of sudo (but can add it
> there).
>

Sure, I have no preference here :). I added the 'sudo' just because I
noticed that the INSTALL use many $ before commands which means in non-root
user.



> + Added headers and gcc. But on the other hand I wanted to have package
> reference in
> travis/*.sh (where are missing some packages which are installed by
> default with
> gcc, e.g. , but it does not harm to have it offline.
>
+1

>
> Should I remove links to the tools? And we obviously don't list a compiler.
>

Personally I think links are useless, people opened this INSTALL could also
have the ability to use google for finding the package link:).

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200515/8e0ad7ef/attachment.htm>

[LTP] [PATCH v2 1/4] INSTALL: Update requirements

[Petr Vorel]

Hi Li,

> > I'd prefer it in simple form (single line) + I thought bison is more
> > common than
> > byacc (but maybe I'm wrong). I'm not a big fan of sudo (but can add it
> > there).


> Sure, I have no preference here :). I added the 'sudo' just because I
> noticed that the INSTALL use many $ before commands which means in non-root
> user.
I added '#' in v3, but if anybody requires I can change it to sudo.


> > + Added headers and gcc. But on the other hand I wanted to have package
> > reference in
> > travis/*.sh (where are missing some packages which are installed by
> > default with
> > gcc, e.g. , but it does not harm to have it offline.

> +1
In the end in v3 I mentioned glibc and kernel headers, but also mentioned travis/*.sh.


> > Should I remove links to the tools? And we obviously don't list a compiler.


> Personally I think links are useless, people opened this INSTALL could also
> have the ability to use google for finding the package link:).
Agree, thus removed in v3.

Kind regards,
Petr