From: Jerome Pouiller <Jerome.Pouiller@silabs.com> To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Kalle Valo" <kvalo@codeaurora.org>, "David S . Miller" <davem@davemloft.net>, "Jérôme Pouiller" <jerome.pouiller@silabs.com> Subject: [PATCH 17/19] staging: wfx: remove false-positive WARN() Date: Fri, 15 May 2020 10:33:23 +0200 [thread overview] Message-ID: <20200515083325.378539-18-Jerome.Pouiller@silabs.com> (raw) In-Reply-To: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> From: Jérôme Pouiller <jerome.pouiller@silabs.com> The function wfx_tx_flush() wait for there is no more queued frames in hardware queue. Then, for the sanity, it checks that there is no more pending frame on any AC queue. However, there is a race here. It may happens that hardware queues are empty, but the counters of the AC queues are not yet updated. So, it may produce false-positive warning. The easiest way to solve the problem is just to remove the sanity check. Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> --- drivers/staging/wfx/queue.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index 0c799cedd101..26b141cbd303 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -30,7 +30,6 @@ void wfx_tx_unlock(struct wfx_dev *wdev) void wfx_tx_flush(struct wfx_dev *wdev) { int ret; - int i; // Do not wait for any reply if chip is frozen if (wdev->chip_frozen) @@ -41,12 +40,6 @@ void wfx_tx_flush(struct wfx_dev *wdev) ret = wait_event_timeout(wdev->hif.tx_buffers_empty, !wdev->hif.tx_buffers_used, msecs_to_jiffies(3000)); - if (ret) { - for (i = 0; i < IEEE80211_NUM_ACS; i++) - WARN(atomic_read(&wdev->tx_queue[i].pending_frames), - "there are still %d pending frames on queue %d", - atomic_read(&wdev->tx_queue[i].pending_frames), i); - } if (!ret) { dev_warn(wdev->dev, "cannot flush tx buffers (%d still busy)\n", wdev->hif.tx_buffers_used); -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Pouiller <Jerome.Pouiller@silabs.com> To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "David S . Miller" <davem@davemloft.net>, Kalle Valo <kvalo@codeaurora.org> Subject: [PATCH 17/19] staging: wfx: remove false-positive WARN() Date: Fri, 15 May 2020 10:33:23 +0200 [thread overview] Message-ID: <20200515083325.378539-18-Jerome.Pouiller@silabs.com> (raw) In-Reply-To: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> From: Jérôme Pouiller <jerome.pouiller@silabs.com> The function wfx_tx_flush() wait for there is no more queued frames in hardware queue. Then, for the sanity, it checks that there is no more pending frame on any AC queue. However, there is a race here. It may happens that hardware queues are empty, but the counters of the AC queues are not yet updated. So, it may produce false-positive warning. The easiest way to solve the problem is just to remove the sanity check. Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> --- drivers/staging/wfx/queue.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index 0c799cedd101..26b141cbd303 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -30,7 +30,6 @@ void wfx_tx_unlock(struct wfx_dev *wdev) void wfx_tx_flush(struct wfx_dev *wdev) { int ret; - int i; // Do not wait for any reply if chip is frozen if (wdev->chip_frozen) @@ -41,12 +40,6 @@ void wfx_tx_flush(struct wfx_dev *wdev) ret = wait_event_timeout(wdev->hif.tx_buffers_empty, !wdev->hif.tx_buffers_used, msecs_to_jiffies(3000)); - if (ret) { - for (i = 0; i < IEEE80211_NUM_ACS; i++) - WARN(atomic_read(&wdev->tx_queue[i].pending_frames), - "there are still %d pending frames on queue %d", - atomic_read(&wdev->tx_queue[i].pending_frames), i); - } if (!ret) { dev_warn(wdev->dev, "cannot flush tx buffers (%d still busy)\n", wdev->hif.tx_buffers_used); -- 2.26.2 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-15 8:34 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-15 8:33 [PATCH 00/19] staging: wfx: various fixes Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 01/19] staging: wfx: fix warning when unregister a frozen device Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 02/19] staging: wfx: apply 80-columns rule to strings Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 03/19] staging: wfx: check pointers returned by allocations Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 04/19] staging: wfx: fix value of scan timeout Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 05/19] staging: wfx: fix coherency of hif_scan() prototype Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 13:53 ` Greg Kroah-Hartman 2020-05-15 13:53 ` Greg Kroah-Hartman 2020-05-15 14:01 ` Greg Kroah-Hartman 2020-05-15 14:01 ` Greg Kroah-Hartman 2020-05-15 15:03 ` Jérôme Pouiller 2020-05-15 15:03 ` Jérôme Pouiller 2020-05-15 15:09 ` Greg Kroah-Hartman 2020-05-15 15:09 ` Greg Kroah-Hartman 2020-05-15 8:33 ` [PATCH 06/19] staging: wfx: fix indentation Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 07/19] staging: wfx: fix status of dropped frames Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 08/19] staging: wfx: split out wfx_tx_fill_rates() from wfx_tx_confirm_cb() Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 09/19] staging: wfx: call wfx_tx_update_sta() before to destroy tx_priv Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 10/19] staging: wfx: fix potential use-after-free Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 11/19] staging: wfx: rename wfx_do_unjoin() into wfx_reset() Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 12/19] staging: wfx: merge wfx_stop_ap() with wfx_reset() Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 13/19] staging: wfx: fix potential dead lock between join and scan Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 14/19] staging: wfx: fix PS parameters when multiple vif are in use Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 15/19] staging: wfx: drop unnecessary filter configuration when disabling filter Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 16/19] staging: wfx: fix error reporting in wfx_start_ap() Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller [this message] 2020-05-15 8:33 ` [PATCH 17/19] staging: wfx: remove false-positive WARN() Jerome Pouiller 2020-05-15 8:33 ` [PATCH 18/19] staging: wfx: trace acknowledges not linked to any stations Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller 2020-05-15 8:33 ` [PATCH 19/19] staging: wfx: remove false positive warning Jerome Pouiller 2020-05-15 8:33 ` Jerome Pouiller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200515083325.378539-18-Jerome.Pouiller@silabs.com \ --to=jerome.pouiller@silabs.com \ --cc=davem@davemloft.net \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.