From: Greg KH <gregkh@linuxfoundation.org>
To: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc: stable@vger.kernel.org, "wuxu.wu" <wuxu.wu@huawei.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 for 4.4, 4.9] spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls
Date: Fri, 15 May 2020 10:51:09 +0200 [thread overview]
Message-ID: <20200515085109.GC1474499@kroah.com> (raw)
In-Reply-To: <20200515004245.1069864-1-nobuhiro1.iwamatsu@toshiba.co.jp>
On Fri, May 15, 2020 at 09:42:45AM +0900, Nobuhiro Iwamatsu wrote:
> From: "wuxu.wu" <wuxu.wu@huawei.com>
>
> commit 19b61392c5a852b4e8a0bf35aecb969983c5932d upstream.
>
> dw_spi_irq() and dw_spi_transfer_one concurrent calls.
>
> I find a panic in dw_writer(): txw = *(u8 *)(dws->tx), when dw->tx==null,
> dw->len==4, and dw->tx_end==1.
>
> When tpm driver's message overtime dw_spi_irq() and dw_spi_transfer_one
> may concurrent visit dw_spi, so I think dw_spi structure lack of protection.
>
> Otherwise dw_spi_transfer_one set dw rx/tx buffer and then open irq,
> store dw rx/tx instructions and other cores handle irq load dw rx/tx
> instructions may out of order.
>
> [ 1025.321302] Call trace:
> ...
> [ 1025.321319] __crash_kexec+0x98/0x148
> [ 1025.321323] panic+0x17c/0x314
> [ 1025.321329] die+0x29c/0x2e8
> [ 1025.321334] die_kernel_fault+0x68/0x78
> [ 1025.321337] __do_kernel_fault+0x90/0xb0
> [ 1025.321346] do_page_fault+0x88/0x500
> [ 1025.321347] do_translation_fault+0xa8/0xb8
> [ 1025.321349] do_mem_abort+0x68/0x118
> [ 1025.321351] el1_da+0x20/0x8c
> [ 1025.321362] dw_writer+0xc8/0xd0
> [ 1025.321364] interrupt_transfer+0x60/0x110
> [ 1025.321365] dw_spi_irq+0x48/0x70
> ...
>
> Signed-off-by: wuxu.wu <wuxu.wu@huawei.com>
> Link: https://lore.kernel.org/r/1577849981-31489-1-git-send-email-wuxu.wu@huawei.com
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
> drivers/spi/spi-dw.c | 15 ++++++++++++---
> drivers/spi/spi-dw.h | 1 +
> 2 files changed, 13 insertions(+), 3 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2020-05-15 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 0:42 [PATCH v2 for 4.4, 4.9] spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls Nobuhiro Iwamatsu
2020-05-15 8:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515085109.GC1474499@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=stable@vger.kernel.org \
--cc=wuxu.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.