* [linux-review:UPDATE-20200514-234943/Stanislav-Lisovskiy/Consider-DBuf-bandwidth-when-calculating-CDCLK/20200514-232846 6/7] drivers/gpu/drm/i915/display/intel_display.c:14695:2: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
@ 2020-05-15 5:02 kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2020-05-15 5:02 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 17001 bytes --]
tree: https://github.com/0day-ci/linux/commits/UPDATE-20200514-234943/Stanislav-Lisovskiy/Consider-DBuf-bandwidth-when-calculating-CDCLK/20200514-232846
head: 299fe22b95c5eec191b4fadb8c149ae6c5262f6c
commit: 605fbe4b20bd78e247088acbe3b2d3a63f3960cd [6/7] drm/i915: Adjust CDCLK accordingly to our DBuf bw needs
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 9d4cf5bd421fb6467ff5f00e26a37527246dd4d6)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 605fbe4b20bd78e247088acbe3b2d3a63f3960cd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/gpu/drm/i915/display/intel_display.c:14695:2: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
new_cdclk_state = intel_atomic_get_new_cdclk_state(state);
^~~~~~~~~~~~~~~
new_crtc_state
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
>> drivers/gpu/drm/i915/display/intel_display.c:14695:18: error: incompatible pointer types assigning to 'struct intel_crtc_state *' from 'struct intel_cdclk_state *' [-Werror,-Wincompatible-pointer-types]
new_cdclk_state = intel_atomic_get_new_cdclk_state(state);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display.c:14697:6: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
if (new_cdclk_state && new_cdclk_state->force_min_cdclk_changed)
^~~~~~~~~~~~~~~
new_crtc_state
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14697:25: error: use of undeclared identifier 'new_cdclk_state'
if (new_cdclk_state && new_cdclk_state->force_min_cdclk_changed)
^
>> drivers/gpu/drm/i915/display/intel_display.c:14698:4: error: use of undeclared identifier 'need_cdclk_calc'
*need_cdclk_calc = true;
^
drivers/gpu/drm/i915/display/intel_display.c:14704:7: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
if (!new_cdclk_state)
^~~~~~~~~~~~~~~
new_crtc_state
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:866:35: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), ^
include/linux/kernel.h:856:16: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^
include/linux/kernel.h:842:22: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:866:35: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), ^
include/linux/kernel.h:856:43: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^
include/linux/kernel.h:853:19: note: expanded from macro '__no_side_effects'
(__is_constexpr(x) && __is_constexpr(y))
^
include/linux/kernel.h:850:48: note: expanded from macro '__is_constexpr'
(sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:867:9: note: expanded from macro '__careful_cmp'
__cmp(x, y, op), ^
include/linux/kernel.h:858:27: note: expanded from macro '__cmp'
#define __cmp(x, y, op) ((x) op (y) ? (x) : (y))
^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:867:9: note: expanded from macro '__careful_cmp'
__cmp(x, y, op), ^
include/linux/kernel.h:858:40: note: expanded from macro '__cmp'
#define __cmp(x, y, op) ((x) op (y) ? (x) : (y))
^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:868:14: note: expanded from macro '__careful_cmp'
__cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op))
^
include/linux/kernel.h:861:10: note: expanded from macro '__cmp_once'
typeof(x) unique_x = (x); ^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
--
>> drivers/gpu/drm/i915/display/intel_display.c:14695:2: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
new_cdclk_state = intel_atomic_get_new_cdclk_state(state);
^~~~~~~~~~~~~~~
new_crtc_state
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
>> drivers/gpu/drm/i915/display/intel_display.c:14695:18: error: incompatible pointer types assigning to 'struct intel_crtc_state *' from 'struct intel_cdclk_state *' [-Werror,-Wincompatible-pointer-types]
new_cdclk_state = intel_atomic_get_new_cdclk_state(state);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display.c:14697:6: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
if (new_cdclk_state && new_cdclk_state->force_min_cdclk_changed)
^~~~~~~~~~~~~~~
new_crtc_state
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14697:25: error: use of undeclared identifier 'new_cdclk_state'
if (new_cdclk_state && new_cdclk_state->force_min_cdclk_changed)
^
>> drivers/gpu/drm/i915/display/intel_display.c:14698:4: error: use of undeclared identifier 'need_cdclk_calc'
*need_cdclk_calc = true;
^
drivers/gpu/drm/i915/display/intel_display.c:14704:7: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
if (!new_cdclk_state)
^~~~~~~~~~~~~~~
new_crtc_state
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:866:35: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), ^
include/linux/kernel.h:856:16: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^
include/linux/kernel.h:842:22: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:866:35: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), ^
include/linux/kernel.h:856:43: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^
include/linux/kernel.h:853:19: note: expanded from macro '__no_side_effects'
(__is_constexpr(x) && __is_constexpr(y))
^
include/linux/kernel.h:850:48: note: expanded from macro '__is_constexpr'
(sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:867:9: note: expanded from macro '__careful_cmp'
__cmp(x, y, op), ^
include/linux/kernel.h:858:27: note: expanded from macro '__cmp'
#define __cmp(x, y, op) ((x) op (y) ? (x) : (y))
^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:867:9: note: expanded from macro '__careful_cmp'
__cmp(x, y, op), ^
include/linux/kernel.h:858:40: note: expanded from macro '__cmp'
#define __cmp(x, y, op) ((x) op (y) ? (x) : (y))
^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
^~~~~~~~~~~~~~~
new_crtc_state
include/linux/kernel.h:882:33: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^
include/linux/kernel.h:868:14: note: expanded from macro '__careful_cmp'
__cmp_once(x, y, __UNIQUE_ID(__x), __UNIQUE_ID(__y), op))
^
include/linux/kernel.h:861:10: note: expanded from macro '__cmp_once'
typeof(x) unique_x = (x); ^
drivers/gpu/drm/i915/display/intel_display.c:14642:44: note: 'new_crtc_state' declared here
struct intel_crtc_state *old_crtc_state, *new_crtc_state;
^
drivers/gpu/drm/i915/display/intel_display.c:14711:19: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'?
min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
vim +14695 drivers/gpu/drm/i915/display/intel_display.c
14638
14639 static int intel_atomic_check_planes(struct intel_atomic_state *state)
14640 {
14641 struct drm_i915_private *dev_priv = to_i915(state->base.dev);
14642 struct intel_crtc_state *old_crtc_state, *new_crtc_state;
14643 struct intel_plane_state *plane_state;
14644 struct intel_plane *plane;
14645 struct intel_crtc *crtc;
14646 int i, ret;
14647
14648 ret = icl_add_linked_planes(state);
14649 if (ret)
14650 return ret;
14651
14652 for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
14653 ret = intel_plane_atomic_check(state, plane);
14654 if (ret) {
14655 drm_dbg_atomic(&dev_priv->drm,
14656 "[PLANE:%d:%s] atomic driver check failed\n",
14657 plane->base.base.id, plane->base.name);
14658 return ret;
14659 }
14660 }
14661
14662 for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
14663 new_crtc_state, i) {
14664 u8 old_active_planes, new_active_planes;
14665
14666 ret = icl_check_nv12_planes(new_crtc_state);
14667 if (ret)
14668 return ret;
14669
14670 /*
14671 * On some platforms the number of active planes affects
14672 * the planes' minimum cdclk calculation. Add such planes
14673 * to the state before we compute the minimum cdclk.
14674 */
14675 if (!active_planes_affects_min_cdclk(dev_priv))
14676 continue;
14677
14678 old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
14679 new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
14680
14681 /*
14682 * Not only the number of planes, but if the plane configuration had
14683 * changed might already mean we need to recompute min CDCLK,
14684 * because different planes might consume different amount of Dbuf bandwidth
14685 * according to formula: Bw per plane = Pixel rate * bpp * pipe/plane scale factor
14686 */
14687 if (old_active_planes == new_active_planes)
14688 continue;
14689
14690 ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
14691 if (ret)
14692 return ret;
14693 }
14694
14695 new_cdclk_state = intel_atomic_get_new_cdclk_state(state);
14696
14697 if (new_cdclk_state && new_cdclk_state->force_min_cdclk_changed)
14698 *need_cdclk_calc = true;
14699
14700 ret = intel_bw_calc_min_cdclk(state);
14701 if (ret)
14702 return ret;
14703
14704 if (!new_cdclk_state)
14705 return 0;
14706
14707 for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
14708 struct intel_bw_state *bw_state;
14709 int min_cdclk = 0;
14710
14711 min_cdclk = max(new_cdclk_state->min_cdclk[crtc->pipe], min_cdclk);
14712
14713 bw_state = intel_atomic_get_bw_state(state);
14714 if (IS_ERR(bw_state))
14715 return PTR_ERR(bw_state);
14716
14717 /*
14718 * Currently do this change only if we need to increase
14719 */
14720 if (bw_state->min_cdclk > min_cdclk)
14721 *need_cdclk_calc = true;
14722 }
14723
14724 return 0;
14725 }
14726
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 73479 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-15 5:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 5:02 [linux-review:UPDATE-20200514-234943/Stanislav-Lisovskiy/Consider-DBuf-bandwidth-when-calculating-CDCLK/20200514-232846 6/7] drivers/gpu/drm/i915/display/intel_display.c:14695:2: error: use of undeclared identifier 'new_cdclk_state'; did you mean 'new_crtc_state'? kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.