* [MPTCP] [PATCH net] selftests:mptcp:pm: rm the right tmp file
@ 2020-05-15 15:54 ` Matthieu Baerts
0 siblings, 0 replies; 4+ messages in thread
From: Matthieu Baerts @ 2020-05-15 15:54 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
"$err" is a variable pointing to a temp file. "$out" is not: only used
as a local variable in "check()" and representing the output of a
command line.
Fixes: eedbc685321b (selftests: add PM netlink functional tests)
Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
---
tools/testing/selftests/net/mptcp/pm_netlink.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
index 9172746b6cf0..15f4f46ca3a9 100755
--- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
+++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
@@ -30,7 +30,7 @@ ret=0
cleanup()
{
- rm -f $out
+ rm -f $err
ip netns del $ns1
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net] selftests:mptcp:pm: rm the right tmp file
@ 2020-05-15 15:54 ` Matthieu Baerts
0 siblings, 0 replies; 4+ messages in thread
From: Matthieu Baerts @ 2020-05-15 15:54 UTC (permalink / raw)
To: netdev
Cc: Matthieu Baerts, Mat Martineau, David S. Miller, Jakub Kicinski,
Shuah Khan, Paolo Abeni, mptcp, linux-kselftest, linux-kernel
"$err" is a variable pointing to a temp file. "$out" is not: only used
as a local variable in "check()" and representing the output of a
command line.
Fixes: eedbc685321b (selftests: add PM netlink functional tests)
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
tools/testing/selftests/net/mptcp/pm_netlink.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
index 9172746b6cf0..15f4f46ca3a9 100755
--- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
+++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
@@ -30,7 +30,7 @@ ret=0
cleanup()
{
- rm -f $out
+ rm -f $err
ip netns del $ns1
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [MPTCP] Re: [PATCH net] selftests:mptcp:pm: rm the right tmp file
2020-05-15 15:54 ` Matthieu Baerts
@ 2020-05-15 17:34 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-05-15 17:34 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
From: Matthieu Baerts <matthieu.baerts(a)tessares.net>
Date: Fri, 15 May 2020 17:54:41 +0200
> "$err" is a variable pointing to a temp file. "$out" is not: only used
> as a local variable in "check()" and representing the output of a
> command line.
>
> Fixes: eedbc685321b (selftests: add PM netlink functional tests)
> Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] selftests:mptcp:pm: rm the right tmp file
@ 2020-05-15 17:34 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-05-15 17:34 UTC (permalink / raw)
To: matthieu.baerts
Cc: netdev, mathew.j.martineau, kuba, shuah, pabeni, mptcp,
linux-kselftest, linux-kernel
From: Matthieu Baerts <matthieu.baerts@tessares.net>
Date: Fri, 15 May 2020 17:54:41 +0200
> "$err" is a variable pointing to a temp file. "$out" is not: only used
> as a local variable in "check()" and representing the output of a
> command line.
>
> Fixes: eedbc685321b (selftests: add PM netlink functional tests)
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-15 17:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 15:54 [MPTCP] [PATCH net] selftests:mptcp:pm: rm the right tmp file Matthieu Baerts
2020-05-15 15:54 ` Matthieu Baerts
2020-05-15 17:34 [MPTCP] " David Miller
2020-05-15 17:34 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.