All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"David Hildenbrand" <david@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Marek Vasut" <marex@denx.de>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Emilio G . Cota" <cota@braap.org>,
	"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
	"Thomas Huth" <thuth@redhat.com>,
	qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>,
	qemu-riscv@nongnu.org,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Chris Wulff" <crwulff@gmail.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Michael Walle" <michael@walle.cc>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH v2 04/10] accel/tcg: Add stub for probe_access()
Date: Fri, 15 May 2020 19:07:58 +0200	[thread overview]
Message-ID: <20200515170804.5707-5-philmd@redhat.com> (raw)
In-Reply-To: <20200515170804.5707-1-philmd@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
probe_write() was added in there in 3b4afc9e75a to be moved out
to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
as probe_access() in c25c283df0f.
Since it is a TCG specific helper, add a stub to avoid failures
when building without TCG, such:

  target/arm/helper.o: In function `probe_read':
  include/exec/exec-all.h:362: undefined reference to `probe_access'

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Cc: Richard Henderson <rth@twiddle.net>
Cc: Emilio G. Cota <cota@braap.org>
Cc: Alex Bennée <alex.bennee@linaro.org>
Cc: David Hildenbrand <david@redhat.com>
---
 accel/stubs/tcg-stub.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
index 677191a69c..e4bbf997aa 100644
--- a/accel/stubs/tcg-stub.c
+++ b/accel/stubs/tcg-stub.c
@@ -22,3 +22,10 @@ void tb_flush(CPUState *cpu)
 void tlb_set_dirty(CPUState *cpu, target_ulong vaddr)
 {
 }
+
+void *probe_access(CPUArchState *env, target_ulong addr, int size,
+                   MMUAccessType access_type, int mmu_idx, uintptr_t retaddr)
+{
+     /* Handled by hardware accelerator. */
+     g_assert_not_reached();
+}
-- 
2.21.3



WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Max Filippov" <jcmvbkbc@gmail.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Richard Henderson" <rth@twiddle.net>,
	qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Chris Wulff" <crwulff@gmail.com>,
	qemu-riscv@nongnu.org, "Laurent Vivier" <laurent@vivier.eu>,
	"Thomas Huth" <thuth@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Marek Vasut" <marex@denx.de>, "Michael Walle" <michael@walle.cc>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Emilio G . Cota" <cota@braap.org>,
	"David Hildenbrand" <david@redhat.com>
Subject: [PATCH v2 04/10] accel/tcg: Add stub for probe_access()
Date: Fri, 15 May 2020 19:07:58 +0200	[thread overview]
Message-ID: <20200515170804.5707-5-philmd@redhat.com> (raw)
In-Reply-To: <20200515170804.5707-1-philmd@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
probe_write() was added in there in 3b4afc9e75a to be moved out
to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
as probe_access() in c25c283df0f.
Since it is a TCG specific helper, add a stub to avoid failures
when building without TCG, such:

  target/arm/helper.o: In function `probe_read':
  include/exec/exec-all.h:362: undefined reference to `probe_access'

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Cc: Richard Henderson <rth@twiddle.net>
Cc: Emilio G. Cota <cota@braap.org>
Cc: Alex Bennée <alex.bennee@linaro.org>
Cc: David Hildenbrand <david@redhat.com>
---
 accel/stubs/tcg-stub.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
index 677191a69c..e4bbf997aa 100644
--- a/accel/stubs/tcg-stub.c
+++ b/accel/stubs/tcg-stub.c
@@ -22,3 +22,10 @@ void tb_flush(CPUState *cpu)
 void tlb_set_dirty(CPUState *cpu, target_ulong vaddr)
 {
 }
+
+void *probe_access(CPUArchState *env, target_ulong addr, int size,
+                   MMUAccessType access_type, int mmu_idx, uintptr_t retaddr)
+{
+     /* Handled by hardware accelerator. */
+     g_assert_not_reached();
+}
-- 
2.21.3



  parent reply	other threads:[~2020-05-15 17:11 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 17:07 [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
2020-05-15 17:07 ` Philippe Mathieu-Daudé
2020-05-15 17:07 ` [PATCH v2 01/10] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-05-15 17:07   ` Philippe Mathieu-Daudé
2020-05-17 17:23   ` Thomas Huth
2020-05-17 17:23     ` Thomas Huth
2020-05-15 17:07 ` [PATCH v2 02/10] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-05-15 17:07   ` Philippe Mathieu-Daudé
2020-05-17 17:26   ` Thomas Huth
2020-05-17 17:26     ` Thomas Huth
2020-05-21 15:09     ` Philippe Mathieu-Daudé
2020-05-21 15:09       ` Philippe Mathieu-Daudé
2020-05-15 17:07 ` [PATCH v2 03/10] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-05-15 17:07   ` Philippe Mathieu-Daudé
2020-05-15 17:07 ` Philippe Mathieu-Daudé [this message]
2020-05-15 17:07   ` [PATCH v2 04/10] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-05-19 21:41   ` Richard Henderson
2020-05-19 21:41     ` Richard Henderson
2020-05-15 17:07 ` [PATCH v2 05/10] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-05-15 17:07   ` Philippe Mathieu-Daudé
2020-05-17 18:00   ` Thomas Huth
2020-05-17 18:00     ` Thomas Huth
2020-05-18 16:46   ` Alistair Francis
2020-05-18 16:46     ` Alistair Francis
2020-05-15 17:08 ` [PATCH v2 06/10] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-05-15 17:08   ` Philippe Mathieu-Daudé
2020-05-15 17:08 ` [PATCH v2 07/10] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-05-15 17:08   ` Philippe Mathieu-Daudé
2020-05-15 17:08 ` [PATCH v2 08/10] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-05-15 17:08   ` Philippe Mathieu-Daudé
2020-05-15 17:08 ` [PATCH v2 09/10] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-05-15 17:08   ` Philippe Mathieu-Daudé
2020-05-19 21:42   ` Richard Henderson
2020-05-19 21:42     ` Richard Henderson
2020-05-21 17:33   ` Philippe Mathieu-Daudé
2020-05-21 17:33     ` Philippe Mathieu-Daudé
2020-05-15 17:08 ` [PATCH v2 10/10] hw/semihosting: Make the feature depend of TCG, and allow to disable it Philippe Mathieu-Daudé
2020-05-15 17:08   ` Philippe Mathieu-Daudé
2020-05-19 21:44   ` Richard Henderson
2020-05-19 21:44     ` Richard Henderson
2020-05-21 19:55     ` Philippe Mathieu-Daudé
2020-05-16  3:44 ` [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default no-reply
2020-05-16  3:44   ` no-reply
2020-05-16  3:57 ` no-reply
2020-05-16  3:57   ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515170804.5707-5-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=cota@braap.org \
    --cc=crwulff@gmail.com \
    --cc=david@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=laurent@vivier.eu \
    --cc=marex@denx.de \
    --cc=michael@walle.cc \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sagark@eecs.berkeley.edu \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.