* [PATCH] block: remove the REQ_NOWAIT_INLINE flag
@ 2020-05-04 16:10 Christoph Hellwig
2020-05-05 6:44 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-05-04 16:10 UTC (permalink / raw)
To: axboe; +Cc: linux-block
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
include/linux/blk_types.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 90895d594e647..7443e474cdad5 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -323,7 +323,6 @@ enum req_flag_bits {
__REQ_RAHEAD, /* read ahead, can fail anytime */
__REQ_BACKGROUND, /* background IO */
__REQ_NOWAIT, /* Don't wait if request will block */
- __REQ_NOWAIT_INLINE, /* Return would-block error inline */
/*
* When a shared kthread needs to issue a bio for a cgroup, doing
* so synchronously can lead to priority inversions as the kthread
@@ -358,7 +357,6 @@ enum req_flag_bits {
#define REQ_RAHEAD (1ULL << __REQ_RAHEAD)
#define REQ_BACKGROUND (1ULL << __REQ_BACKGROUND)
#define REQ_NOWAIT (1ULL << __REQ_NOWAIT)
-#define REQ_NOWAIT_INLINE (1ULL << __REQ_NOWAIT_INLINE)
#define REQ_CGROUP_PUNT (1ULL << __REQ_CGROUP_PUNT)
#define REQ_NOUNMAP (1ULL << __REQ_NOUNMAP)
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] block: remove the REQ_NOWAIT_INLINE flag
2020-05-04 16:10 [PATCH] block: remove the REQ_NOWAIT_INLINE flag Christoph Hellwig
@ 2020-05-05 6:44 ` Chaitanya Kulkarni
2020-05-16 15:51 ` Christoph Hellwig
2020-05-16 20:24 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-05-05 6:44 UTC (permalink / raw)
To: Christoph Hellwig, axboe; +Cc: linux-block
On 5/4/20 9:10 AM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig<hch@lst.de>
> ---
> include/linux/blk_types.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 90895d594e647..7443e474cdad5 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -323,7 +323,6 @@ enum req_flag_bits {
> __REQ_RAHEAD, /* read ahead, can fail anytime */
> __REQ_BACKGROUND, /* background IO */
> __REQ_NOWAIT, /* Don't wait if request will block */
> - __REQ_NOWAIT_INLINE, /* Return would-block error inline */
> /*
> * When a shared kthread needs to issue a bio for a cgroup, doing
> * so synchronously can lead to priority inversions as the kthread
> @@ -358,7 +357,6 @@ enum req_flag_bits {
> #define REQ_RAHEAD (1ULL << __REQ_RAHEAD)
> #define REQ_BACKGROUND (1ULL << __REQ_BACKGROUND)
> #define REQ_NOWAIT (1ULL << __REQ_NOWAIT)
> -#define REQ_NOWAIT_INLINE (1ULL << __REQ_NOWAIT_INLINE)
> #define REQ_CGROUP_PUNT (1ULL << __REQ_CGROUP_PUNT)
>
> #define REQ_NOUNMAP (1ULL << __REQ_NOUNMAP)
> -- 2.26.2
Looks good to me.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: remove the REQ_NOWAIT_INLINE flag
2020-05-04 16:10 [PATCH] block: remove the REQ_NOWAIT_INLINE flag Christoph Hellwig
2020-05-05 6:44 ` Chaitanya Kulkarni
@ 2020-05-16 15:51 ` Christoph Hellwig
2020-05-16 20:24 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-05-16 15:51 UTC (permalink / raw)
To: axboe; +Cc: linux-block
ping?
On Mon, May 04, 2020 at 06:10:05PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> include/linux/blk_types.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 90895d594e647..7443e474cdad5 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -323,7 +323,6 @@ enum req_flag_bits {
> __REQ_RAHEAD, /* read ahead, can fail anytime */
> __REQ_BACKGROUND, /* background IO */
> __REQ_NOWAIT, /* Don't wait if request will block */
> - __REQ_NOWAIT_INLINE, /* Return would-block error inline */
> /*
> * When a shared kthread needs to issue a bio for a cgroup, doing
> * so synchronously can lead to priority inversions as the kthread
> @@ -358,7 +357,6 @@ enum req_flag_bits {
> #define REQ_RAHEAD (1ULL << __REQ_RAHEAD)
> #define REQ_BACKGROUND (1ULL << __REQ_BACKGROUND)
> #define REQ_NOWAIT (1ULL << __REQ_NOWAIT)
> -#define REQ_NOWAIT_INLINE (1ULL << __REQ_NOWAIT_INLINE)
> #define REQ_CGROUP_PUNT (1ULL << __REQ_CGROUP_PUNT)
>
> #define REQ_NOUNMAP (1ULL << __REQ_NOUNMAP)
> --
> 2.26.2
---end quoted text---
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: remove the REQ_NOWAIT_INLINE flag
2020-05-04 16:10 [PATCH] block: remove the REQ_NOWAIT_INLINE flag Christoph Hellwig
2020-05-05 6:44 ` Chaitanya Kulkarni
2020-05-16 15:51 ` Christoph Hellwig
@ 2020-05-16 20:24 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2020-05-16 20:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-block
On 5/4/20 10:10 AM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-16 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 16:10 [PATCH] block: remove the REQ_NOWAIT_INLINE flag Christoph Hellwig
2020-05-05 6:44 ` Chaitanya Kulkarni
2020-05-16 15:51 ` Christoph Hellwig
2020-05-16 20:24 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.