[lkundrak-linux-mmp:lr/ene-ec-v3 2/2] drivers/mfd/ene-kb3930.c:34:15: sparse: sparse: symbol 'global_kb3930' was not declared. Should it be static?

[lkundrak-linux-mmp:lr/ene-ec-v3 2/2] drivers/mfd/ene-kb3930.c:34:15: sparse: sparse: symbol 'global_kb3930' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git lr/ene-ec-v3
head:   84f417afc0f8966e64edbf420c0e7c47b9c451ed
commit: 84f417afc0f8966e64edbf420c0e7c47b9c451ed [2/2] mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-193-gb8fad4bc-dirty
        git checkout 84f417afc0f8966e64edbf420c0e7c47b9c451ed
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/mfd/ene-kb3930.c:34:15: sparse: sparse: symbol 'global_kb3930' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[RFC PATCH lkundrak-linux-mmp] mfd: ene-kb3930: global_kb3930 can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]


Fixes: 84f417afc0f8 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 ene-kb3930.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
index 1123f3a1c816a..af1e5ff72e395 100644
--- a/drivers/mfd/ene-kb3930.c
+++ b/drivers/mfd/ene-kb3930.c
@@ -31,7 +31,7 @@ struct kb3930 {
 	struct gpio_descs *off_gpios;
 };
 
-struct kb3930 *global_kb3930;
+static struct kb3930 *global_kb3930;
 
 static void kb3930_off(struct kb3930 *priv, int poweroff)
 {