* [PATCH] libubootenv: Depend on zlib
@ 2020-05-18 8:27 Marek Vasut
2020-05-19 15:56 ` [OE-core] " Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2020-05-18 8:27 UTC (permalink / raw)
To: openembedded-core; +Cc: Marek Vasut, Stefano Babic
The libubootenv depends on zlib as it calls at least crc32() from
there and links against it. Add the DEPENDS entry.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
---
meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
index 3251d0f05b..fa90a12bf8 100644
--- a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
+++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
@@ -1,5 +1,5 @@
SUMMARY = "U-Boot libraries and tools to access environment"
-DEPENDS += "mtd-utils"
+DEPENDS += "mtd-utils zlib"
DESCRIPTION = "This package contains tools and libraries to read \
and modify U-Boot environment. \
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH] libubootenv: Depend on zlib
2020-05-18 8:27 [PATCH] libubootenv: Depend on zlib Marek Vasut
@ 2020-05-19 15:56 ` Khem Raj
2020-05-19 16:07 ` Stefano Babic
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2020-05-19 15:56 UTC (permalink / raw)
To: Marek Vasut
Cc: Patches and discussions about the oe-core layer, Stefano Babic
On Mon, May 18, 2020 at 1:28 AM Marek Vasut <marex@denx.de> wrote:
>
> The libubootenv depends on zlib as it calls at least crc32() from
> there and links against it. Add the DEPENDS entry.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
> index 3251d0f05b..fa90a12bf8 100644
> --- a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
> @@ -1,5 +1,5 @@
> SUMMARY = "U-Boot libraries and tools to access environment"
> -DEPENDS += "mtd-utils"
> +DEPENDS += "mtd-utils zlib"
>
should this be a packageconfig
> DESCRIPTION = "This package contains tools and libraries to read \
> and modify U-Boot environment. \
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH] libubootenv: Depend on zlib
2020-05-19 15:56 ` [OE-core] " Khem Raj
@ 2020-05-19 16:07 ` Stefano Babic
2020-05-19 16:10 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Babic @ 2020-05-19 16:07 UTC (permalink / raw)
To: Khem Raj, Marek Vasut
Cc: Patches and discussions about the oe-core layer, Stefano Babic
Hi Khem,
On 19.05.20 17:56, Khem Raj wrote:
> On Mon, May 18, 2020 at 1:28 AM Marek Vasut <marex@denx.de> wrote:
>>
>> The libubootenv depends on zlib as it calls at least crc32() from
>> there and links against it. Add the DEPENDS entry.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Stefano Babic <sbabic@denx.de>
>> ---
>> meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
>> index 3251d0f05b..fa90a12bf8 100644
>> --- a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
>> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
>> @@ -1,5 +1,5 @@
>> SUMMARY = "U-Boot libraries and tools to access environment"
>> -DEPENDS += "mtd-utils"
>> +DEPENDS += "mtd-utils zlib"
>>
It can't, it is not an option. U-Boot requires a CRC-32 on the
environment and zlib is always linked to the binaries fw_setenv /
fw_printenv.
Stefano
>
> should this be a packageconfig
>
>> DESCRIPTION = "This package contains tools and libraries to read \
>> and modify U-Boot environment. \
>> --
>> 2.25.1
>>
>>
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH] libubootenv: Depend on zlib
2020-05-19 16:07 ` Stefano Babic
@ 2020-05-19 16:10 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2020-05-19 16:10 UTC (permalink / raw)
To: Stefano Babic
Cc: Marek Vasut, Patches and discussions about the oe-core layer
On Tue, May 19, 2020 at 9:07 AM Stefano Babic <sbabic@denx.de> wrote:
>
> Hi Khem,
>
> On 19.05.20 17:56, Khem Raj wrote:
> > On Mon, May 18, 2020 at 1:28 AM Marek Vasut <marex@denx.de> wrote:
> >>
> >> The libubootenv depends on zlib as it calls at least crc32() from
> >> there and links against it. Add the DEPENDS entry.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Stefano Babic <sbabic@denx.de>
> >> ---
> >> meta/recipes-bsp/u-boot/libubootenv_0.2.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
> >> index 3251d0f05b..fa90a12bf8 100644
> >> --- a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
> >> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
> >> @@ -1,5 +1,5 @@
> >> SUMMARY = "U-Boot libraries and tools to access environment"
> >> -DEPENDS += "mtd-utils"
> >> +DEPENDS += "mtd-utils zlib"
> >>
>
> It can't, it is not an option. U-Boot requires a CRC-32 on the
> environment and zlib is always linked to the binaries fw_setenv /
> fw_printenv.
>
OK thanks
> Stefano
>
> >
> > should this be a packageconfig
> >
> >> DESCRIPTION = "This package contains tools and libraries to read \
> >> and modify U-Boot environment. \
> >> --
> >> 2.25.1
> >>
> >>
>
>
> --
> =====================================================================
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> =====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-19 16:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 8:27 [PATCH] libubootenv: Depend on zlib Marek Vasut
2020-05-19 15:56 ` [OE-core] " Khem Raj
2020-05-19 16:07 ` Stefano Babic
2020-05-19 16:10 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.