* [rdma:wip/jgg-for-next 106/128] drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting
@ 2020-05-18 2:27 ` kbuild test robot
0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-05-18 2:27 UTC (permalink / raw)
To: Jack Wang
Cc: kbuild-all, Doug Ledford, Jason Gunthorpe, linux-rdma,
Jason Gunthorpe, Danil Kipnis
[-- Attachment #1: Type: text/plain, Size: 3413 bytes --]
Hi Jack,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head: 41d5e318ccb34bded248a7a4c97264fdb1c8a42e
commit: c013fbc1fd341d28269cf0a6b465925186b9a1e1 [106/128] RDMA/rtrs: include client and server modules into kernel compilation
config: i386-allyesconfig (attached as .config)
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
smatch warnings:
drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting
drivers/infiniband/ulp/rtrs/rtrs-clt.c:2890 rtrs_clt_request() warn: inconsistent indenting
vim +1196 drivers/infiniband/ulp/rtrs/rtrs-clt.c
6a98d71daea186 Jack Wang 2020-05-11 1166
6a98d71daea186 Jack Wang 2020-05-11 1167 /**
6a98d71daea186 Jack Wang 2020-05-11 1168 * rtrs_clt_failover_req() Try to find an active path for a failed request
6a98d71daea186 Jack Wang 2020-05-11 1169 * @clt: clt context
6a98d71daea186 Jack Wang 2020-05-11 1170 * @fail_req: a failed io request.
6a98d71daea186 Jack Wang 2020-05-11 1171 */
6a98d71daea186 Jack Wang 2020-05-11 1172 static int rtrs_clt_failover_req(struct rtrs_clt *clt,
6a98d71daea186 Jack Wang 2020-05-11 1173 struct rtrs_clt_io_req *fail_req)
6a98d71daea186 Jack Wang 2020-05-11 1174 {
6a98d71daea186 Jack Wang 2020-05-11 1175 struct rtrs_clt_sess *alive_sess;
6a98d71daea186 Jack Wang 2020-05-11 1176 struct rtrs_clt_io_req *req;
6a98d71daea186 Jack Wang 2020-05-11 1177 int err = -ECONNABORTED;
6a98d71daea186 Jack Wang 2020-05-11 1178 struct path_it it;
6a98d71daea186 Jack Wang 2020-05-11 1179
6a98d71daea186 Jack Wang 2020-05-11 1180 do_each_path(alive_sess, clt, &it) {
6a98d71daea186 Jack Wang 2020-05-11 1181 if (unlikely(READ_ONCE(alive_sess->state) !=
6a98d71daea186 Jack Wang 2020-05-11 1182 RTRS_CLT_CONNECTED))
6a98d71daea186 Jack Wang 2020-05-11 1183 continue;
6a98d71daea186 Jack Wang 2020-05-11 1184 req = rtrs_clt_get_copy_req(alive_sess, fail_req);
6a98d71daea186 Jack Wang 2020-05-11 1185 if (req->dir == DMA_TO_DEVICE)
6a98d71daea186 Jack Wang 2020-05-11 1186 err = rtrs_clt_write_req(req);
6a98d71daea186 Jack Wang 2020-05-11 1187 else
6a98d71daea186 Jack Wang 2020-05-11 1188 err = rtrs_clt_read_req(req);
6a98d71daea186 Jack Wang 2020-05-11 1189 if (unlikely(err)) {
6a98d71daea186 Jack Wang 2020-05-11 1190 req->in_use = false;
6a98d71daea186 Jack Wang 2020-05-11 1191 continue;
6a98d71daea186 Jack Wang 2020-05-11 1192 }
6a98d71daea186 Jack Wang 2020-05-11 1193 /* Success path */
6a98d71daea186 Jack Wang 2020-05-11 1194 rtrs_clt_inc_failover_cnt(alive_sess->stats);
6a98d71daea186 Jack Wang 2020-05-11 1195 break;
6a98d71daea186 Jack Wang 2020-05-11 @1196 } while_each_path(&it);
6a98d71daea186 Jack Wang 2020-05-11 1197
6a98d71daea186 Jack Wang 2020-05-11 1198 return err;
6a98d71daea186 Jack Wang 2020-05-11 1199 }
6a98d71daea186 Jack Wang 2020-05-11 1200
:::::: The code at line 1196 was first introduced by commit
:::::: 6a98d71daea186247005099758af549e6afdd244 RDMA/rtrs: client: main functionality
:::::: TO: Jack Wang <jinpu.wang@cloud.ionos.com>
:::::: CC: Jason Gunthorpe <jgg@mellanox.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72546 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [rdma:wip/jgg-for-next 106/128] drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting
@ 2020-05-18 2:27 ` kbuild test robot
0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-05-18 2:27 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3478 bytes --]
Hi Jack,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head: 41d5e318ccb34bded248a7a4c97264fdb1c8a42e
commit: c013fbc1fd341d28269cf0a6b465925186b9a1e1 [106/128] RDMA/rtrs: include client and server modules into kernel compilation
config: i386-allyesconfig (attached as .config)
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
smatch warnings:
drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting
drivers/infiniband/ulp/rtrs/rtrs-clt.c:2890 rtrs_clt_request() warn: inconsistent indenting
vim +1196 drivers/infiniband/ulp/rtrs/rtrs-clt.c
6a98d71daea186 Jack Wang 2020-05-11 1166
6a98d71daea186 Jack Wang 2020-05-11 1167 /**
6a98d71daea186 Jack Wang 2020-05-11 1168 * rtrs_clt_failover_req() Try to find an active path for a failed request
6a98d71daea186 Jack Wang 2020-05-11 1169 * @clt: clt context
6a98d71daea186 Jack Wang 2020-05-11 1170 * @fail_req: a failed io request.
6a98d71daea186 Jack Wang 2020-05-11 1171 */
6a98d71daea186 Jack Wang 2020-05-11 1172 static int rtrs_clt_failover_req(struct rtrs_clt *clt,
6a98d71daea186 Jack Wang 2020-05-11 1173 struct rtrs_clt_io_req *fail_req)
6a98d71daea186 Jack Wang 2020-05-11 1174 {
6a98d71daea186 Jack Wang 2020-05-11 1175 struct rtrs_clt_sess *alive_sess;
6a98d71daea186 Jack Wang 2020-05-11 1176 struct rtrs_clt_io_req *req;
6a98d71daea186 Jack Wang 2020-05-11 1177 int err = -ECONNABORTED;
6a98d71daea186 Jack Wang 2020-05-11 1178 struct path_it it;
6a98d71daea186 Jack Wang 2020-05-11 1179
6a98d71daea186 Jack Wang 2020-05-11 1180 do_each_path(alive_sess, clt, &it) {
6a98d71daea186 Jack Wang 2020-05-11 1181 if (unlikely(READ_ONCE(alive_sess->state) !=
6a98d71daea186 Jack Wang 2020-05-11 1182 RTRS_CLT_CONNECTED))
6a98d71daea186 Jack Wang 2020-05-11 1183 continue;
6a98d71daea186 Jack Wang 2020-05-11 1184 req = rtrs_clt_get_copy_req(alive_sess, fail_req);
6a98d71daea186 Jack Wang 2020-05-11 1185 if (req->dir == DMA_TO_DEVICE)
6a98d71daea186 Jack Wang 2020-05-11 1186 err = rtrs_clt_write_req(req);
6a98d71daea186 Jack Wang 2020-05-11 1187 else
6a98d71daea186 Jack Wang 2020-05-11 1188 err = rtrs_clt_read_req(req);
6a98d71daea186 Jack Wang 2020-05-11 1189 if (unlikely(err)) {
6a98d71daea186 Jack Wang 2020-05-11 1190 req->in_use = false;
6a98d71daea186 Jack Wang 2020-05-11 1191 continue;
6a98d71daea186 Jack Wang 2020-05-11 1192 }
6a98d71daea186 Jack Wang 2020-05-11 1193 /* Success path */
6a98d71daea186 Jack Wang 2020-05-11 1194 rtrs_clt_inc_failover_cnt(alive_sess->stats);
6a98d71daea186 Jack Wang 2020-05-11 1195 break;
6a98d71daea186 Jack Wang 2020-05-11 @1196 } while_each_path(&it);
6a98d71daea186 Jack Wang 2020-05-11 1197
6a98d71daea186 Jack Wang 2020-05-11 1198 return err;
6a98d71daea186 Jack Wang 2020-05-11 1199 }
6a98d71daea186 Jack Wang 2020-05-11 1200
:::::: The code at line 1196 was first introduced by commit
:::::: 6a98d71daea186247005099758af549e6afdd244 RDMA/rtrs: client: main functionality
:::::: TO: Jack Wang <jinpu.wang@cloud.ionos.com>
:::::: CC: Jason Gunthorpe <jgg@mellanox.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 72546 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 0/1] Fix kbuilt test smatch inconsistent intentation warning
2020-05-18 2:27 ` kbuild test robot
(?)
@ 2020-05-18 11:04 ` Danil Kipnis
2020-05-18 11:04 ` [PATCH 1/1] rtrs-clt: silence kbuild test inconsistent intenting smatch warning Danil Kipnis
-1 siblings, 1 reply; 4+ messages in thread
From: Danil Kipnis @ 2020-05-18 11:04 UTC (permalink / raw)
To: linux-rdma, jgg; +Cc: dledford, bvanassche, jinpu.wang, Danil Kipnis
Hi Jason, Hi All,
this silences the inconsistent intenting smatch warning in
the rtrs library found by kbuild test robot. Is this a strict
requirement to always clean this kind of warnings? Please apply
the patch in case it is.
Thank you,
Best
Danil.
Danil Kipnis (1):
rtrs-clt: silence kbuild test inconsistent intenting smatch warning
drivers/infiniband/ulp/rtrs/rtrs-clt.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] rtrs-clt: silence kbuild test inconsistent intenting smatch warning
2020-05-18 11:04 ` [PATCH 0/1] Fix kbuilt test smatch inconsistent intentation warning Danil Kipnis
@ 2020-05-18 11:04 ` Danil Kipnis
0 siblings, 0 replies; 4+ messages in thread
From: Danil Kipnis @ 2020-05-18 11:04 UTC (permalink / raw)
To: linux-rdma, jgg
Cc: dledford, bvanassche, jinpu.wang, Danil Kipnis, kbuild test robot
Kbuild test robot reports a smatch warning:
drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting
drivers/infiniband/ulp/rtrs/rtrs-clt.c:2890 rtrs_clt_request() warn: inconsistent indenting
To get rid of the warning, move the while_each_path() macro to a newline.
Rename the macro to end_each_path() to avoid the "while should follow close
brace '}'" checkpatch error.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
---
drivers/infiniband/ulp/rtrs/rtrs-clt.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index 468fdd0d8713..0fa3a229d90e 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -734,7 +734,7 @@ struct path_it {
(it)->i < (it)->clt->paths_num; \
(it)->i++)
-#define while_each_path(it) \
+#define end_each_path(it) \
path_it_deinit(it); \
rcu_read_unlock(); \
}
@@ -1193,7 +1193,8 @@ static int rtrs_clt_failover_req(struct rtrs_clt *clt,
/* Success path */
rtrs_clt_inc_failover_cnt(alive_sess->stats);
break;
- } while_each_path(&it);
+ }
+ end_each_path(&it);
return err;
}
@@ -2887,7 +2888,8 @@ int rtrs_clt_request(int dir, struct rtrs_clt_req_ops *ops,
}
/* Success path */
break;
- } while_each_path(&it);
+ }
+ end_each_path(&it);
return err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-18 11:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 2:27 [rdma:wip/jgg-for-next 106/128] drivers/infiniband/ulp/rtrs/rtrs-clt.c:1196 rtrs_clt_failover_req() warn: inconsistent indenting kbuild test robot
2020-05-18 2:27 ` kbuild test robot
2020-05-18 11:04 ` [PATCH 0/1] Fix kbuilt test smatch inconsistent intentation warning Danil Kipnis
2020-05-18 11:04 ` [PATCH 1/1] rtrs-clt: silence kbuild test inconsistent intenting smatch warning Danil Kipnis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.