[PATCH] iommu/omap: Add registration for DT fwnode pointer

[PATCH] iommu/omap: Add registration for DT fwnode pointer

[Tero Kristo via iommu]

The fwnode pointer must be passed to the iommu core, so that the core
can map the IOMMU towards device requests properly. Without this, some
IOMMU clients like OMAP remoteproc will fail the iommu configuration
multiple times with -EPROBE_DEFER, which will eventually be ignored with
a kernel warning banner.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 drivers/iommu/omap-iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 887fefcb03b4..934726e20b72 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -1248,6 +1248,7 @@ static int omap_iommu_probe(struct platform_device *pdev)
 			goto out_group;
 
 		iommu_device_set_ops(&obj->iommu, &omap_iommu_ops);
+		iommu_device_set_fwnode(&obj->iommu, &of->fwnode);
 
 		err = iommu_device_register(&obj->iommu);
 		if (err)
-- 
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] iommu/omap: Add registration for DT fwnode pointer

[Tero Kristo via iommu]

On 24/04/2020 17:58, Tero Kristo via iommu wrote:
> The fwnode pointer must be passed to the iommu core, so that the core
> can map the IOMMU towards device requests properly. Without this, some
> IOMMU clients like OMAP remoteproc will fail the iommu configuration
> multiple times with -EPROBE_DEFER, which will eventually be ignored with
> a kernel warning banner.
> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>

Hi Joerg,

I noticed this is still missing from next but there are some other OMAP 
iommu patches queued up (see the bug fix I just posted against -next.)

Whats the plan with this one?

-Tero

> ---
>   drivers/iommu/omap-iommu.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 887fefcb03b4..934726e20b72 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1248,6 +1248,7 @@ static int omap_iommu_probe(struct platform_device *pdev)
>   			goto out_group;
>   
>   		iommu_device_set_ops(&obj->iommu, &omap_iommu_ops);
> +		iommu_device_set_fwnode(&obj->iommu, &of->fwnode);
>   
>   		err = iommu_device_register(&obj->iommu);
>   		if (err)
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] iommu/omap: Add registration for DT fwnode pointer

[Joerg Roedel]

On Fri, Apr 24, 2020 at 05:58:28PM +0300, Tero Kristo wrote:
> The fwnode pointer must be passed to the iommu core, so that the core
> can map the IOMMU towards device requests properly. Without this, some
> IOMMU clients like OMAP remoteproc will fail the iommu configuration
> multiple times with -EPROBE_DEFER, which will eventually be ignored with
> a kernel warning banner.
> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
>  drivers/iommu/omap-iommu.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu