From: Jakub Kicinski <kuba@kernel.org>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: David Miller <davem@davemloft.net>,
olteanv@gmail.com, intel-wired-lan@lists.osuosl.org,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
vladimir.oltean@nxp.com, po.liu@nxp.com, m-karicheri2@ti.com,
Jose.Abreu@synopsys.com
Subject: Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption
Date: Mon, 18 May 2020 16:09:06 -0700 [thread overview]
Message-ID: <20200518160906.40e9d8bb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <87blmkq1y3.fsf@intel.com>
On Mon, 18 May 2020 16:05:08 -0700 Vinicius Costa Gomes wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> >> That was the (only?) strong argument in favor of having frame preemption
> >> in the TC side when this was last discussed.
> >>
> >> We can have a hybrid solution, we can move the express/preemptible per
> >> queue map to mqprio/taprio/whatever. And have the more specific
> >> configuration knobs, minimum fragment size, etc, in ethtool.
> >>
> >> What do you think?
> >
> > Does the standard specify minimum fragment size as a global MAC setting?
>
> Yes, it's a per-MAC setting, not per-queue.
If standard defines it as per-MAC and we can reasonably expect vendors
won't try to "add value" and make it per queue (unlikely here AFAIU),
then for this part ethtool configuration seems okay to me.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue RFC 0/4] ethtool: Add support for frame preemption
Date: Mon, 18 May 2020 16:09:06 -0700 [thread overview]
Message-ID: <20200518160906.40e9d8bb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <87blmkq1y3.fsf@intel.com>
On Mon, 18 May 2020 16:05:08 -0700 Vinicius Costa Gomes wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
> >> That was the (only?) strong argument in favor of having frame preemption
> >> in the TC side when this was last discussed.
> >>
> >> We can have a hybrid solution, we can move the express/preemptible per
> >> queue map to mqprio/taprio/whatever. And have the more specific
> >> configuration knobs, minimum fragment size, etc, in ethtool.
> >>
> >> What do you think?
> >
> > Does the standard specify minimum fragment size as a global MAC setting?
>
> Yes, it's a per-MAC setting, not per-queue.
If standard defines it as per-MAC and we can reasonably expect vendors
won't try to "add value" and make it per queue (unlikely here AFAIU),
then for this part ethtool configuration seems okay to me.
next prev parent reply other threads:[~2020-05-18 23:09 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 1:29 [next-queue RFC 0/4] ethtool: Add support for frame preemption Vinicius Costa Gomes
2020-05-16 1:29 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-16 1:29 ` [next-queue RFC 1/4] ethtool: Add support for configuring " Vinicius Costa Gomes
2020-05-16 1:29 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-19 15:27 ` Murali Karicheri
2020-05-19 15:27 ` [Intel-wired-lan] " Murali Karicheri
2020-05-16 1:29 ` [next-queue RFC 2/4] ethtool: Add support for configuring frame preemption via netlink Vinicius Costa Gomes
2020-05-16 1:29 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-18 12:27 ` Dan Carpenter
2020-05-18 12:27 ` Dan Carpenter
2020-05-16 1:29 ` [next-queue RFC 3/4] igc: Add support for configuring frame preemption Vinicius Costa Gomes
2020-05-16 1:29 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-19 16:36 ` Murali Karicheri
2020-05-19 16:36 ` [Intel-wired-lan] " Murali Karicheri
2020-05-16 1:29 ` [next-queue RFC 4/4] igc: Add support for exposing frame preemption stats registers Vinicius Costa Gomes
2020-05-16 1:29 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-20 12:50 ` Murali Karicheri
2020-05-20 12:50 ` [Intel-wired-lan] " Murali Karicheri
2020-05-16 9:33 ` [next-queue RFC 0/4] ethtool: Add support for frame preemption Michal Kubecek
2020-05-16 9:33 ` [Intel-wired-lan] " Michal Kubecek
2020-05-18 19:34 ` Vinicius Costa Gomes
2020-05-18 19:34 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-19 22:40 ` Andre Guedes
2020-05-19 22:40 ` [Intel-wired-lan] " Andre Guedes
2020-05-19 22:53 ` Vinicius Costa Gomes
2020-05-19 22:53 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-16 20:37 ` David Miller
2020-05-16 20:37 ` [Intel-wired-lan] " David Miller
2020-05-16 21:03 ` Vladimir Oltean
2020-05-16 21:03 ` [Intel-wired-lan] " Vladimir Oltean
2020-05-16 22:19 ` David Miller
2020-05-16 22:19 ` [Intel-wired-lan] " David Miller
2020-05-17 10:51 ` Vladimir Oltean
2020-05-17 10:51 ` [Intel-wired-lan] " Vladimir Oltean
2020-05-17 18:45 ` Andrew Lunn
2020-05-17 18:45 ` [Intel-wired-lan] " Andrew Lunn
2020-05-17 19:04 ` Vladimir Oltean
2020-05-17 19:04 ` [Intel-wired-lan] " Vladimir Oltean
2020-05-18 19:05 ` Vinicius Costa Gomes
2020-05-18 19:05 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-18 20:56 ` Jakub Kicinski
2020-05-18 20:56 ` [Intel-wired-lan] " Jakub Kicinski
2020-05-18 22:06 ` Vinicius Costa Gomes
2020-05-18 22:06 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-18 22:22 ` Jakub Kicinski
2020-05-18 22:22 ` [Intel-wired-lan] " Jakub Kicinski
2020-05-18 23:05 ` Vinicius Costa Gomes
2020-05-18 23:05 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-18 23:09 ` Jakub Kicinski [this message]
2020-05-18 23:09 ` Jakub Kicinski
2020-05-20 21:42 ` Andre Guedes
2020-05-20 21:42 ` Andre Guedes
2020-05-20 22:35 ` Vinicius Costa Gomes
2020-05-20 22:35 ` Vinicius Costa Gomes
2020-05-19 16:34 ` Murali Karicheri
2020-05-19 16:34 ` [Intel-wired-lan] " Murali Karicheri
2020-05-19 17:49 ` Vinicius Costa Gomes
2020-05-19 17:49 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-17 15:06 ` Michael Walle
2020-05-18 13:36 ` Murali Karicheri
2020-05-19 20:41 ` Michael Walle
2020-05-19 14:53 ` Murali Karicheri
2020-05-19 14:53 ` [Intel-wired-lan] " Murali Karicheri
2020-05-19 15:32 ` Vinicius Costa Gomes
2020-05-19 15:32 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-19 16:11 ` Murali Karicheri
2020-05-19 16:11 ` [Intel-wired-lan] " Murali Karicheri
2020-05-19 22:39 ` Andre Guedes
2020-05-19 22:39 ` [Intel-wired-lan] " Andre Guedes
2020-05-19 23:37 ` Vinicius Costa Gomes
2020-05-19 23:37 ` [Intel-wired-lan] " Vinicius Costa Gomes
2020-05-20 12:47 ` Murali Karicheri
2020-05-20 12:47 ` [Intel-wired-lan] " Murali Karicheri
2020-05-20 12:52 ` Joergen Andreasen
2020-05-20 12:52 ` [Intel-wired-lan] " Joergen Andreasen
2020-05-20 21:32 ` Vinicius Costa Gomes
2020-05-20 21:32 ` [Intel-wired-lan] " Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518160906.40e9d8bb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=Jose.Abreu@synopsys.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=po.liu@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.