* [PATCH] function_graph: apply tracing option 'irq-info'
@ 2020-05-16 16:09 Changbin Du
2020-05-18 21:25 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Changbin Du @ 2020-05-16 16:09 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Ingo Molnar, linux-kernel, Changbin Du
The tracing option 'irq-info' is only used by function tracer by far. This
patch makes it also against function graph tracer. Then the two tracers
have consistent behavior of this option.
Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
kernel/trace/trace_functions_graph.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index 4a9c49c08ec9..86e410907649 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -541,7 +541,7 @@ print_graph_irq(struct trace_iterator *iter, unsigned long addr,
}
/* Latency format */
- if (tr->trace_flags & TRACE_ITER_LATENCY_FMT)
+ if (tr->trace_flags & (TRACE_ITER_LATENCY_FMT | TRACE_ITER_IRQ_INFO))
print_graph_lat_fmt(s, ent);
}
@@ -753,7 +753,7 @@ print_graph_prologue(struct trace_iterator *iter, struct trace_seq *s,
}
/* Latency format */
- if (tr->trace_flags & TRACE_ITER_LATENCY_FMT)
+ if (tr->trace_flags & (TRACE_ITER_LATENCY_FMT | TRACE_ITER_IRQ_INFO))
print_graph_lat_fmt(s, ent);
return;
@@ -1135,7 +1135,7 @@ static void print_lat_header(struct seq_file *s, u32 flags)
static void __print_graph_headers_flags(struct trace_array *tr,
struct seq_file *s, u32 flags)
{
- int lat = tr->trace_flags & TRACE_ITER_LATENCY_FMT;
+ int lat = tr->trace_flags & (TRACE_ITER_LATENCY_FMT | TRACE_ITER_IRQ_INFO);
if (lat)
print_lat_header(s, flags);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] function_graph: apply tracing option 'irq-info'
2020-05-16 16:09 [PATCH] function_graph: apply tracing option 'irq-info' Changbin Du
@ 2020-05-18 21:25 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2020-05-18 21:25 UTC (permalink / raw)
To: Changbin Du; +Cc: Ingo Molnar, linux-kernel
On Sun, 17 May 2020 00:09:53 +0800
Changbin Du <changbin.du@gmail.com> wrote:
> The tracing option 'irq-info' is only used by function tracer by far. This
> patch makes it also against function graph tracer. Then the two tracers
> have consistent behavior of this option.
>
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
Sorry, the function graph tracer is unique, and yes, you need to enable
latency_format.
Note, irq_info is meaning less with the function_graph tracer, as it
doesn't change the latency_format with or without it.
This patch basically just makes the latency_format default for the
function_graph tracer, and changes default settings for no real advantage.
It will cause regressions.
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-18 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-16 16:09 [PATCH] function_graph: apply tracing option 'irq-info' Changbin Du
2020-05-18 21:25 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.