From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
David Jander <david@protonic.nl>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
mkl@pengutronix.de, Marek Vasut <marex@denx.de>,
Christian Herber <christian.herber@nxp.com>
Subject: Re: [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI)
Date: Tue, 19 May 2020 13:18:42 +0200 [thread overview]
Message-ID: <20200519111842.GC9046@lion.mk-sys.cz> (raw)
In-Reply-To: <20200519105855.p7nqklhwotueloko@pengutronix.de>
On Tue, May 19, 2020 at 12:58:55PM +0200, Oleksij Rempel wrote:
> On Tue, May 19, 2020 at 10:55:20AM +0200, Michal Kubecek wrote:
> > I'm also a bit worried about hardcoding the 0-7 value range. While I
> > understand that it's defined by standard for 100base-T1, we my want to
> > provide such information for other devices in the future. I tried to
> > search if there is something like that for 1000base-T1 and found this:
> >
> > http://www.sigent.cn/wp-content/uploads/2019/12/TE-1400_User-Manual_1000BASE-T1-EMC-Converter_v3.3.pdf
> >
> > The screenshot on page 10 shows "SQI Value: 00015".
>
> Nice, screenshot based reverse engineering :)
>
> > It's probably not
> > standardized (yet?) but it seems to indicate we may expect other devices
> > providing SQI information with different value range.
>
> what maximal range do we wont to export? u8, u16 or u32?
As the userspace API is "cast in stone" and there no actual space saved
by using u8 or u16 due to padding (attributes are always padded to
a multiple of 32 bits), I would suggest to go with u32 in uapi.
Internally, we can use a smaller type for now if it is more convenient.
Michal
next prev parent reply other threads:[~2020-05-19 11:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 7:51 [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI) Oleksij Rempel
2020-05-19 7:52 ` [PATCH net-next v1 2/2] net: phy: tja11xx: add SQI support Oleksij Rempel
2020-05-19 8:55 ` [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI) Michal Kubecek
2020-05-19 10:58 ` Oleksij Rempel
2020-05-19 11:18 ` Michal Kubecek [this message]
2020-05-19 13:26 ` Andrew Lunn
2020-05-20 4:55 ` Oleksij Rempel
2020-05-19 14:03 ` Andrew Lunn
2020-05-20 4:56 ` Oleksij Rempel
2020-05-19 11:21 Christian Herber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519111842.GC9046@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.