From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Michal Kubecek <mkubecek@suse.cz>, Marek Vasut <marex@denx.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
mkl@pengutronix.de, kernel@pengutronix.de,
David Jander <david@protonic.nl>,
Jakub Kicinski <kuba@kernel.org>,
Christian Herber <christian.herber@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI)
Date: Wed, 20 May 2020 06:56:26 +0200 [thread overview]
Message-ID: <20200520045626.hlsthjgxjqsah7zz@pengutronix.de> (raw)
In-Reply-To: <20200519140348.GI624248@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
On Tue, May 19, 2020 at 04:03:48PM +0200, Andrew Lunn wrote:
> > --- a/net/ethtool/common.c
> > +++ b/net/ethtool/common.c
> > @@ -310,6 +310,16 @@ int __ethtool_get_link(struct net_device *dev)
> > return netif_running(dev) && dev->ethtool_ops->get_link(dev);
> > }
> >
> > +int __ethtool_get_sqi(struct net_device *dev)
> > +{
> > + struct phy_device *phydev = dev->phydev;
> > +
> > + if (!phydev->drv->get_sqi)
> > + return -EOPNOTSUPP;
> > +
> > + return phydev->drv->get_sqi(phydev);
> > +}
> > +
>
> You are only providing access via netlink ethtool? There is no ioctl
> method to get this.
ack
> If so, i wonder if common.c is the correct place
> for this, or if it should be moved into linkstate.c. You can then drop
> the __.
ok
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-20 4:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 7:51 [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI) Oleksij Rempel
2020-05-19 7:52 ` [PATCH net-next v1 2/2] net: phy: tja11xx: add SQI support Oleksij Rempel
2020-05-19 8:55 ` [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI) Michal Kubecek
2020-05-19 10:58 ` Oleksij Rempel
2020-05-19 11:18 ` Michal Kubecek
2020-05-19 13:26 ` Andrew Lunn
2020-05-20 4:55 ` Oleksij Rempel
2020-05-19 14:03 ` Andrew Lunn
2020-05-20 4:56 ` Oleksij Rempel [this message]
2020-05-19 11:21 Christian Herber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520045626.hlsthjgxjqsah7zz@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=mkl@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.