All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	"Luis Oliveira" <lolivei@synopsys.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Michael Rodin" <mrodin@de.adit-jv.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Hugues Fruchet" <hugues.fruchet@st.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Adam Ford" <aford173@gmail.com>,
	"Todor Tomov" <todor.tomov@linaro.org>,
	"Suresh Udipi" <sudipi@jp.adit-jv.com>,
	"Andrew Gabbasov" <andrew_gabbasov@mentor.com>,
	"Eugeniu Rosca" <erosca@de.adit-jv.com>,
	"Dave Stevenson" <dave.stevenson@raspberrypi.org>
Subject: Re: [PATCH v2 4/6] media: ov5647: Use gpiod_set_value_cansleep
Date: Tue, 19 May 2020 14:57:35 +0300	[thread overview]
Message-ID: <20200519115735.GL20066@paasikivi.fi.intel.com> (raw)
In-Reply-To: <ff9d9fe93a50efdeced9efab7b38d72c7dabc08f.1589850165.git.roman.kovalivskyi@globallogic.com>

On Tue, May 19, 2020 at 04:16:19AM +0300, Roman Kovalivskyi wrote:
> From: Dave Stevenson <dave.stevenson@raspberrypi.org>
> 
> All calls to the gpio library are in contexts that can sleep,
> therefore there is no issue with having those GPIOs controlled
> by controllers which require sleeping (eg I2C GPIO expanders).
> 
> Switch to using gpiod_set_value_cansleep instead of gpiod_set_value
> to avoid triggering the warning in gpiolib should the GPIO
> controller need to sleep.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> Signed-off-by: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>

This needs to be merged with the 2nd patch.

-- 
Sakari Ailus

  reply	other threads:[~2020-05-19 11:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  1:16 [PATCH v2 0/6] ov5647 driver improvement Roman Kovalivskyi
     [not found] ` <cover.1589850165.git.roman.kovalivskyi@globallogic.com>
2020-05-19  1:16   ` [PATCH v2 1/6] media: ov5647: Add set_fmt and get_fmt calls Roman Kovalivskyi
2020-05-19 11:24     ` Sakari Ailus
2020-05-19 11:51       ` Sakari Ailus
2020-05-19  1:16   ` [PATCH v2 2/6] media: ov5647: Add support for PWDN GPIO Roman Kovalivskyi
2020-06-18 15:54     ` Jacopo Mondi
2020-05-19  1:16   ` [PATCH v2 3/6] media: ov5647: Add support for non-continuous clock mode Roman Kovalivskyi
2020-05-19 11:57     ` Sakari Ailus
2020-06-18 10:13       ` Jacopo Mondi
     [not found]         ` <7d718df8-5256-3ff6-01ec-2f1a14f53580@globallogic.com>
2020-06-22  8:35           ` Jacopo Mondi
2020-05-19  1:16   ` [PATCH v2 4/6] media: ov5647: Use gpiod_set_value_cansleep Roman Kovalivskyi
2020-05-19 11:57     ` Sakari Ailus [this message]
2020-05-19  1:16   ` [PATCH v2 5/6] media: dt-bindings: ov5647: Add property for PWDN control Roman Kovalivskyi
2020-05-19 11:51     ` Sakari Ailus
2020-05-19  1:16   ` [PATCH v2 6/6] media: dt-bindings: ov5647: Add property for non-continuous clock Roman Kovalivskyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519115735.GL20066@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=aford173@gmail.com \
    --cc=andrew_gabbasov@mentor.com \
    --cc=dave.stevenson@raspberrypi.org \
    --cc=erosca@de.adit-jv.com \
    --cc=hugues.fruchet@st.com \
    --cc=jacopo@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lolivei@synopsys.com \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=mrodin@de.adit-jv.com \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=roman.kovalivskyi@globallogic.com \
    --cc=sudipi@jp.adit-jv.com \
    --cc=todor.tomov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.