From: Jacopo Mondi <jacopo@jmondi.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: "Roman Kovalivskyi" <roman.kovalivskyi@globallogic.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
"Luis Oliveira" <lolivei@synopsys.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Michael Rodin" <mrodin@de.adit-jv.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hugues Fruchet" <hugues.fruchet@st.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Adam Ford" <aford173@gmail.com>,
"Todor Tomov" <todor.tomov@linaro.org>,
"Suresh Udipi" <sudipi@jp.adit-jv.com>,
"Andrew Gabbasov" <andrew_gabbasov@mentor.com>,
"Eugeniu Rosca" <erosca@de.adit-jv.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.org>
Subject: Re: [PATCH v2 3/6] media: ov5647: Add support for non-continuous clock mode
Date: Thu, 18 Jun 2020 12:13:26 +0200 [thread overview]
Message-ID: <20200618101326.zpcdcb3zdrtgz45t@uno.localdomain> (raw)
In-Reply-To: <20200519115707.GK20066@paasikivi.fi.intel.com>
Hi Roman, Sakari
On Tue, May 19, 2020 at 02:57:07PM +0300, Sakari Ailus wrote:
> Hi Roman,
>
> On Tue, May 19, 2020 at 04:16:18AM +0300, Roman Kovalivskyi wrote:
> > From: Dave Stevenson <dave.stevenson@raspberrypi.org>
> >
> > The driver was only supporting continuous clock mode
> > although this was not stated anywhere.
> > Non-continuous clock saves a small amount of power and
> > on some SoCs is easier to interface with.
> >
not much to add to what Sakari said, apart for
> > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> > Signed-off-by: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
> > ---
> > drivers/media/i2c/ov5647.c | 25 ++++++++++++++++++++++---
> > 1 file changed, 22 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
> > index 796cc80f8ee1..10f35c637f91 100644
> > --- a/drivers/media/i2c/ov5647.c
> > +++ b/drivers/media/i2c/ov5647.c
> > @@ -44,6 +44,7 @@
> > #define PWDN_ACTIVE_DELAY_MS 20
> >
> > #define MIPI_CTRL00_CLOCK_LANE_GATE BIT(5)
> > +#define MIPI_CTRL00_LINE_SYNC_ENABLE BIT(4)
> > #define MIPI_CTRL00_BUS_IDLE BIT(2)
> > #define MIPI_CTRL00_CLOCK_LANE_DISABLE BIT(0)
> >
> > @@ -95,6 +96,7 @@ struct ov5647 {
> > int power_count;
> > struct clk *xclk;
> > struct gpio_desc *pwdn;
> > + bool is_clock_contiguous;
the clock is 'continuous' not contigous :)
I plan to upport more ov5647 patches soon, Roman are you planning a
resend of this series or should I do so (keeping your signoffs of
course)
Thanks
j
> > };
> >
> > static inline struct ov5647 *to_state(struct v4l2_subdev *sd)
> > @@ -274,9 +276,15 @@ static int ov5647_set_virtual_channel(struct v4l2_subdev *sd, int channel)
> >
> > static int ov5647_stream_on(struct v4l2_subdev *sd)
> > {
> > + struct ov5647 *ov5647 = to_state(sd);
> > + u8 val = MIPI_CTRL00_BUS_IDLE;
> > int ret;
> >
> > - ret = ov5647_write(sd, OV5647_REG_MIPI_CTRL00, MIPI_CTRL00_BUS_IDLE);
> > + if (ov5647->is_clock_contiguous)
> > + val |= MIPI_CTRL00_CLOCK_LANE_GATE |
> > + MIPI_CTRL00_LINE_SYNC_ENABLE;
> > +
> > + ret = ov5647_write(sd, OV5647_REG_MIPI_CTRL00, val);
> > if (ret < 0)
> > return ret;
> >
> > @@ -573,7 +581,7 @@ static const struct v4l2_subdev_internal_ops ov5647_subdev_internal_ops = {
> > .open = ov5647_open,
> > };
> >
> > -static int ov5647_parse_dt(struct device_node *np)
> > +static int ov5647_parse_dt(struct ov5647 *sensor, struct device_node *np)
> > {
> > struct v4l2_fwnode_endpoint bus_cfg = { .bus_type = 0 };
> > struct device_node *ep;
> > @@ -586,6 +594,17 @@ static int ov5647_parse_dt(struct device_node *np)
> >
> > ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &bus_cfg);
> >
>
> Extra newline.
>
> > + if (!ret) {
> > + of_node_put(ep);
> > + of_node_put(np);
>
> Why to put np as well?
>
> > + return ret;
>
> Please add a label at the end; it makes error handling easier.
>
> > + }
> > +
> > + if (bus_cfg.bus_type == V4L2_MBUS_CSI2_DPHY
> > + || bus_cfg.bus_type == V4L2_MBUS_CSI2_CPHY)
>
> I bet this device is D-PHY only.
>
> > + sensor->is_clock_contiguous = bus_cfg.bus.mipi_csi2.flags
> > + & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK;
>
> Now that you're making use of bus specific parameters, please set the bus
> type first before calling v4l2_fwnode_endpoint_parse().
>
> > +
> > of_node_put(ep);
> > return ret;
> > }
> > @@ -604,7 +623,7 @@ static int ov5647_probe(struct i2c_client *client)
> > return -ENOMEM;
> >
> > if (IS_ENABLED(CONFIG_OF) && np) {
> > - ret = ov5647_parse_dt(np);
> > + ret = ov5647_parse_dt(sensor, np);
> > if (ret) {
> > dev_err(dev, "DT parsing error: %d\n", ret);
> > return ret;
>
> --
> Kind regards,
>
> Sakari Ailus
next prev parent reply other threads:[~2020-06-18 10:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 1:16 [PATCH v2 0/6] ov5647 driver improvement Roman Kovalivskyi
[not found] ` <cover.1589850165.git.roman.kovalivskyi@globallogic.com>
2020-05-19 1:16 ` [PATCH v2 1/6] media: ov5647: Add set_fmt and get_fmt calls Roman Kovalivskyi
2020-05-19 11:24 ` Sakari Ailus
2020-05-19 11:51 ` Sakari Ailus
2020-05-19 1:16 ` [PATCH v2 2/6] media: ov5647: Add support for PWDN GPIO Roman Kovalivskyi
2020-06-18 15:54 ` Jacopo Mondi
2020-05-19 1:16 ` [PATCH v2 3/6] media: ov5647: Add support for non-continuous clock mode Roman Kovalivskyi
2020-05-19 11:57 ` Sakari Ailus
2020-06-18 10:13 ` Jacopo Mondi [this message]
[not found] ` <7d718df8-5256-3ff6-01ec-2f1a14f53580@globallogic.com>
2020-06-22 8:35 ` Jacopo Mondi
2020-05-19 1:16 ` [PATCH v2 4/6] media: ov5647: Use gpiod_set_value_cansleep Roman Kovalivskyi
2020-05-19 11:57 ` Sakari Ailus
2020-05-19 1:16 ` [PATCH v2 5/6] media: dt-bindings: ov5647: Add property for PWDN control Roman Kovalivskyi
2020-05-19 11:51 ` Sakari Ailus
2020-05-19 1:16 ` [PATCH v2 6/6] media: dt-bindings: ov5647: Add property for non-continuous clock Roman Kovalivskyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618101326.zpcdcb3zdrtgz45t@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=aford173@gmail.com \
--cc=andrew_gabbasov@mentor.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=erosca@de.adit-jv.com \
--cc=hugues.fruchet@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lolivei@synopsys.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=mrodin@de.adit-jv.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=roman.kovalivskyi@globallogic.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sudipi@jp.adit-jv.com \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.