[meta-oe][PATCH] unicode-ucd: Remove pointless license check

[meta-oe][PATCH] unicode-ucd: Remove pointless license check

[Adrian Bunk]

WARNING: unicode-ucd-12.1.0-r0 do_fetch: Checksum mismatch for local file /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html
Cleaning and trying again.
WARNING: unicode-ucd-12.1.0-r0 do_fetch: Renaming /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html to /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html_bad-checksum_e9dd7d435db23241be3be21b5fca729b5cf883c8c039a70ea093031420d06abb
WARNING: unicode-ucd-12.1.0-r0 do_fetch: Checksum failure encountered with download of https://www.unicode.org/license.html;name=license;subdir=unicode-ucd-12.1.0;downloadfilename=unicode.org.license.html - will attempt other sources if available

This downloaded a license file from upstream.
The upstream file did not match (copyright year changed).
A stale copy was downloaded from a mirror instead and checked.
The stale file with known contents never changes.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
 meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb b/meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb
index 89ab565ce..dc1251777 100644
--- a/meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb
+++ b/meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb
@@ -1,18 +1,15 @@
 SUMMARY = "Unicode Character Database"
 HOMEPAGE = "https://unicode.org/ucd/"
 LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://unicode.org.license.html;beginline=42;endline=85;md5=67619d0c52706853c0256514e7fd04cd"
+
+ERROR_QA_remove = "license-checksum"
 
 SRC_URI = " \
     https://www.unicode.org/Public/zipped/${PV}/UCD.zip;name=ucd;subdir=ucd \
-    https://www.unicode.org/license.html;name=license;subdir=${BP};downloadfilename=unicode.org.license.html \
 "
 SRC_URI[ucd.md5sum] = "430cbdac2615451571dd69a976dd08f6"
 SRC_URI[ucd.sha256sum] = "25ba51a0d4c6fa41047b7a5e5733068d4a734588f055f61e85f450097834a0a6"
 
-SRC_URI[license.md5sum] = "f03bafb623258f85ff2032c1ce567b7c"
-SRC_URI[license.sha256sum] = "983225207de8a707d0903a8d70fb7a4b28c5e0f64f2366e84a6192a2d618fed4"
-
 inherit allarch
 
 do_configure[noexec] = "1"
-- 
2.17.1

Re: [oe] [meta-oe][PATCH] unicode-ucd: Remove pointless license check

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2646 bytes --]

On Mon, May 18, 2020 at 5:10 AM Adrian Bunk <bunk@stusta.de> wrote:

> WARNING: unicode-ucd-12.1.0-r0 do_fetch: Checksum mismatch for local file
> /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html
> Cleaning and trying again.
> WARNING: unicode-ucd-12.1.0-r0 do_fetch: Renaming
> /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org.license.html to
> /home/bunk/yoctomaster/yocto-tmp/downloads/unicode.org
> .license.html_bad-checksum_e9dd7d435db23241be3be21b5fca729b5cf883c8c039a70ea093031420d06abb
> WARNING: unicode-ucd-12.1.0-r0 do_fetch: Checksum failure encountered with
> download of
> https://www.unicode.org/license.html;name=license;subdir=unicode-ucd-12.1.0;downloadfilename=unicode.org.license.html
> - will attempt other sources if available
>
> This downloaded a license file from upstream.
> The upstream file did not match (copyright year changed).
> A stale copy was downloaded from a mirror instead and checked.
> The stale file with known contents never changes.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
>  meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb
> b/meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb
> index 89ab565ce..dc1251777 100644
> --- a/meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb
> +++ b/meta-oe/recipes-support/unicode-ucd/unicode-ucd_12.1.0.bb
> @@ -1,18 +1,15 @@
>  SUMMARY = "Unicode Character Database"
>  HOMEPAGE = "https://unicode.org/ucd/"
>  LICENSE = "MIT"
> -LIC_FILES_CHKSUM =
> "file://unicode.org.license.html;beginline=42;endline=85;md5=67619d0c52706853c0256514e7fd04cd"
> +
> +ERROR_QA_remove = "license-checksum"


Isn’t there any other file in archive to checksum ?
If not perhaps add one or compare against the MIT template from licenses
from OE-core having no entry can trip post processing tools


>
>  SRC_URI = " \
>
> https://www.unicode.org/Public/zipped/${PV}/UCD.zip;name=ucd;subdir=ucd \
> -
> https://www.unicode.org/license.html;name=license;subdir=${BP};downloadfilename=unicode.org.license.html
> \
>  "
>  SRC_URI[ucd.md5sum] = "430cbdac2615451571dd69a976dd08f6"
>  SRC_URI[ucd.sha256sum] =
> "25ba51a0d4c6fa41047b7a5e5733068d4a734588f055f61e85f450097834a0a6"
>
> -SRC_URI[license.md5sum] = "f03bafb623258f85ff2032c1ce567b7c"
> -SRC_URI[license.sha256sum] =
> "983225207de8a707d0903a8d70fb7a4b28c5e0f64f2366e84a6192a2d618fed4"
> -
>  inherit allarch
>
>  do_configure[noexec] = "1"
> --
> 2.17.1
>
> 
>

[-- Attachment #2: Type: text/html, Size: 4391 bytes --]

Re: [oe] [meta-oe][PATCH] unicode-ucd: Remove pointless license check

[Adrian Bunk]

On Mon, May 18, 2020 at 08:10:21AM -0700, Khem Raj wrote:
> 
> Isn’t there any other file in archive to checksum ?
> If not perhaps add one or compare against the MIT template from licenses
> from OE-core having no entry can trip post processing tools

I've sent a new version that adds a local copy of the license.

cu
Adrian