[oe-core][PATCH 1/1] acpica: gcc-10

[oe-core][PATCH 1/1] acpica: gcc-10

[Joe Slater]

Advance to version 20200430 to avoid multiple definition errors for uninitialized variables.
In this case, it is not enough to add -fcommon to CFLAGS.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
 .../acpica/{acpica_20200214.bb => acpica_20200430.bb}                 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-extended/acpica/{acpica_20200214.bb => acpica_20200430.bb} (91%)

diff --git a/meta/recipes-extended/acpica/acpica_20200214.bb b/meta/recipes-extended/acpica/acpica_20200430.bb
similarity index 91%
rename from meta/recipes-extended/acpica/acpica_20200214.bb
rename to meta/recipes-extended/acpica/acpica_20200430.bb
index cfa9fec..478be7f 100644
--- a/meta/recipes-extended/acpica/acpica_20200214.bb
+++ b/meta/recipes-extended/acpica/acpica_20200430.bb
@@ -17,8 +17,8 @@ COMPATIBLE_HOST = "(i.86|x86_64|arm|aarch64).*-linux"
 DEPENDS = "m4-native flex-native bison-native"
 
 SRC_URI = "https://acpica.org/sites/acpica/files/acpica-unix-${PV}.tar.gz"
-SRC_URI[md5sum] = "3505ba6170b77db1399eae0e2a959113"
-SRC_URI[sha256sum] = "e77ab9f8557ca104f6e8f49efaa8eead29f78ca11cadfc8989012469ecc0738e"
+SRC_URI[sha256sum] = "fb807f1dec31664f972af37d213abf72987afe33abf68c83051e298da35d297c"
+
 UPSTREAM_CHECK_URI = "https://acpica.org/downloads"
 
 S = "${WORKDIR}/acpica-unix-${PV}"
-- 
2.7.4

[oe-core][PATCH 1/3] squashfs-tools: gcc-10

[Joe Slater]

Add -fcommon to CFLAGS to avoid multiple definition errors for uninitialized variables.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
 meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb b/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb
index 9bcf026ce2..d3f42a84fe 100644
--- a/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb
+++ b/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb
@@ -12,6 +12,8 @@ SRC_URI = "git://github.com/plougher/squashfs-tools.git;protocol=https \
 
 S = "${WORKDIR}/git/squashfs-tools"
 
+CFLAGS_append = " -fcommon"
+
 EXTRA_OEMAKE = "${PACKAGECONFIG_CONFARGS}"
 
 PACKAGECONFIG ??= "gzip xz lzo lz4 lzma xattr reproducible"
-- 
2.26.2

[PATCH 2/3] syslinux: gcc-10

[Joe Slater]

Add -fcommon to CFLAGS to avoid multiple definition errors for uninitialized variables.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
 meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb b/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb
index e9dbefb930..5dfcfeec02 100644
--- a/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb
+++ b/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb
@@ -40,6 +40,10 @@ EXTRA_OEMAKE = " \
 	DATADIR=${datadir} MANDIR=${mandir} INCDIR=${includedir} \
 "
 
+# necessary for gcc-10
+#
+CFLAGS_append = " -fcommon"
+
 do_configure() {
 	# drop win32 targets or build fails
 	sed -e 's,win32/\S*,,g' -i Makefile
-- 
2.26.2

Re: [OE-core] [PATCH 2/3] syslinux: gcc-10

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

Wasn't this fixed by:
https://lists.openembedded.org/g/openembedded-core/message/138364
?

On Tue, May 19, 2020 at 11:10 PM Joe Slater <joe.slater@windriver.com>
wrote:

> Add -fcommon to CFLAGS to avoid multiple definition errors for
> uninitialized variables.
>
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
>  meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb
> b/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb
> index e9dbefb930..5dfcfeec02 100644
> --- a/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb
> +++ b/meta/recipes-devtools/syslinux/syslinux_6.04-pre2.bb
> @@ -40,6 +40,10 @@ EXTRA_OEMAKE = " \
>         DATADIR=${datadir} MANDIR=${mandir} INCDIR=${includedir} \
>  "
>
> +# necessary for gcc-10
> +#
> +CFLAGS_append = " -fcommon"
> +
>  do_configure() {
>         # drop win32 targets or build fails
>         sed -e 's,win32/\S*,,g' -i Makefile
> --
> 2.26.2
>
> 
>

[-- Attachment #2: Type: text/html, Size: 1988 bytes --]

Re: [oe-core][PATCH 1/3] squashfs-tools: gcc-10

[Jacob Kroon]

Hi Joe,

On 5/19/20 11:09 PM, Joe Slater wrote:
> Add -fcommon to CFLAGS to avoid multiple definition errors for uninitialized variables.
> 
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
>   meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb | 2 ++
>   1 file changed, 2 insertions(+)
>

[cut]

I hope this is already fixed in master by:

https://git.openembedded.org/openembedded-core/commit/?id=bae1603a27fadcfa7257801167f28db3ff02dc97

?

/Jacob

Re: [oe-core][PATCH 1/3] squashfs-tools: gcc-10

[Adrian Bunk]

On Tue, May 19, 2020 at 02:09:27PM -0700, Joe Slater wrote:
> Add -fcommon to CFLAGS to avoid multiple definition errors for uninitialized variables.
>...

The upstream fix is already backported in master.

cu
Adrian