* [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS
@ 2020-05-20 7:51 Joel Stanley
[not found] ` <20200520075134.1048589-1-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2020-05-20 7:51 UTC (permalink / raw)
To: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA, David Gibson; +Cc: Stephen Rothwell
dtc does a sanity check on reg properties that they are within the 10
bit address range for i2c slave addresses. In the case of multi-master
buses the binding may describe an address that the bus will listen on as
a device. Do not warn when this flag is set.
This fixes the following build warnings reported by Stephen:
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4:
Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:
I2C bus unit address format error, expected "40000010"
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30:
Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg:
I2C address must be less than 10-bits, got "0x40000010"
Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Signed-off-by: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
---
checks.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/checks.c b/checks.c
index a8213c0e13a8..2c23dd4f7778 100644
--- a/checks.c
+++ b/checks.c
@@ -1022,6 +1022,8 @@ static void check_i2c_bus_bridge(struct check *c, struct dt_info *dti, struct no
}
WARNING(i2c_bus_bridge, check_i2c_bus_bridge, NULL, &addr_size_cells);
+#define I2C_OWN_SLAVE_ADDRESS (1 << 30)
+
static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node *node)
{
struct property *prop;
@@ -1044,6 +1046,8 @@ static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node
}
reg = fdt32_to_cpu(*cells);
+ /* Ingore I2C_OWN_SLAVE_ADDRESS */
+ reg &= ~I2C_OWN_SLAVE_ADDRESS;
snprintf(unit_addr, sizeof(unit_addr), "%x", reg);
if (!streq(unitname, unit_addr))
FAIL(c, dti, node, "I2C bus unit address format error, expected \"%s\"",
@@ -1051,6 +1055,8 @@ static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node
for (len = prop->val.len; len > 0; len -= 4) {
reg = fdt32_to_cpu(*(cells++));
+ /* Ingore I2C_OWN_SLAVE_ADDRESS */
+ reg &= ~I2C_OWN_SLAVE_ADDRESS;
if (reg > 0x3ff)
FAIL_PROP(c, dti, node, prop, "I2C address must be less than 10-bits, got \"0x%x\"",
reg);
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS
[not found] ` <20200520075134.1048589-1-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
@ 2020-05-21 5:09 ` David Gibson
[not found] ` <20200521050914.GE63349-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: David Gibson @ 2020-05-21 5:09 UTC (permalink / raw)
To: Joel Stanley; +Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA, Stephen Rothwell
[-- Attachment #1: Type: text/plain, Size: 2649 bytes --]
On Wed, May 20, 2020 at 05:21:34PM +0930, Joel Stanley wrote:
> dtc does a sanity check on reg properties that they are within the 10
> bit address range for i2c slave addresses. In the case of multi-master
> buses the binding may describe an address that the bus will listen on as
> a device. Do not warn when this flag is set.
>
> This fixes the following build warnings reported by Stephen:
>
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4:
> Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:
> I2C bus unit address format error, expected "40000010"
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30:
> Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg:
> I2C address must be less than 10-bits, got "0x40000010"
>
> Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> Signed-off-by: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
Any document you can give a pointer two explaining the special meaning
of this bit?
> ---
> checks.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/checks.c b/checks.c
> index a8213c0e13a8..2c23dd4f7778 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -1022,6 +1022,8 @@ static void check_i2c_bus_bridge(struct check *c, struct dt_info *dti, struct no
> }
> WARNING(i2c_bus_bridge, check_i2c_bus_bridge, NULL, &addr_size_cells);
>
> +#define I2C_OWN_SLAVE_ADDRESS (1 << 30)
> +
> static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node *node)
> {
> struct property *prop;
> @@ -1044,6 +1046,8 @@ static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node
> }
>
> reg = fdt32_to_cpu(*cells);
> + /* Ingore I2C_OWN_SLAVE_ADDRESS */
Also, s/Ingore/Ignore/g
> + reg &= ~I2C_OWN_SLAVE_ADDRESS;
> snprintf(unit_addr, sizeof(unit_addr), "%x", reg);
> if (!streq(unitname, unit_addr))
> FAIL(c, dti, node, "I2C bus unit address format error, expected \"%s\"",
> @@ -1051,6 +1055,8 @@ static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node
>
> for (len = prop->val.len; len > 0; len -= 4) {
> reg = fdt32_to_cpu(*(cells++));
> + /* Ingore I2C_OWN_SLAVE_ADDRESS */
> + reg &= ~I2C_OWN_SLAVE_ADDRESS;
> if (reg > 0x3ff)
> FAIL_PROP(c, dti, node, prop, "I2C address must be less than 10-bits, got \"0x%x\"",
> reg);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS
[not found] ` <20200521050914.GE63349-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
@ 2020-05-21 6:50 ` Stephen Rothwell
[not found] ` <20200521165009.5668082b-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-05-21 6:50 UTC (permalink / raw)
To: David Gibson; +Cc: Joel Stanley, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]
Hi David,
On Thu, 21 May 2020 15:09:14 +1000 David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6iEOx6SR5NKn@public.gmane.orgu> wrote:
>
> On Wed, May 20, 2020 at 05:21:34PM +0930, Joel Stanley wrote:
> > dtc does a sanity check on reg properties that they are within the 10
> > bit address range for i2c slave addresses. In the case of multi-master
> > buses the binding may describe an address that the bus will listen on as
> > a device. Do not warn when this flag is set.
> >
> > This fixes the following build warnings reported by Stephen:
> >
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4:
> > Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:
> > I2C bus unit address format error, expected "40000010"
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30:
> > Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg:
> > I2C address must be less than 10-bits, got "0x40000010"
> >
> > Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> > Signed-off-by: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
>
> Any document you can give a pointer two explaining the special meaning
> of this bit?
include/dt-bindings/i2c/i2c.h
Is Documentation/devicetree/bindings/i2c/i2c.txt in the kernel tree
sufficient? I2C_OWN_SLAVE_ADDRESS has been in there since the file was
introduced in August 2015. The actual value has been in
include/dt-bindings/i2c/i2c.h since the same time.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS
[not found] ` <20200521165009.5668082b-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
@ 2020-05-22 7:48 ` David Gibson
0 siblings, 0 replies; 4+ messages in thread
From: David Gibson @ 2020-05-22 7:48 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Joel Stanley, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 2106 bytes --]
On Thu, May 21, 2020 at 04:50:09PM +1000, Stephen Rothwell wrote:
> Hi David,
>
> On Thu, 21 May 2020 15:09:14 +1000 David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6ryscVyMRj84@public.gmane.org.au> wrote:
> >
> > On Wed, May 20, 2020 at 05:21:34PM +0930, Joel Stanley wrote:
> > > dtc does a sanity check on reg properties that they are within the 10
> > > bit address range for i2c slave addresses. In the case of multi-master
> > > buses the binding may describe an address that the bus will listen on as
> > > a device. Do not warn when this flag is set.
> > >
> > > This fixes the following build warnings reported by Stephen:
> > >
> > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4:
> > > Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:
> > > I2C bus unit address format error, expected "40000010"
> > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30:
> > > Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg:
> > > I2C address must be less than 10-bits, got "0x40000010"
> > >
> > > Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> > > Signed-off-by: Joel Stanley <joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
> >
> > Any document you can give a pointer two explaining the special meaning
> > of this bit?
> include/dt-bindings/i2c/i2c.h
> Is Documentation/devicetree/bindings/i2c/i2c.txt in the kernel tree
> sufficient?
Good enough.
> I2C_OWN_SLAVE_ADDRESS has been in there since the file was
> introduced in August 2015. The actual value has been in
> include/dt-bindings/i2c/i2c.h since the same time.
Looking at that, though, it seems like we should also ignore the
I2C_TEN_BIT_ADDRESS flag. Or better yet, not ignore it but validate
the base addres is under 7 bits unless its set.
Can we refine that a bit, and fix the spelling errors?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-22 7:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 7:51 [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS Joel Stanley
[not found] ` <20200520075134.1048589-1-joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>
2020-05-21 5:09 ` David Gibson
[not found] ` <20200521050914.GE63349-K0bRW+63XPQe6aEkudXLsA@public.gmane.org>
2020-05-21 6:50 ` Stephen Rothwell
[not found] ` <20200521165009.5668082b-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2020-05-22 7:48 ` David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.