[PATCH 1/2] drm: DPMS is no longer the only mutable connector prop

[PATCH 1/2] drm: DPMS is no longer the only mutable connector prop

[Simon Ser]

There are a bunch of other writable connector properties now.

Signed-off-by: Simon Ser <contact@emersion.fr>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Cc: Michel Dänzer <michel@daenzer.net>
---
 drivers/gpu/drm/drm_connector.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index b1099e1251a2..f2b20fd66319 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -948,8 +948,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = {
  * 	connector is linked to. Drivers should never set this property directly,
  * 	it is handled by the DRM core by calling the &drm_connector_funcs.dpms
  * 	callback. For atomic drivers the remapping to the "ACTIVE" property is
- * 	implemented in the DRM core.  This is the only standard connector
- * 	property that userspace can change.
+ * 	implemented in the DRM core.
  *
  * 	Note that this property cannot be set through the MODE_ATOMIC ioctl,
  * 	userspace must use "ACTIVE" on the CRTC instead.
-- 
2.26.2


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm: DPMS is no longer the only mutable connector prop

[Daniel Vetter]

On Mon, May 18, 2020 at 02:22:28PM +0000, Simon Ser wrote:
> There are a bunch of other writable connector properties now.
> 
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
> Cc: Michel Dänzer <michel@daenzer.net>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I think in general the list of connector properties has become rather
sprawling and disorganized ...
-Daniel

> ---
>  drivers/gpu/drm/drm_connector.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index b1099e1251a2..f2b20fd66319 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -948,8 +948,7 @@ static const struct drm_prop_enum_list dp_colorspaces[] = {
>   * 	connector is linked to. Drivers should never set this property directly,
>   * 	it is handled by the DRM core by calling the &drm_connector_funcs.dpms
>   * 	callback. For atomic drivers the remapping to the "ACTIVE" property is
> - * 	implemented in the DRM core.  This is the only standard connector
> - * 	property that userspace can change.
> + * 	implemented in the DRM core.
>   *
>   * 	Note that this property cannot be set through the MODE_ATOMIC ioctl,
>   * 	userspace must use "ACTIVE" on the CRTC instead.
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel