From: kbuild test robot <lkp@intel.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>, jic23@kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
kamel.bouhara@bootlin.com, gwendal@chromium.org,
alexandre.belloni@bootlin.com, david@lechnology.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com
Subject: Re: [PATCH v2 1/4] counter: Internalize sysfs interface code
Date: Wed, 20 May 2020 21:10:57 +0800 [thread overview]
Message-ID: <202005202102.sde2NJjF%lkp@intel.com> (raw)
In-Reply-To: <733a915d9334c06bbe51928fb0f75d262d39bb02.1589654470.git.vilhelm.gray@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3280 bytes --]
Hi William,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.7-rc6 next-20200519]
[cannot apply to stm32/stm32-next linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20200517-032530
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 12bf0b632ed090358cbf03e323e5342212d0b2e4
config: arm64-randconfig-r026-20200519 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/counter/counter-sysfs.c:850:5: warning: no previous prototype for function 'counter_sysfs_add' [-Wmissing-prototypes]
int counter_sysfs_add(struct counter_device *const counter)
^
drivers/counter/counter-sysfs.c:850:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int counter_sysfs_add(struct counter_device *const counter)
^
static
>> drivers/counter/counter-sysfs.c:876:6: warning: no previous prototype for function 'counter_sysfs_free' [-Wmissing-prototypes]
void counter_sysfs_free(struct counter_device *const counter)
^
drivers/counter/counter-sysfs.c:876:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void counter_sysfs_free(struct counter_device *const counter)
^
static
2 warnings generated.
vim +/counter_sysfs_add +850 drivers/counter/counter-sysfs.c
849
> 850 int counter_sysfs_add(struct counter_device *const counter)
851 {
852 int err;
853
854 /* Initialize Synapse names list */
855 INIT_LIST_HEAD(&counter->dynamic_names_list);
856
857 /* Prepare device attributes */
858 err = counter_groups_list_prepare(counter);
859 if (err)
860 goto err_free_names;
861
862 /* Organize device attributes to groups and match to device */
863 err = counter_groups_prepare(counter);
864 if (err)
865 goto err_free_groups_list;
866
867 return 0;
868
869 err_free_groups_list:
870 counter_groups_list_free(counter);
871 err_free_names:
872 counter_dynamic_names_free(&counter->dynamic_names_list);
873 return err;
874 }
875
> 876 void counter_sysfs_free(struct counter_device *const counter)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38774 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>, jic23@kernel.org
Cc: kamel.bouhara@bootlin.com, gwendal@chromium.org,
kbuild-all@lists.01.org, david@lechnology.com,
linux-iio@vger.kernel.org, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
syednwaris@gmail.com, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] counter: Internalize sysfs interface code
Date: Wed, 20 May 2020 21:10:57 +0800 [thread overview]
Message-ID: <202005202102.sde2NJjF%lkp@intel.com> (raw)
In-Reply-To: <733a915d9334c06bbe51928fb0f75d262d39bb02.1589654470.git.vilhelm.gray@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3280 bytes --]
Hi William,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.7-rc6 next-20200519]
[cannot apply to stm32/stm32-next linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20200517-032530
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 12bf0b632ed090358cbf03e323e5342212d0b2e4
config: arm64-randconfig-r026-20200519 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/counter/counter-sysfs.c:850:5: warning: no previous prototype for function 'counter_sysfs_add' [-Wmissing-prototypes]
int counter_sysfs_add(struct counter_device *const counter)
^
drivers/counter/counter-sysfs.c:850:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int counter_sysfs_add(struct counter_device *const counter)
^
static
>> drivers/counter/counter-sysfs.c:876:6: warning: no previous prototype for function 'counter_sysfs_free' [-Wmissing-prototypes]
void counter_sysfs_free(struct counter_device *const counter)
^
drivers/counter/counter-sysfs.c:876:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void counter_sysfs_free(struct counter_device *const counter)
^
static
2 warnings generated.
vim +/counter_sysfs_add +850 drivers/counter/counter-sysfs.c
849
> 850 int counter_sysfs_add(struct counter_device *const counter)
851 {
852 int err;
853
854 /* Initialize Synapse names list */
855 INIT_LIST_HEAD(&counter->dynamic_names_list);
856
857 /* Prepare device attributes */
858 err = counter_groups_list_prepare(counter);
859 if (err)
860 goto err_free_names;
861
862 /* Organize device attributes to groups and match to device */
863 err = counter_groups_prepare(counter);
864 if (err)
865 goto err_free_groups_list;
866
867 return 0;
868
869 err_free_groups_list:
870 counter_groups_list_free(counter);
871 err_free_names:
872 counter_dynamic_names_free(&counter->dynamic_names_list);
873 return err;
874 }
875
> 876 void counter_sysfs_free(struct counter_device *const counter)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38774 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/4] counter: Internalize sysfs interface code
Date: Wed, 20 May 2020 21:10:57 +0800 [thread overview]
Message-ID: <202005202102.sde2NJjF%lkp@intel.com> (raw)
In-Reply-To: <733a915d9334c06bbe51928fb0f75d262d39bb02.1589654470.git.vilhelm.gray@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3360 bytes --]
Hi William,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.7-rc6 next-20200519]
[cannot apply to stm32/stm32-next linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20200517-032530
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 12bf0b632ed090358cbf03e323e5342212d0b2e4
config: arm64-randconfig-r026-20200519 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/counter/counter-sysfs.c:850:5: warning: no previous prototype for function 'counter_sysfs_add' [-Wmissing-prototypes]
int counter_sysfs_add(struct counter_device *const counter)
^
drivers/counter/counter-sysfs.c:850:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int counter_sysfs_add(struct counter_device *const counter)
^
static
>> drivers/counter/counter-sysfs.c:876:6: warning: no previous prototype for function 'counter_sysfs_free' [-Wmissing-prototypes]
void counter_sysfs_free(struct counter_device *const counter)
^
drivers/counter/counter-sysfs.c:876:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void counter_sysfs_free(struct counter_device *const counter)
^
static
2 warnings generated.
vim +/counter_sysfs_add +850 drivers/counter/counter-sysfs.c
849
> 850 int counter_sysfs_add(struct counter_device *const counter)
851 {
852 int err;
853
854 /* Initialize Synapse names list */
855 INIT_LIST_HEAD(&counter->dynamic_names_list);
856
857 /* Prepare device attributes */
858 err = counter_groups_list_prepare(counter);
859 if (err)
860 goto err_free_names;
861
862 /* Organize device attributes to groups and match to device */
863 err = counter_groups_prepare(counter);
864 if (err)
865 goto err_free_groups_list;
866
867 return 0;
868
869 err_free_groups_list:
870 counter_groups_list_free(counter);
871 err_free_names:
872 counter_dynamic_names_free(&counter->dynamic_names_list);
873 return err;
874 }
875
> 876 void counter_sysfs_free(struct counter_device *const counter)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38774 bytes --]
next prev parent reply other threads:[~2020-05-20 13:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 19:19 [PATCH v2 0/4] Introduce the Counter character device interface William Breathitt Gray
2020-05-16 19:19 ` William Breathitt Gray
2020-05-16 19:19 ` [PATCH v2 1/4] counter: Internalize sysfs interface code William Breathitt Gray
2020-05-20 13:10 ` kbuild test robot [this message]
2020-05-20 13:10 ` kbuild test robot
2020-05-20 13:10 ` kbuild test robot
2020-05-24 16:08 ` Jonathan Cameron
2020-05-16 19:20 ` [PATCH v2 2/4] docs: counter: Update to reflect sysfs internalization William Breathitt Gray
2020-05-16 19:20 ` William Breathitt Gray
2020-05-24 16:12 ` Jonathan Cameron
2020-05-24 16:12 ` Jonathan Cameron
2020-05-16 19:20 ` [PATCH v2 3/4] counter: Add character device interface William Breathitt Gray
2020-05-16 19:20 ` William Breathitt Gray
2020-05-20 15:07 ` kbuild test robot
2020-05-20 15:07 ` kbuild test robot
2020-05-20 15:07 ` kbuild test robot
2020-05-16 19:20 ` [PATCH v2 4/4] docs: counter: Document " William Breathitt Gray
2020-05-16 19:20 ` William Breathitt Gray
2020-05-24 16:19 ` Jonathan Cameron
2020-05-24 16:19 ` Jonathan Cameron
2020-05-29 13:26 ` Pavel Machek
2020-05-29 13:26 ` Pavel Machek
2020-05-31 13:31 ` William Breathitt Gray
2020-05-31 13:31 ` William Breathitt Gray
2020-05-24 16:25 ` [PATCH v2 0/4] Introduce the Counter " Jonathan Cameron
2020-05-24 16:25 ` Jonathan Cameron
2020-05-24 17:54 ` William Breathitt Gray
2020-05-24 17:54 ` William Breathitt Gray
2020-05-31 15:18 ` Jonathan Cameron
2020-05-31 15:18 ` Jonathan Cameron
2020-05-31 17:14 ` William Breathitt Gray
2020-05-31 17:14 ` William Breathitt Gray
2020-06-01 10:31 ` Jonathan Cameron
2020-06-01 10:31 ` Jonathan Cameron
2020-06-02 15:18 ` David Lechner
2020-06-02 15:18 ` David Lechner
2020-06-02 15:46 ` William Breathitt Gray
2020-06-02 15:46 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005202102.sde2NJjF%lkp@intel.com \
--to=lkp@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=clang-built-linux@googlegroups.com \
--cc=david@lechnology.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=kamel.bouhara@bootlin.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.