* [PATCH] clk: qcom: gcc: Fix parent for gpll0_out_even
@ 2020-05-21 5:27 Vinod Koul
2020-05-21 5:31 ` Bjorn Andersson
2020-05-27 0:15 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Vinod Koul @ 2020-05-21 5:27 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Andy Gross,
Deepak Katragadda, Taniya Das, Jonathan Marek, linux-clk,
linux-kernel
Documentation says that gpll0 is parent of gpll0_out_even, somehow
driver coded that as bi_tcxo, so fix it
Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver for SM8150")
Reported-by: Jonathan Marek <jonathan@marek.ca>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/clk/qcom/gcc-sm8150.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c
index 2bc08e7125bf..72524cf11048 100644
--- a/drivers/clk/qcom/gcc-sm8150.c
+++ b/drivers/clk/qcom/gcc-sm8150.c
@@ -76,8 +76,7 @@ static struct clk_alpha_pll_postdiv gpll0_out_even = {
.clkr.hw.init = &(struct clk_init_data){
.name = "gpll0_out_even",
.parent_data = &(const struct clk_parent_data){
- .fw_name = "bi_tcxo",
- .name = "bi_tcxo",
+ .hw = &gpll0.clkr.hw,
},
.num_parents = 1,
.ops = &clk_trion_pll_postdiv_ops,
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: gcc: Fix parent for gpll0_out_even
2020-05-21 5:27 [PATCH] clk: qcom: gcc: Fix parent for gpll0_out_even Vinod Koul
@ 2020-05-21 5:31 ` Bjorn Andersson
2020-05-27 0:15 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-05-21 5:31 UTC (permalink / raw)
To: Vinod Koul
Cc: Michael Turquette, Stephen Boyd, linux-arm-msm, Andy Gross,
Deepak Katragadda, Taniya Das, Jonathan Marek, linux-clk,
linux-kernel
On Wed 20 May 22:27 PDT 2020, Vinod Koul wrote:
> Documentation says that gpll0 is parent of gpll0_out_even, somehow
> driver coded that as bi_tcxo, so fix it
>
> Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver for SM8150")
> Reported-by: Jonathan Marek <jonathan@marek.ca>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/clk/qcom/gcc-sm8150.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c
> index 2bc08e7125bf..72524cf11048 100644
> --- a/drivers/clk/qcom/gcc-sm8150.c
> +++ b/drivers/clk/qcom/gcc-sm8150.c
> @@ -76,8 +76,7 @@ static struct clk_alpha_pll_postdiv gpll0_out_even = {
> .clkr.hw.init = &(struct clk_init_data){
> .name = "gpll0_out_even",
> .parent_data = &(const struct clk_parent_data){
> - .fw_name = "bi_tcxo",
> - .name = "bi_tcxo",
> + .hw = &gpll0.clkr.hw,
> },
> .num_parents = 1,
> .ops = &clk_trion_pll_postdiv_ops,
> --
> 2.25.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: gcc: Fix parent for gpll0_out_even
2020-05-21 5:27 [PATCH] clk: qcom: gcc: Fix parent for gpll0_out_even Vinod Koul
2020-05-21 5:31 ` Bjorn Andersson
@ 2020-05-27 0:15 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-05-27 0:15 UTC (permalink / raw)
To: Michael Turquette, Vinod Koul
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Andy Gross,
Deepak Katragadda, Taniya Das, Jonathan Marek, linux-clk,
linux-kernel
Quoting Vinod Koul (2020-05-20 22:27:28)
> Documentation says that gpll0 is parent of gpll0_out_even, somehow
> driver coded that as bi_tcxo, so fix it
>
> Fixes: 2a1d7eb854bb ("clk: qcom: gcc: Add global clock controller driver for SM8150")
> Reported-by: Jonathan Marek <jonathan@marek.ca>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-27 0:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-21 5:27 [PATCH] clk: qcom: gcc: Fix parent for gpll0_out_even Vinod Koul
2020-05-21 5:31 ` Bjorn Andersson
2020-05-27 0:15 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.