All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>,
	Ido Schimmel <idosch@idosch.org>
Cc: Jiri Pirko <jiri@resnulli.us>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	petrm@mellanox.com, amitc@mellanox.com
Subject: Re: devlink interface for asynchronous event/messages from firmware?
Date: Thu, 21 May 2020 14:51:13 -0700	[thread overview]
Message-ID: <20200521145113.21f772bf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <239b02dc-7a02-dcc3-a67c-85947f92f374@intel.com>

On Thu, 21 May 2020 13:59:32 -0700 Jacob Keller wrote:
> >> So the ice firmware can optionally send diagnostic debug messages via
> >> its control queue. The current solutions we've used internally
> >> essentially hex-dump the binary contents to the kernel log, and then
> >> these get scraped and converted into a useful format for human consumption.
> >>
> >> I'm not 100% of the format, but I know it's based on a decoding file
> >> that is specific to a given firmware image, and thus attempting to tie
> >> this into the driver is problematic.  
> > 
> > You explained how it works, but not why it's needed :)  
> 
> Well, the reason we want it is to be able to read the debug/diagnostics
> data in order to debug issues that might be related to firmware or
> software mis-use of firmware interfaces.
> 
> By having it be a separate interface rather than trying to scrape from
> the kernel message buffer, it becomes something we can have as a
> possibility for debugging in the field.

For pure debug/tracing perhaps trace_devlink_hwerr() is the right fit?

Right Ido?

  reply	other threads:[~2020-05-21 21:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21  0:03 devlink interface for asynchronous event/messages from firmware? Jacob Keller
2020-05-21  0:16 ` Jakub Kicinski
2020-05-21 20:22   ` Jacob Keller
2020-05-21 20:52     ` Ido Schimmel
2020-05-21 20:59       ` Jacob Keller
2020-05-21 21:51         ` Jakub Kicinski [this message]
2020-05-21 22:09           ` Jacob Keller
2020-05-21 22:32             ` Ido Schimmel
2020-05-22 11:00           ` Jiri Pirko
2020-05-22 17:46             ` Jakub Kicinski
2020-05-26 21:13               ` Jacob Keller
2020-05-26 21:00             ` Jacob Keller
2020-05-22 11:03         ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200521145113.21f772bf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=amitc@mellanox.com \
    --cc=idosch@idosch.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.