* [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev
@ 2020-05-20 19:45 Ben Hutchings
2020-05-21 5:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2020-05-20 19:45 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sasha Levin; +Cc: stable
Please pick this fix for all stable branches:
commit 1413ef638abae4ab5621901cf4d8ef08a4a48ba6
Author: Kevin Hao <haokexin@gmail.com>
Date: Fri Oct 11 23:00:14 2019 +0800
i2c: dev: Fix the race between the release of i2c_dev and cdev
I don't know whether it will apply cleanly to all of them; I can deal
with those where it doesn't.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev
2020-05-20 19:45 [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev Ben Hutchings
@ 2020-05-21 5:50 ` Greg Kroah-Hartman
2020-05-21 20:58 ` Ben Hutchings
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-05-21 5:50 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Sasha Levin, stable
On Wed, May 20, 2020 at 08:45:15PM +0100, Ben Hutchings wrote:
> Please pick this fix for all stable branches:
>
> commit 1413ef638abae4ab5621901cf4d8ef08a4a48ba6
> Author: Kevin Hao <haokexin@gmail.com>
> Date: Fri Oct 11 23:00:14 2019 +0800
>
> i2c: dev: Fix the race between the release of i2c_dev and cdev
>
> I don't know whether it will apply cleanly to all of them; I can deal
> with those where it doesn't.
I applied it to 4.14, 4.19, 5.4, and 5.6. It does apply to 4.9 but as
the patch it depends on is not there, I don't think it will help.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev
2020-05-21 5:50 ` Greg Kroah-Hartman
@ 2020-05-21 20:58 ` Ben Hutchings
2020-05-21 23:33 ` Sasha Levin
2020-05-22 11:34 ` Greg Kroah-Hartman
0 siblings, 2 replies; 5+ messages in thread
From: Ben Hutchings @ 2020-05-21 20:58 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Sasha Levin, stable
On Thu, 2020-05-21 at 07:50 +0200, Greg Kroah-Hartman wrote:
> On Wed, May 20, 2020 at 08:45:15PM +0100, Ben Hutchings wrote:
> > Please pick this fix for all stable branches:
> >
> > commit 1413ef638abae4ab5621901cf4d8ef08a4a48ba6
> > Author: Kevin Hao <haokexin@gmail.com>
> > Date: Fri Oct 11 23:00:14 2019 +0800
> >
> > i2c: dev: Fix the race between the release of i2c_dev and cdev
> >
> > I don't know whether it will apply cleanly to all of them; I can deal
> > with those where it doesn't.
>
> I applied it to 4.14, 4.19, 5.4, and 5.6. It does apply to 4.9 but as
> the patch it depends on is not there, I don't think it will help.
It was included in 4.9.224, so both this and the similar watchdog fix
should be applicable for 4.9.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev
2020-05-21 20:58 ` Ben Hutchings
@ 2020-05-21 23:33 ` Sasha Levin
2020-05-22 11:34 ` Greg Kroah-Hartman
1 sibling, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2020-05-21 23:33 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Greg Kroah-Hartman, Sasha Levin, stable
On Thu, May 21, 2020 at 09:58:57PM +0100, Ben Hutchings wrote:
>On Thu, 2020-05-21 at 07:50 +0200, Greg Kroah-Hartman wrote:
>> On Wed, May 20, 2020 at 08:45:15PM +0100, Ben Hutchings wrote:
>> > Please pick this fix for all stable branches:
>> >
>> > commit 1413ef638abae4ab5621901cf4d8ef08a4a48ba6
>> > Author: Kevin Hao <haokexin@gmail.com>
>> > Date: Fri Oct 11 23:00:14 2019 +0800
>> >
>> > i2c: dev: Fix the race between the release of i2c_dev and cdev
>> >
>> > I don't know whether it will apply cleanly to all of them; I can deal
>> > with those where it doesn't.
>>
>> I applied it to 4.14, 4.19, 5.4, and 5.6. It does apply to 4.9 but as
>> the patch it depends on is not there, I don't think it will help.
>
>It was included in 4.9.224, so both this and the similar watchdog fix
>should be applicable for 4.9.
I took it for 4.9, haven't noticed any issues.
I don't think it applies to 4.4 though as we don't have:
d6760b14d4a1 ("i2c: dev: switch from register_chrdev to cdev API")
I did notice 3 other commits which I've taken in:
5136ed4fcb05 ("i2c-dev: don't get i2c adapter via i2c_dev")
e6be18f6d62c ("i2c: dev: use after free in detach")
72a71f869c95 ("i2c: dev: don't start function name with 'return'")
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev
2020-05-21 20:58 ` Ben Hutchings
2020-05-21 23:33 ` Sasha Levin
@ 2020-05-22 11:34 ` Greg Kroah-Hartman
1 sibling, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-05-22 11:34 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Sasha Levin, stable
On Thu, May 21, 2020 at 09:58:57PM +0100, Ben Hutchings wrote:
> On Thu, 2020-05-21 at 07:50 +0200, Greg Kroah-Hartman wrote:
> > On Wed, May 20, 2020 at 08:45:15PM +0100, Ben Hutchings wrote:
> > > Please pick this fix for all stable branches:
> > >
> > > commit 1413ef638abae4ab5621901cf4d8ef08a4a48ba6
> > > Author: Kevin Hao <haokexin@gmail.com>
> > > Date: Fri Oct 11 23:00:14 2019 +0800
> > >
> > > i2c: dev: Fix the race between the release of i2c_dev and cdev
> > >
> > > I don't know whether it will apply cleanly to all of them; I can deal
> > > with those where it doesn't.
> >
> > I applied it to 4.14, 4.19, 5.4, and 5.6. It does apply to 4.9 but as
> > the patch it depends on is not there, I don't think it will help.
>
> It was included in 4.9.224, so both this and the similar watchdog fix
> should be applicable for 4.9.
My fault, I hadn't updated my scripts, all is good here, sorry for the
noise.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-22 11:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 19:45 [stable] i2c: dev: Fix the race between the release of i2c_dev and cdev Ben Hutchings
2020-05-21 5:50 ` Greg Kroah-Hartman
2020-05-21 20:58 ` Ben Hutchings
2020-05-21 23:33 ` Sasha Levin
2020-05-22 11:34 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.