From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Rahul Tanwar <rahul.tanwar@linux.intel.com>,
thierry.reding@gmail.com, p.zabel@pengutronix.de,
linux-pwm@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
songjun.Wu@intel.com, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com
Subject: Re: [PATCH v1 2/2] Add PWM driver for LGM
Date: Fri, 22 May 2020 12:18:24 +0300 [thread overview]
Message-ID: <20200522091824.GR1634618@smile.fi.intel.com> (raw)
In-Reply-To: <20200522085613.ktb2ruw2virj337v@pengutronix.de>
On Fri, May 22, 2020 at 10:56:13AM +0200, Uwe Kleine-König wrote:
> On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote:
> > + io_base = devm_platform_ioremap_resource(pdev, 0);
> > + if (IS_ERR(io_base))
>
> error message here?
platform core provides it. No need to duplicate (esp. taking into consideration
that it can issue IIRC three different error messages depending on actual error).
>
> > + return PTR_ERR(io_base);
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Rahul Tanwar
<rahul.tanwar-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
songjun.Wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
cheol.yong.kim-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
qi-ming.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v1 2/2] Add PWM driver for LGM
Date: Fri, 22 May 2020 12:18:24 +0300 [thread overview]
Message-ID: <20200522091824.GR1634618@smile.fi.intel.com> (raw)
In-Reply-To: <20200522085613.ktb2ruw2virj337v-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Fri, May 22, 2020 at 10:56:13AM +0200, Uwe Kleine-König wrote:
> On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote:
> > + io_base = devm_platform_ioremap_resource(pdev, 0);
> > + if (IS_ERR(io_base))
>
> error message here?
platform core provides it. No need to duplicate (esp. taking into consideration
that it can issue IIRC three different error messages depending on actual error).
>
> > + return PTR_ERR(io_base);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-22 9:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 7:41 [PATCH v1 0/2] pwm: intel: Add PWM driver for new SoC Rahul Tanwar
2020-05-22 7:41 ` Rahul Tanwar
2020-05-22 7:41 ` [PATCH v1 1/2] Add YAML schema for a new PWM driver Rahul Tanwar
2020-05-28 23:31 ` Rob Herring
2020-05-28 23:31 ` Rob Herring
2020-05-22 7:41 ` [PATCH v1 2/2] Add PWM driver for LGM Rahul Tanwar
2020-05-22 8:56 ` Uwe Kleine-König
2020-05-22 9:18 ` Andy Shevchenko [this message]
2020-05-22 9:18 ` Andy Shevchenko
2020-05-22 9:32 ` Uwe Kleine-König
2020-05-27 6:28 ` Tanwar, Rahul
2020-05-27 6:28 ` Tanwar, Rahul
2020-05-27 9:15 ` Andy Shevchenko
2020-05-28 5:45 ` Tanwar, Rahul
2020-05-28 5:45 ` Tanwar, Rahul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522091824.GR1634618@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qi-ming.wu@intel.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=songjun.Wu@intel.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.