[android-common:android-trusty-4.19 6/11] include/linux/module.h:133:6: warning: 'init_module' specifies less restrictive attribute than its target 'trusty_test_driver_init': 'cold'

[android-common:android-trusty-4.19 6/11] include/linux/module.h:133:6: warning: 'init_module' specifies less restrictive attribute than its target 'trusty_test_driver_init': 'cold'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 5628 bytes --]

Hi Arve,

FYI, the error/warning still remains.

tree:   https://android.googlesource.com/kernel/common android-trusty-4.19
head:   2735339966ed1b8c4fa175baefce6024283763a3
commit: 3b73c0e90d449bbb4c49297238c24badc3ed7aa5 [6/11] trusty: Add stdcalltest
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 3b73c0e90d449bbb4c49297238c24badc3ed7aa5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from drivers/trusty/trusty-test.c:15:
>> include/linux/module.h:133:6: warning: 'init_module' specifies less restrictive attribute than its target 'trusty_test_driver_init': 'cold' [-Wmissing-attributes]
133 |  int init_module(void) __attribute__((alias(#initfn)));
|      ^~~~~~~~~~~
include/linux/device.h:1604:1: note: in expansion of macro 'module_init'
1604 | module_init(__driver##_init);          | ^~~~~~~~~~~
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
228 |  module_driver(__platform_driver, platform_driver_register,          |  ^~~~~~~~~~~~~
>> drivers/trusty/trusty-test.c:449:1: note: in expansion of macro 'module_platform_driver'
449 | module_platform_driver(trusty_test_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/platform_device.h:14,
from drivers/trusty/trusty-test.c:8:
drivers/trusty/trusty-test.c:449:24: note: 'init_module' target declared here
449 | module_platform_driver(trusty_test_driver);
|                        ^~~~~~~~~~~~~~~~~~
include/linux/device.h:1600:19: note: in definition of macro 'module_driver'
1600 | static int __init __driver##_init(void)          |                   ^~~~~~~~
>> drivers/trusty/trusty-test.c:449:1: note: in expansion of macro 'module_platform_driver'
449 | module_platform_driver(trusty_test_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/trusty/trusty-test.c:15:
>> include/linux/module.h:139:7: warning: 'cleanup_module' specifies less restrictive attribute than its target 'trusty_test_driver_exit': 'cold' [-Wmissing-attributes]
139 |  void cleanup_module(void) __attribute__((alias(#exitfn)));
|       ^~~~~~~~~~~~~~
include/linux/device.h:1609:1: note: in expansion of macro 'module_exit'
1609 | module_exit(__driver##_exit);
| ^~~~~~~~~~~
include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
228 |  module_driver(__platform_driver, platform_driver_register,          |  ^~~~~~~~~~~~~
>> drivers/trusty/trusty-test.c:449:1: note: in expansion of macro 'module_platform_driver'
449 | module_platform_driver(trusty_test_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/platform_device.h:14,
from drivers/trusty/trusty-test.c:8:
drivers/trusty/trusty-test.c:449:24: note: 'cleanup_module' target declared here
449 | module_platform_driver(trusty_test_driver);
|                        ^~~~~~~~~~~~~~~~~~
include/linux/device.h:1605:20: note: in definition of macro 'module_driver'
1605 | static void __exit __driver##_exit(void)          |                    ^~~~~~~~
>> drivers/trusty/trusty-test.c:449:1: note: in expansion of macro 'module_platform_driver'
449 | module_platform_driver(trusty_test_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/trusty/trusty-test.c: In function 'trusty_test_run':
include/linux/device.h:1442:2: warning: 'obj' may be used uninitialized in this function [-Wmaybe-uninitialized]
1442 |  _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
|  ^~~~~~~~
drivers/trusty/trusty-test.c:287:32: note: 'obj' was declared here
287 |  struct trusty_test_shmem_obj *obj;
|                                ^~~

vim +133 include/linux/module.h

0fd972a7d91d6e Paul Gortmaker 2015-05-01  128  
0fd972a7d91d6e Paul Gortmaker 2015-05-01  129  /* Each module must use one module_init(). */
0fd972a7d91d6e Paul Gortmaker 2015-05-01  130  #define module_init(initfn)					\
1f318a8bafcfba Arnd Bergmann  2017-02-01  131  	static inline initcall_t __maybe_unused __inittest(void)		\
0fd972a7d91d6e Paul Gortmaker 2015-05-01  132  	{ return initfn; }					\
0fd972a7d91d6e Paul Gortmaker 2015-05-01 @133  	int init_module(void) __attribute__((alias(#initfn)));
0fd972a7d91d6e Paul Gortmaker 2015-05-01  134  
0fd972a7d91d6e Paul Gortmaker 2015-05-01  135  /* This is only required if you want to be unloadable. */
0fd972a7d91d6e Paul Gortmaker 2015-05-01  136  #define module_exit(exitfn)					\
1f318a8bafcfba Arnd Bergmann  2017-02-01  137  	static inline exitcall_t __maybe_unused __exittest(void)		\
0fd972a7d91d6e Paul Gortmaker 2015-05-01  138  	{ return exitfn; }					\
0fd972a7d91d6e Paul Gortmaker 2015-05-01 @139  	void cleanup_module(void) __attribute__((alias(#exitfn)));
0fd972a7d91d6e Paul Gortmaker 2015-05-01  140  

:::::: The code at line 133 was first introduced by commit
:::::: 0fd972a7d91d6e15393c449492a04d94c0b89351 module: relocate module_init from init.h to module.h

:::::: TO: Paul Gortmaker <paul.gortmaker@windriver.com>
:::::: CC: Paul Gortmaker <paul.gortmaker@windriver.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60643 bytes --]