From: Rob Herring <robh@kernel.org> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shawn Lin <shawn.lin@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org Subject: [PATCH 13/15] PCI: rockchip: Use pci_host_probe() to register host Date: Fri, 22 May 2020 17:48:30 -0600 [thread overview] Message-ID: <20200522234832.954484-14-robh@kernel.org> (raw) In-Reply-To: <20200522234832.954484-1-robh@kernel.org> The rockchip host driver does the same host registration and bus scanning calls as pci_host_probe, so let's use it instead. Cc: Shawn Lin <shawn.lin@rock-chips.com> Cc: Heiko Stuebner <heiko@sntech.de> Cc: linux-rockchip@lists.infradead.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/pci/controller/pcie-rockchip-host.c | 18 ++++-------------- drivers/pci/controller/pcie-rockchip.h | 1 - 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/controller/pcie-rockchip-host.c index 94af6f5828a3..6a3c8442258b 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -949,7 +949,6 @@ static int rockchip_pcie_probe(struct platform_device *pdev) { struct rockchip_pcie *rockchip; struct device *dev = &pdev->dev; - struct pci_bus *bus, *child; struct pci_host_bridge *bridge; struct resource *bus_res; int err; @@ -1015,20 +1014,10 @@ static int rockchip_pcie_probe(struct platform_device *pdev) bridge->map_irq = of_irq_parse_and_map_pci; bridge->swizzle_irq = pci_common_swizzle; - err = pci_scan_root_bus_bridge(bridge); + err = pci_host_probe(bridge); if (err < 0) goto err_remove_irq_domain; - bus = bridge->bus; - - rockchip->root_bus = bus; - - pci_bus_size_bridges(bus); - pci_bus_assign_resources(bus); - list_for_each_entry(child, &bus->children, node) - pcie_bus_configure_settings(child); - - pci_bus_add_devices(bus); return 0; err_remove_irq_domain: @@ -1051,9 +1040,10 @@ static int rockchip_pcie_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct rockchip_pcie *rockchip = dev_get_drvdata(dev); + struct pci_host_bridge *bridge = pci_host_bridge_from_priv(rockchip); - pci_stop_root_bus(rockchip->root_bus); - pci_remove_root_bus(rockchip->root_bus); + pci_stop_root_bus(bridge->bus); + pci_remove_root_bus(bridge->bus); irq_domain_remove(rockchip->irq_domain); rockchip_pcie_deinit_phys(rockchip); diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controller/pcie-rockchip.h index d90dfb354573..4012543bafbe 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -303,7 +303,6 @@ struct rockchip_pcie { struct device *dev; struct irq_domain *irq_domain; int offset; - struct pci_bus *root_bus; void __iomem *msg_region; phys_addr_t msg_bus_addr; bool is_rc; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Heiko Stuebner <heiko@sntech.de>, linux-pci@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>, linux-rockchip@lists.infradead.org, Bjorn Helgaas <bhelgaas@google.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 13/15] PCI: rockchip: Use pci_host_probe() to register host Date: Fri, 22 May 2020 17:48:30 -0600 [thread overview] Message-ID: <20200522234832.954484-14-robh@kernel.org> (raw) In-Reply-To: <20200522234832.954484-1-robh@kernel.org> The rockchip host driver does the same host registration and bus scanning calls as pci_host_probe, so let's use it instead. Cc: Shawn Lin <shawn.lin@rock-chips.com> Cc: Heiko Stuebner <heiko@sntech.de> Cc: linux-rockchip@lists.infradead.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/pci/controller/pcie-rockchip-host.c | 18 ++++-------------- drivers/pci/controller/pcie-rockchip.h | 1 - 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/controller/pcie-rockchip-host.c index 94af6f5828a3..6a3c8442258b 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -949,7 +949,6 @@ static int rockchip_pcie_probe(struct platform_device *pdev) { struct rockchip_pcie *rockchip; struct device *dev = &pdev->dev; - struct pci_bus *bus, *child; struct pci_host_bridge *bridge; struct resource *bus_res; int err; @@ -1015,20 +1014,10 @@ static int rockchip_pcie_probe(struct platform_device *pdev) bridge->map_irq = of_irq_parse_and_map_pci; bridge->swizzle_irq = pci_common_swizzle; - err = pci_scan_root_bus_bridge(bridge); + err = pci_host_probe(bridge); if (err < 0) goto err_remove_irq_domain; - bus = bridge->bus; - - rockchip->root_bus = bus; - - pci_bus_size_bridges(bus); - pci_bus_assign_resources(bus); - list_for_each_entry(child, &bus->children, node) - pcie_bus_configure_settings(child); - - pci_bus_add_devices(bus); return 0; err_remove_irq_domain: @@ -1051,9 +1040,10 @@ static int rockchip_pcie_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct rockchip_pcie *rockchip = dev_get_drvdata(dev); + struct pci_host_bridge *bridge = pci_host_bridge_from_priv(rockchip); - pci_stop_root_bus(rockchip->root_bus); - pci_remove_root_bus(rockchip->root_bus); + pci_stop_root_bus(bridge->bus); + pci_remove_root_bus(bridge->bus); irq_domain_remove(rockchip->irq_domain); rockchip_pcie_deinit_phys(rockchip); diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controller/pcie-rockchip.h index d90dfb354573..4012543bafbe 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -303,7 +303,6 @@ struct rockchip_pcie { struct device *dev; struct irq_domain *irq_domain; int offset; - struct pci_bus *root_bus; void __iomem *msg_region; phys_addr_t msg_bus_addr; bool is_rc; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-22 23:48 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-22 23:48 [PATCH 00/15] PCI controller probe cleanups Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-22 23:48 ` [PATCH 01/15] PCI: cadence: Use struct pci_host_bridge.windows list directly Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-22 23:48 ` [PATCH 02/15] PCI: mvebu: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-22 23:48 ` [PATCH 03/15] PCI: host-common: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-22 23:48 ` [PATCH 04/15] PCI: brcmstb: Use pci_host_probe() to register host Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-06-18 10:54 ` Nicolas Saenz Julienne 2020-06-18 10:54 ` Nicolas Saenz Julienne 2020-05-22 23:48 ` [PATCH 05/15] PCI: mobiveil: " Rob Herring 2020-05-22 23:48 ` Rob Herring [not found] ` <20200522234832.954484-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2020-05-22 23:48 ` [PATCH 06/15] PCI: tegra: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-22 23:48 ` [PATCH 07/15] PCI: v3: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-25 11:38 ` Linus Walleij 2020-05-25 11:38 ` Linus Walleij 2020-05-22 23:48 ` [PATCH 08/15] PCI: versatile: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-22 23:48 ` [PATCH 09/15] PCI: xgene: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-22 23:48 ` [PATCH 10/15] PCI: altera: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-06-02 1:02 ` Tan, Ley Foon 2020-06-02 1:02 ` Tan, Ley Foon 2020-05-22 23:48 ` [PATCH 11/15] PCI: iproc: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-28 17:53 ` Scott Branden 2020-05-28 17:53 ` Scott Branden 2020-05-22 23:48 ` [PATCH 12/15] PCI: rcar: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-25 8:31 ` Geert Uytterhoeven 2020-05-25 8:31 ` Geert Uytterhoeven 2020-05-22 23:48 ` Rob Herring [this message] 2020-05-22 23:48 ` [PATCH 13/15] PCI: rockchip: " Rob Herring 2020-05-22 23:48 ` [PATCH 14/15] PCI: xilinx-nwl: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-25 6:44 ` Michal Simek 2020-05-25 6:44 ` Michal Simek 2020-05-22 23:48 ` [PATCH 15/15] PCI: xilinx: " Rob Herring 2020-05-22 23:48 ` Rob Herring 2020-05-25 6:44 ` Michal Simek 2020-05-25 6:44 ` Michal Simek 2020-07-06 9:04 ` [PATCH 00/15] PCI controller probe cleanups Lorenzo Pieralisi 2020-07-06 9:04 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200522234832.954484-14-robh@kernel.org \ --to=robh@kernel.org \ --cc=bhelgaas@google.com \ --cc=heiko@sntech.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=shawn.lin@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.