From: kbuild test robot <lkp@intel.com>
To: Anchal Agarwal <anchalag@amazon.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, boris.ostrovsky@oracle.com,
jgross@suse.com, linux-pm@vger.kernel.org, linux-mm@kvack.org,
kamatam@amazon.com, sstabellini@kernel.org,
konrad.wilk@oracle.com, roger.pau@citrix.com, axboe@kernel.dk,
davem@davemloft.net, rjw@rjwysocki.net, len.brown@intel.com,
pavel@ucw.cz, peterz@infradead.org, eduval@amazon.com,
sblbir@amazon.com, xen-devel@lists.xenproject.org,
vkuznets@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dwmw@amazon.co.uk,
benh@kernel.crashing.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation
Date: Sat, 23 May 2020 20:32:16 +0800 [thread overview]
Message-ID: <20200523123216.GC14189@xsang-OptiPlex-9020> (raw)
In-Reply-To: <ad580b4d5b76c18fe2fe409704f25622e01af361.1589926004.git.anchalag@amazon.com>
[-- Attachment #1: Type: text/plain, Size: 6231 bytes --]
Hi Anchal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.7-rc6]
[cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Anchal-Agarwal/Fix-PM-hibernation-in-Xen-guests/20200520-073211
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 03fb3acae4be8a6b680ffedb220a8b6c07260b40
config: x86_64-allmodconfig (attached as .config)
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
# save the attached .config to linux build tree
make C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/block/xen-blkfront.c:2700:0: sparse: sparse: missing terminating " character
drivers/block/xen-blkfront.c:2701:0: sparse: sparse: missing terminating " character
drivers/block/xen-blkfront.c:2700:25: sparse: sparse: Expected ) in function call
drivers/block/xen-blkfront.c:2700:25: sparse: sparse: got The
# https://github.com/0day-ci/linux/commit/1997467d18e784a64ee0fe00875492e9605f6147
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 1997467d18e784a64ee0fe00875492e9605f6147
vim +2700 drivers/block/xen-blkfront.c
9f27ee59503865 Jeremy Fitzhardinge 2007-07-17 2672
1997467d18e784 Munehisa Kamata 2020-05-19 2673 static int blkfront_freeze(struct xenbus_device *dev)
1997467d18e784 Munehisa Kamata 2020-05-19 2674 {
1997467d18e784 Munehisa Kamata 2020-05-19 2675 unsigned int i;
1997467d18e784 Munehisa Kamata 2020-05-19 2676 struct blkfront_info *info = dev_get_drvdata(&dev->dev);
1997467d18e784 Munehisa Kamata 2020-05-19 2677 struct blkfront_ring_info *rinfo;
1997467d18e784 Munehisa Kamata 2020-05-19 2678 /* This would be reasonable timeout as used in xenbus_dev_shutdown() */
1997467d18e784 Munehisa Kamata 2020-05-19 2679 unsigned int timeout = 5 * HZ;
1997467d18e784 Munehisa Kamata 2020-05-19 2680 unsigned long flags;
1997467d18e784 Munehisa Kamata 2020-05-19 2681 int err = 0;
1997467d18e784 Munehisa Kamata 2020-05-19 2682
1997467d18e784 Munehisa Kamata 2020-05-19 2683 info->connected = BLKIF_STATE_FREEZING;
1997467d18e784 Munehisa Kamata 2020-05-19 2684
1997467d18e784 Munehisa Kamata 2020-05-19 2685 blk_mq_freeze_queue(info->rq);
1997467d18e784 Munehisa Kamata 2020-05-19 2686 blk_mq_quiesce_queue(info->rq);
1997467d18e784 Munehisa Kamata 2020-05-19 2687
1997467d18e784 Munehisa Kamata 2020-05-19 2688 for_each_rinfo(info, rinfo, i) {
1997467d18e784 Munehisa Kamata 2020-05-19 2689 /* No more gnttab callback work. */
1997467d18e784 Munehisa Kamata 2020-05-19 2690 gnttab_cancel_free_callback(&rinfo->callback);
1997467d18e784 Munehisa Kamata 2020-05-19 2691 /* Flush gnttab callback work. Must be done with no locks held. */
1997467d18e784 Munehisa Kamata 2020-05-19 2692 flush_work(&rinfo->work);
1997467d18e784 Munehisa Kamata 2020-05-19 2693 }
1997467d18e784 Munehisa Kamata 2020-05-19 2694
1997467d18e784 Munehisa Kamata 2020-05-19 2695 for_each_rinfo(info, rinfo, i) {
1997467d18e784 Munehisa Kamata 2020-05-19 2696 spin_lock_irqsave(&rinfo->ring_lock, flags);
1997467d18e784 Munehisa Kamata 2020-05-19 2697 if (RING_FULL(&rinfo->ring)
1997467d18e784 Munehisa Kamata 2020-05-19 2698 || RING_HAS_UNCONSUMED_RESPONSES(&rinfo->ring)) {
1997467d18e784 Munehisa Kamata 2020-05-19 2699 xenbus_dev_error(dev, err, "Hibernation Failed.
1997467d18e784 Munehisa Kamata 2020-05-19 @2700 The ring is still busy");
1997467d18e784 Munehisa Kamata 2020-05-19 2701 info->connected = BLKIF_STATE_CONNECTED;
1997467d18e784 Munehisa Kamata 2020-05-19 2702 spin_unlock_irqrestore(&rinfo->ring_lock, flags);
1997467d18e784 Munehisa Kamata 2020-05-19 2703 return -EBUSY;
1997467d18e784 Munehisa Kamata 2020-05-19 2704 }
1997467d18e784 Munehisa Kamata 2020-05-19 2705 spin_unlock_irqrestore(&rinfo->ring_lock, flags);
1997467d18e784 Munehisa Kamata 2020-05-19 2706 }
1997467d18e784 Munehisa Kamata 2020-05-19 2707 /* Kick the backend to disconnect */
1997467d18e784 Munehisa Kamata 2020-05-19 2708 xenbus_switch_state(dev, XenbusStateClosing);
1997467d18e784 Munehisa Kamata 2020-05-19 2709
1997467d18e784 Munehisa Kamata 2020-05-19 2710 /*
1997467d18e784 Munehisa Kamata 2020-05-19 2711 * We don't want to move forward before the frontend is diconnected
1997467d18e784 Munehisa Kamata 2020-05-19 2712 * from the backend cleanly.
1997467d18e784 Munehisa Kamata 2020-05-19 2713 */
1997467d18e784 Munehisa Kamata 2020-05-19 2714 timeout = wait_for_completion_timeout(&info->wait_backend_disconnected,
1997467d18e784 Munehisa Kamata 2020-05-19 2715 timeout);
1997467d18e784 Munehisa Kamata 2020-05-19 2716 if (!timeout) {
1997467d18e784 Munehisa Kamata 2020-05-19 2717 err = -EBUSY;
1997467d18e784 Munehisa Kamata 2020-05-19 2718 xenbus_dev_error(dev, err, "Freezing timed out;"
1997467d18e784 Munehisa Kamata 2020-05-19 2719 "the device may become inconsistent state");
1997467d18e784 Munehisa Kamata 2020-05-19 2720 }
1997467d18e784 Munehisa Kamata 2020-05-19 2721
1997467d18e784 Munehisa Kamata 2020-05-19 2722 return err;
1997467d18e784 Munehisa Kamata 2020-05-19 2723 }
1997467d18e784 Munehisa Kamata 2020-05-19 2724
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74002 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation
Date: Sat, 23 May 2020 20:32:16 +0800 [thread overview]
Message-ID: <20200523123216.GC14189@xsang-OptiPlex-9020> (raw)
In-Reply-To: <ad580b4d5b76c18fe2fe409704f25622e01af361.1589926004.git.anchalag@amazon.com>
[-- Attachment #1: Type: text/plain, Size: 6329 bytes --]
Hi Anchal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.7-rc6]
[cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Anchal-Agarwal/Fix-PM-hibernation-in-Xen-guests/20200520-073211
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 03fb3acae4be8a6b680ffedb220a8b6c07260b40
config: x86_64-allmodconfig (attached as .config)
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
# save the attached .config to linux build tree
make C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/block/xen-blkfront.c:2700:0: sparse: sparse: missing terminating " character
drivers/block/xen-blkfront.c:2701:0: sparse: sparse: missing terminating " character
drivers/block/xen-blkfront.c:2700:25: sparse: sparse: Expected ) in function call
drivers/block/xen-blkfront.c:2700:25: sparse: sparse: got The
# https://github.com/0day-ci/linux/commit/1997467d18e784a64ee0fe00875492e9605f6147
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 1997467d18e784a64ee0fe00875492e9605f6147
vim +2700 drivers/block/xen-blkfront.c
9f27ee59503865 Jeremy Fitzhardinge 2007-07-17 2672
1997467d18e784 Munehisa Kamata 2020-05-19 2673 static int blkfront_freeze(struct xenbus_device *dev)
1997467d18e784 Munehisa Kamata 2020-05-19 2674 {
1997467d18e784 Munehisa Kamata 2020-05-19 2675 unsigned int i;
1997467d18e784 Munehisa Kamata 2020-05-19 2676 struct blkfront_info *info = dev_get_drvdata(&dev->dev);
1997467d18e784 Munehisa Kamata 2020-05-19 2677 struct blkfront_ring_info *rinfo;
1997467d18e784 Munehisa Kamata 2020-05-19 2678 /* This would be reasonable timeout as used in xenbus_dev_shutdown() */
1997467d18e784 Munehisa Kamata 2020-05-19 2679 unsigned int timeout = 5 * HZ;
1997467d18e784 Munehisa Kamata 2020-05-19 2680 unsigned long flags;
1997467d18e784 Munehisa Kamata 2020-05-19 2681 int err = 0;
1997467d18e784 Munehisa Kamata 2020-05-19 2682
1997467d18e784 Munehisa Kamata 2020-05-19 2683 info->connected = BLKIF_STATE_FREEZING;
1997467d18e784 Munehisa Kamata 2020-05-19 2684
1997467d18e784 Munehisa Kamata 2020-05-19 2685 blk_mq_freeze_queue(info->rq);
1997467d18e784 Munehisa Kamata 2020-05-19 2686 blk_mq_quiesce_queue(info->rq);
1997467d18e784 Munehisa Kamata 2020-05-19 2687
1997467d18e784 Munehisa Kamata 2020-05-19 2688 for_each_rinfo(info, rinfo, i) {
1997467d18e784 Munehisa Kamata 2020-05-19 2689 /* No more gnttab callback work. */
1997467d18e784 Munehisa Kamata 2020-05-19 2690 gnttab_cancel_free_callback(&rinfo->callback);
1997467d18e784 Munehisa Kamata 2020-05-19 2691 /* Flush gnttab callback work. Must be done with no locks held. */
1997467d18e784 Munehisa Kamata 2020-05-19 2692 flush_work(&rinfo->work);
1997467d18e784 Munehisa Kamata 2020-05-19 2693 }
1997467d18e784 Munehisa Kamata 2020-05-19 2694
1997467d18e784 Munehisa Kamata 2020-05-19 2695 for_each_rinfo(info, rinfo, i) {
1997467d18e784 Munehisa Kamata 2020-05-19 2696 spin_lock_irqsave(&rinfo->ring_lock, flags);
1997467d18e784 Munehisa Kamata 2020-05-19 2697 if (RING_FULL(&rinfo->ring)
1997467d18e784 Munehisa Kamata 2020-05-19 2698 || RING_HAS_UNCONSUMED_RESPONSES(&rinfo->ring)) {
1997467d18e784 Munehisa Kamata 2020-05-19 2699 xenbus_dev_error(dev, err, "Hibernation Failed.
1997467d18e784 Munehisa Kamata 2020-05-19 @2700 The ring is still busy");
1997467d18e784 Munehisa Kamata 2020-05-19 2701 info->connected = BLKIF_STATE_CONNECTED;
1997467d18e784 Munehisa Kamata 2020-05-19 2702 spin_unlock_irqrestore(&rinfo->ring_lock, flags);
1997467d18e784 Munehisa Kamata 2020-05-19 2703 return -EBUSY;
1997467d18e784 Munehisa Kamata 2020-05-19 2704 }
1997467d18e784 Munehisa Kamata 2020-05-19 2705 spin_unlock_irqrestore(&rinfo->ring_lock, flags);
1997467d18e784 Munehisa Kamata 2020-05-19 2706 }
1997467d18e784 Munehisa Kamata 2020-05-19 2707 /* Kick the backend to disconnect */
1997467d18e784 Munehisa Kamata 2020-05-19 2708 xenbus_switch_state(dev, XenbusStateClosing);
1997467d18e784 Munehisa Kamata 2020-05-19 2709
1997467d18e784 Munehisa Kamata 2020-05-19 2710 /*
1997467d18e784 Munehisa Kamata 2020-05-19 2711 * We don't want to move forward before the frontend is diconnected
1997467d18e784 Munehisa Kamata 2020-05-19 2712 * from the backend cleanly.
1997467d18e784 Munehisa Kamata 2020-05-19 2713 */
1997467d18e784 Munehisa Kamata 2020-05-19 2714 timeout = wait_for_completion_timeout(&info->wait_backend_disconnected,
1997467d18e784 Munehisa Kamata 2020-05-19 2715 timeout);
1997467d18e784 Munehisa Kamata 2020-05-19 2716 if (!timeout) {
1997467d18e784 Munehisa Kamata 2020-05-19 2717 err = -EBUSY;
1997467d18e784 Munehisa Kamata 2020-05-19 2718 xenbus_dev_error(dev, err, "Freezing timed out;"
1997467d18e784 Munehisa Kamata 2020-05-19 2719 "the device may become inconsistent state");
1997467d18e784 Munehisa Kamata 2020-05-19 2720 }
1997467d18e784 Munehisa Kamata 2020-05-19 2721
1997467d18e784 Munehisa Kamata 2020-05-19 2722 return err;
1997467d18e784 Munehisa Kamata 2020-05-19 2723 }
1997467d18e784 Munehisa Kamata 2020-05-19 2724
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74002 bytes --]
next prev parent reply other threads:[~2020-05-23 12:24 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 23:24 [PATCH 00/12] Fix PM hibernation in Xen guests Anchal Agarwal
2020-05-19 23:24 ` Anchal Agarwal
2020-05-19 23:24 ` [PATCH 01/12] xen/manage: keep track of the on-going suspend mode Anchal Agarwal
2020-05-19 23:24 ` Anchal Agarwal
2020-05-30 22:26 ` Boris Ostrovsky
2020-06-01 21:00 ` Agarwal, Anchal
2020-06-01 22:39 ` Boris Ostrovsky
2020-05-19 23:25 ` [PATCH 02/12] xenbus: add freeze/thaw/restore callbacks support Anchal Agarwal
2020-05-19 23:25 ` Anchal Agarwal
2020-05-30 22:56 ` Boris Ostrovsky
2020-06-01 23:36 ` Agarwal, Anchal
2020-05-19 23:25 ` [PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume Anchal Agarwal
2020-05-19 23:25 ` Anchal Agarwal
2020-05-30 23:02 ` Boris Ostrovsky
2020-06-04 23:03 ` Anchal Agarwal
2020-06-04 23:03 ` Anchal Agarwal
2020-06-05 21:39 ` Boris Ostrovsky
2020-06-05 21:39 ` Boris Ostrovsky
2020-06-08 16:52 ` Anchal Agarwal
2020-06-08 16:52 ` Anchal Agarwal
2020-06-08 18:49 ` Boris Ostrovsky
2020-06-08 18:49 ` Boris Ostrovsky
2020-05-19 23:26 ` [PATCH 04/12] x86/xen: add system core suspend and resume callbacks Anchal Agarwal
2020-05-19 23:26 ` Anchal Agarwal
2020-05-30 23:10 ` Boris Ostrovsky
2020-06-03 22:40 ` Agarwal, Anchal
2020-06-05 21:24 ` Boris Ostrovsky
2020-06-08 17:09 ` Anchal Agarwal
2020-06-08 17:09 ` Anchal Agarwal
2020-05-19 23:26 ` [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation Anchal Agarwal
2020-05-19 23:34 ` Anchal Agarwal
2020-05-19 23:34 ` Anchal Agarwal
2020-05-19 23:26 ` Anchal Agarwal
2020-05-19 23:29 ` Singh, Balbir
2020-05-19 23:29 ` Singh, Balbir
2020-05-19 23:36 ` Agarwal, Anchal
2020-05-19 23:36 ` Agarwal, Anchal
2020-05-30 23:17 ` Boris Ostrovsky
2020-06-01 20:46 ` Agarwal, Anchal
2020-05-19 23:27 ` [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation Anchal Agarwal
2020-05-19 23:27 ` Anchal Agarwal
2020-05-20 5:00 ` kbuild test robot
2020-05-20 5:00 ` kbuild test robot
2020-05-20 5:00 ` kbuild test robot
2020-05-20 5:07 ` kbuild test robot
2020-05-20 5:07 ` kbuild test robot
2020-05-21 23:48 ` Anchal Agarwal
2020-05-21 23:48 ` Anchal Agarwal
2020-05-22 1:43 ` Singh, Balbir
2020-05-22 1:43 ` Singh, Balbir
2020-05-23 12:32 ` kbuild test robot [this message]
2020-05-23 12:32 ` kbuild test robot
2020-05-28 12:30 ` Roger Pau Monné
2020-05-28 12:30 ` Roger Pau Monné
2020-05-19 23:28 ` [PATCH 07/12] xen-netfront: " Anchal Agarwal
2020-05-19 23:28 ` Anchal Agarwal
2020-05-19 23:28 ` [PATCH 08/12] xen/time: introduce xen_{save,restore}_steal_clock Anchal Agarwal
2020-05-19 23:28 ` Anchal Agarwal
2020-05-30 23:32 ` Boris Ostrovsky
2020-05-19 23:28 ` [PATCH 09/12] x86/xen: save and restore steal clock Anchal Agarwal
2020-05-19 23:28 ` Anchal Agarwal
2020-05-30 23:44 ` Boris Ostrovsky
2020-06-04 18:33 ` Anchal Agarwal
2020-06-04 18:33 ` Anchal Agarwal
2020-05-19 23:29 ` [PATCH 10/12] xen: Introduce wrapper for save/restore sched clock offset Anchal Agarwal
2020-05-19 23:29 ` Anchal Agarwal
2020-05-19 23:29 ` [PATCH 11/12] xen: Update sched clock offset to avoid system instability in hibernation Anchal Agarwal
2020-05-19 23:29 ` Anchal Agarwal
2020-05-19 23:29 ` [PATCH 12/12] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA Anchal Agarwal
2020-05-19 23:29 ` Anchal Agarwal
2020-05-28 17:59 ` [PATCH 00/12] Fix PM hibernation in Xen guests Agarwal, Anchal
2020-05-28 17:59 ` Agarwal, Anchal
2020-05-20 10:09 [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523123216.GC14189@xsang-OptiPlex-9020 \
--to=lkp@intel.com \
--cc=anchalag@amazon.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=eduval@amazon.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kamatam@amazon.com \
--cc=kbuild-all@lists.01.org \
--cc=konrad.wilk@oracle.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=roger.pau@citrix.com \
--cc=sblbir@amazon.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.