All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 4/8] soc: integrator: Use custom soc attribute group instead of device_create_file
Date: Sat, 23 May 2020 18:08:55 +0100	[thread overview]
Message-ID: <20200523170859.50003-5-sudeep.holla@arm.com> (raw)
In-Reply-To: <20200523170859.50003-1-sudeep.holla@arm.com>

Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs
entries") introduced custom soc attribute group in soc_device_attribute
structure but there are no users treewide. While trying to understand
the motivation and tried to use it, it was found lot of existing custom
attributes can moved to use it instead of device_create_file.

Though most of these never remove/cleanup the custom attribute as they
never call soc_device_unregister, using these custom attribute group
eliminate the need for any cleanup as the driver infrastructure will
take care of that.

Let us remove device_create_file and start using the custom attribute
group in soc_device_attribute.

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/soc/versatile/soc-integrator.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/soc/versatile/soc-integrator.c b/drivers/soc/versatile/soc-integrator.c
index 8ba98b3b4e8e..7dcf77ccd31e 100644
--- a/drivers/soc/versatile/soc-integrator.c
+++ b/drivers/soc/versatile/soc-integrator.c
@@ -88,6 +88,16 @@ build_show(struct device *dev, struct device_attribute *attr, char *buf)
 
 static DEVICE_ATTR_RO(build);
 
+static struct attribute *integrator_attrs[] = {
+	&dev_attr_manufacturer.attr,
+	&dev_attr_arch.attr,
+	&dev_attr_fpga.attr,
+	&dev_attr_build.attr,
+	NULL
+};
+
+ATTRIBUTE_GROUPS(integrator);
+
 static int __init integrator_soc_init(void)
 {
 	static struct regmap *syscon_regmap;
@@ -119,6 +129,7 @@ static int __init integrator_soc_init(void)
 	soc_dev_attr->soc_id = "Integrator";
 	soc_dev_attr->machine = "Integrator";
 	soc_dev_attr->family = "Versatile";
+	soc_dev_attr->custom_attr_group = integrator_groups[0];
 	soc_dev = soc_device_register(soc_dev_attr);
 	if (IS_ERR(soc_dev)) {
 		kfree(soc_dev_attr);
@@ -126,11 +137,6 @@ static int __init integrator_soc_init(void)
 	}
 	dev = soc_device_to_device(soc_dev);
 
-	device_create_file(dev, &dev_attr_manufacturer);
-	device_create_file(dev, &dev_attr_arch);
-	device_create_file(dev, &dev_attr_fpga);
-	device_create_file(dev, &dev_attr_build);
-
 	dev_info(dev, "Detected ARM core module:\n");
 	dev_info(dev, "    Manufacturer: %02x\n", (val >> 24));
 	dev_info(dev, "    Architecture: %s\n", integrator_arch_str(val));
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: [PATCH 4/8] soc: integrator: Use custom soc attribute group instead of device_create_file
Date: Sat, 23 May 2020 18:08:55 +0100	[thread overview]
Message-ID: <20200523170859.50003-5-sudeep.holla@arm.com> (raw)
In-Reply-To: <20200523170859.50003-1-sudeep.holla@arm.com>

Commit c31e73121f4c ("base: soc: Handle custom soc information sysfs
entries") introduced custom soc attribute group in soc_device_attribute
structure but there are no users treewide. While trying to understand
the motivation and tried to use it, it was found lot of existing custom
attributes can moved to use it instead of device_create_file.

Though most of these never remove/cleanup the custom attribute as they
never call soc_device_unregister, using these custom attribute group
eliminate the need for any cleanup as the driver infrastructure will
take care of that.

Let us remove device_create_file and start using the custom attribute
group in soc_device_attribute.

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/soc/versatile/soc-integrator.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/soc/versatile/soc-integrator.c b/drivers/soc/versatile/soc-integrator.c
index 8ba98b3b4e8e..7dcf77ccd31e 100644
--- a/drivers/soc/versatile/soc-integrator.c
+++ b/drivers/soc/versatile/soc-integrator.c
@@ -88,6 +88,16 @@ build_show(struct device *dev, struct device_attribute *attr, char *buf)
 
 static DEVICE_ATTR_RO(build);
 
+static struct attribute *integrator_attrs[] = {
+	&dev_attr_manufacturer.attr,
+	&dev_attr_arch.attr,
+	&dev_attr_fpga.attr,
+	&dev_attr_build.attr,
+	NULL
+};
+
+ATTRIBUTE_GROUPS(integrator);
+
 static int __init integrator_soc_init(void)
 {
 	static struct regmap *syscon_regmap;
@@ -119,6 +129,7 @@ static int __init integrator_soc_init(void)
 	soc_dev_attr->soc_id = "Integrator";
 	soc_dev_attr->machine = "Integrator";
 	soc_dev_attr->family = "Versatile";
+	soc_dev_attr->custom_attr_group = integrator_groups[0];
 	soc_dev = soc_device_register(soc_dev_attr);
 	if (IS_ERR(soc_dev)) {
 		kfree(soc_dev_attr);
@@ -126,11 +137,6 @@ static int __init integrator_soc_init(void)
 	}
 	dev = soc_device_to_device(soc_dev);
 
-	device_create_file(dev, &dev_attr_manufacturer);
-	device_create_file(dev, &dev_attr_arch);
-	device_create_file(dev, &dev_attr_fpga);
-	device_create_file(dev, &dev_attr_build);
-
 	dev_info(dev, "Detected ARM core module:\n");
 	dev_info(dev, "    Manufacturer: %02x\n", (val >> 24));
 	dev_info(dev, "    Architecture: %s\n", integrator_arch_str(val));
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-05-23 17:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-23 17:08 [PATCH 0/8] soc: Use custom soc attribute group and DEVICE_ATTR_RO Sudeep Holla
2020-05-23 17:08 ` Sudeep Holla
2020-05-23 17:08 ` [PATCH 1/8] soc: realview: Switch to use DEVICE_ATTR_RO() Sudeep Holla
2020-05-23 17:08   ` Sudeep Holla
2020-05-25 11:44   ` Linus Walleij
2020-05-25 11:44     ` Linus Walleij
2020-05-23 17:08 ` [PATCH 2/8] soc: realview: Use custom soc attribute group instead of device_create_file Sudeep Holla
2020-05-23 17:08   ` Sudeep Holla
2020-05-25 11:45   ` Linus Walleij
2020-05-25 11:45     ` Linus Walleij
2020-05-23 17:08 ` [PATCH 3/8] soc: integrator: Switch to use DEVICE_ATTR_RO() Sudeep Holla
2020-05-23 17:08   ` Sudeep Holla
2020-05-25 11:45   ` Linus Walleij
2020-05-25 11:45     ` Linus Walleij
2020-05-23 17:08 ` Sudeep Holla [this message]
2020-05-23 17:08   ` [PATCH 4/8] soc: integrator: Use custom soc attribute group instead of device_create_file Sudeep Holla
2020-05-25 11:46   ` Linus Walleij
2020-05-25 11:46     ` Linus Walleij
2020-05-23 17:08 ` [PATCH 5/8] soc: ux500: Switch to use DEVICE_ATTR_RO() Sudeep Holla
2020-05-23 17:08   ` Sudeep Holla
2020-05-25 11:46   ` Linus Walleij
2020-05-25 11:46     ` Linus Walleij
2020-05-23 17:08 ` [PATCH 6/8] soc: ux500: Use custom soc attribute group instead of device_create_file Sudeep Holla
2020-05-23 17:08   ` Sudeep Holla
2020-05-25 11:46   ` Linus Walleij
2020-05-25 11:46     ` Linus Walleij
2020-05-23 17:08 ` [PATCH 7/8] ARM: OMAP2: Switch to use DEVICE_ATTR_RO() Sudeep Holla
2020-05-23 17:08   ` Sudeep Holla
2020-05-29 17:47   ` Tony Lindgren
2020-05-29 17:47     ` Tony Lindgren
2020-05-23 17:08 ` [PATCH 8/8] ARM: OMAP2: Use custom soc attribute group instead of device_create_file Sudeep Holla
2020-05-23 17:08   ` Sudeep Holla
2020-05-29 18:01   ` Tony Lindgren
2020-05-29 18:01     ` Tony Lindgren
2020-05-27  9:03 ` [PATCH 0/8] soc: Use custom soc attribute group and DEVICE_ATTR_RO Greg Kroah-Hartman
2020-05-27  9:03   ` Greg Kroah-Hartman
2020-05-27 16:52   ` Sudeep Holla
2020-05-27 16:52     ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200523170859.50003-5-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.