* [PATCH] media: gspca: remove redundant assignment to variable ret
@ 2019-10-11 18:57 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2019-10-11 18:57 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being initialized with a value that
is never read and is being re-assigned a little later on. The
assignment is redundant and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/usb/gspca/stv0680.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/gspca/stv0680.c b/drivers/media/usb/gspca/stv0680.c
index f869eb6065ce..b23988d8c7bc 100644
--- a/drivers/media/usb/gspca/stv0680.c
+++ b/drivers/media/usb/gspca/stv0680.c
@@ -35,7 +35,7 @@ struct sd {
static int stv_sndctrl(struct gspca_dev *gspca_dev, int set, u8 req, u16 val,
int size)
{
- int ret = -1;
+ int ret;
u8 req_type = 0;
unsigned int pipe = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] media: gspca: remove redundant assignment to variable ret
@ 2019-10-11 18:57 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2019-10-11 18:57 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable ret is being initialized with a value that
is never read and is being re-assigned a little later on. The
assignment is redundant and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/usb/gspca/stv0680.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/gspca/stv0680.c b/drivers/media/usb/gspca/stv0680.c
index f869eb6065ce..b23988d8c7bc 100644
--- a/drivers/media/usb/gspca/stv0680.c
+++ b/drivers/media/usb/gspca/stv0680.c
@@ -35,7 +35,7 @@ struct sd {
static int stv_sndctrl(struct gspca_dev *gspca_dev, int set, u8 req, u16 val,
int size)
{
- int ret = -1;
+ int ret;
u8 req_type = 0;
unsigned int pipe = 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] media: gspca: remove redundant assignment to variable status
2019-10-11 18:57 ` Colin King
@ 2020-04-10 14:18 ` Colin King
-1 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2020-04-10 14:18 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable status is being assigned a value that is never read.
The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/usb/gspca/mr97310a.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/gspca/mr97310a.c b/drivers/media/usb/gspca/mr97310a.c
index 502fc2eaffe0..464aa61cd914 100644
--- a/drivers/media/usb/gspca/mr97310a.c
+++ b/drivers/media/usb/gspca/mr97310a.c
@@ -287,7 +287,6 @@ static int zero_the_pointer(struct gspca_dev *gspca_dev)
return err_code;
err_code = cam_get_response16(gspca_dev, 0x21, 0);
- status = data[0];
tries++;
if (err_code < 0)
return err_code;
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] media: gspca: remove redundant assignment to variable status
@ 2020-04-10 14:18 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2020-04-10 14:18 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable status is being assigned a value that is never read.
The assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/usb/gspca/mr97310a.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/gspca/mr97310a.c b/drivers/media/usb/gspca/mr97310a.c
index 502fc2eaffe0..464aa61cd914 100644
--- a/drivers/media/usb/gspca/mr97310a.c
+++ b/drivers/media/usb/gspca/mr97310a.c
@@ -287,7 +287,6 @@ static int zero_the_pointer(struct gspca_dev *gspca_dev)
return err_code;
err_code = cam_get_response16(gspca_dev, 0x21, 0);
- status = data[0];
tries++;
if (err_code < 0)
return err_code;
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] media: gspca: remove redundant assignment to variable status
2020-04-10 14:18 ` Colin King
@ 2020-04-11 23:11 ` Ezequiel Garcia
-1 siblings, 0 replies; 8+ messages in thread
From: Ezequiel Garcia @ 2020-04-11 23:11 UTC (permalink / raw)
To: Colin King
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-media,
kernel-janitors, Linux Kernel Mailing List
On Fri, 10 Apr 2020 at 11:18, Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable status is being assigned a value that is never read.
> The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> drivers/media/usb/gspca/mr97310a.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/gspca/mr97310a.c b/drivers/media/usb/gspca/mr97310a.c
> index 502fc2eaffe0..464aa61cd914 100644
> --- a/drivers/media/usb/gspca/mr97310a.c
> +++ b/drivers/media/usb/gspca/mr97310a.c
> @@ -287,7 +287,6 @@ static int zero_the_pointer(struct gspca_dev *gspca_dev)
> return err_code;
>
> err_code = cam_get_response16(gspca_dev, 0x21, 0);
> - status = data[0];
> tries++;
> if (err_code < 0)
> return err_code;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: gspca: remove redundant assignment to variable status
@ 2020-04-11 23:11 ` Ezequiel Garcia
0 siblings, 0 replies; 8+ messages in thread
From: Ezequiel Garcia @ 2020-04-11 23:11 UTC (permalink / raw)
To: Colin King
Cc: Hans Verkuil, Mauro Carvalho Chehab, linux-media,
kernel-janitors, Linux Kernel Mailing List
On Fri, 10 Apr 2020 at 11:18, Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable status is being assigned a value that is never read.
> The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> drivers/media/usb/gspca/mr97310a.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/usb/gspca/mr97310a.c b/drivers/media/usb/gspca/mr97310a.c
> index 502fc2eaffe0..464aa61cd914 100644
> --- a/drivers/media/usb/gspca/mr97310a.c
> +++ b/drivers/media/usb/gspca/mr97310a.c
> @@ -287,7 +287,6 @@ static int zero_the_pointer(struct gspca_dev *gspca_dev)
> return err_code;
>
> err_code = cam_get_response16(gspca_dev, 0x21, 0);
> - status = data[0];
> tries++;
> if (err_code < 0)
> return err_code;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] media: gspca: remove redundant assignment to variable retval
2019-10-11 18:57 ` Colin King
@ 2020-05-24 16:25 ` Colin King
-1 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2020-05-24 16:25 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, linux-media, linux-kernel
Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
The variable retval is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/usb/gspca/jl2005bcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/gspca/jl2005bcd.c b/drivers/media/usb/gspca/jl2005bcd.c
index 80ce7448b3dd..ca12f33f3e12 100644
--- a/drivers/media/usb/gspca/jl2005bcd.c
+++ b/drivers/media/usb/gspca/jl2005bcd.c
@@ -165,7 +165,7 @@ static int jl2005c_get_firmware_id(struct gspca_dev *gspca_dev)
{
struct sd *sd = (struct sd *)gspca_dev;
int i = 0;
- int retval = -1;
+ int retval;
unsigned char regs_to_read[] = {0x57, 0x02, 0x03, 0x5d, 0x5e, 0x5f};
gspca_dbg(gspca_dev, D_PROBE, "Running jl2005c_get_firmware_id\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] media: gspca: remove redundant assignment to variable retval
@ 2020-05-24 16:25 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2020-05-24 16:25 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, linux-media, linux-kernel
Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
The variable retval is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/usb/gspca/jl2005bcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/gspca/jl2005bcd.c b/drivers/media/usb/gspca/jl2005bcd.c
index 80ce7448b3dd..ca12f33f3e12 100644
--- a/drivers/media/usb/gspca/jl2005bcd.c
+++ b/drivers/media/usb/gspca/jl2005bcd.c
@@ -165,7 +165,7 @@ static int jl2005c_get_firmware_id(struct gspca_dev *gspca_dev)
{
struct sd *sd = (struct sd *)gspca_dev;
int i = 0;
- int retval = -1;
+ int retval;
unsigned char regs_to_read[] = {0x57, 0x02, 0x03, 0x5d, 0x5e, 0x5f};
gspca_dbg(gspca_dev, D_PROBE, "Running jl2005c_get_firmware_id\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-24 16:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24 16:25 [PATCH] media: gspca: remove redundant assignment to variable retval Colin King
2020-05-24 16:25 ` Colin King
-- strict thread matches above, loose matches on Subject: below --
2020-04-10 14:18 [PATCH] media: gspca: remove redundant assignment to variable status Colin King
2020-04-10 14:18 ` Colin King
2020-04-11 23:11 ` Ezequiel Garcia
2020-04-11 23:11 ` Ezequiel Garcia
2019-10-11 18:57 [PATCH] media: gspca: remove redundant assignment to variable ret Colin King
2019-10-11 18:57 ` Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.