Re: [PATCH v13 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

From: kbuild test robot <lkp@intel.com>
To: Tali Perry <tali.perry1@gmail.com>,
	ofery@google.com, brendanhiggins@google.com,
	avifishman70@gmail.com, tmaimon77@gmail.com, kfting@nuvoton.com,
	venture@google.com, yuenn@google.com, benjaminfair@google.com,
	robh+dt@kernel.org, wsa@the-dreams.de,
	andriy.shevchenko@linux.intel.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Tali Perry <tali.perry1@gmail.com>,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver
Date: Sun, 24 May 2020 20:20:55 +0800	[thread overview]
Message-ID: <202005242059.BBxhHU3T%lkp@intel.com> (raw)
In-Reply-To: <20200522113312.181413-3-tali.perry1@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4933 bytes --]

Hi Tali,

I love your patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v5.7-rc6 next-20200522]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tali-Perry/i2c-npcm7xx-add-NPCM-i2c-controller-driver/20200522-193916
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: x86_64-allmodconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/i2c/busses/i2c-npcm7xx.c:1797:1: error: redefinition of '__inittest'
module_init(npcm_i2c_init);
^
include/linux/module.h:131:42: note: expanded from macro 'module_init'
static inline initcall_t __maybe_unused __inittest(void)                                                                   ^
drivers/i2c/busses/i2c-npcm7xx.c:1778:1: note: previous definition is here
module_platform_driver(npcm_i2c_bus_driver);
^
include/linux/platform_device.h:247:2: note: expanded from macro 'module_platform_driver'
module_driver(__platform_driver, platform_driver_register,            ^
include/linux/device/driver.h:262:3: note: expanded from macro 'module_driver'
}      ^
include/linux/module.h:131:42: note: expanded from macro '   module_init'
static inline initcall_t __maybe_unused __inittest(void)                                                                   ^
>> drivers/i2c/busses/i2c-npcm7xx.c:1797:1: error: redefinition of 'init_module'
module_init(npcm_i2c_init);
^
include/linux/module.h:133:6: note: expanded from macro 'module_init'
int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
^
drivers/i2c/busses/i2c-npcm7xx.c:1778:1: note: previous definition is here
module_platform_driver(npcm_i2c_bus_driver);
^
include/linux/platform_device.h:247:2: note: expanded from macro 'module_platform_driver'
module_driver(__platform_driver, platform_driver_register,            ^
include/linux/device/driver.h:262:3: note: expanded from macro 'module_driver'
}      ^
include/linux/module.h:133:6: note: expanded from macro '   module_init'
int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
^
>> drivers/i2c/busses/i2c-npcm7xx.c:1798:1: error: redefinition of '__exittest'
module_exit(npcm_i2c_exit);
^
include/linux/module.h:137:42: note: expanded from macro 'module_exit'
static inline exitcall_t __maybe_unused __exittest(void)                                                                   ^
drivers/i2c/busses/i2c-npcm7xx.c:1778:1: note: previous definition is here
module_platform_driver(npcm_i2c_bus_driver);
^
include/linux/platform_device.h:247:2: note: expanded from macro 'module_platform_driver'
module_driver(__platform_driver, platform_driver_register,            ^
include/linux/device/driver.h:267:3: note: expanded from macro 'module_driver'
}      ^
include/linux/module.h:137:42: note: expanded from macro '   module_exit'
static inline exitcall_t __maybe_unused __exittest(void)                                                                   ^
>> drivers/i2c/busses/i2c-npcm7xx.c:1798:1: error: redefinition of 'cleanup_module'
module_exit(npcm_i2c_exit);
^
include/linux/module.h:139:7: note: expanded from macro 'module_exit'
void cleanup_module(void) __copy(exitfn) __attribute__((alias(#exitfn)));
^
drivers/i2c/busses/i2c-npcm7xx.c:1778:1: note: previous definition is here
module_platform_driver(npcm_i2c_bus_driver);
^
include/linux/platform_device.h:247:2: note: expanded from macro 'module_platform_driver'
module_driver(__platform_driver, platform_driver_register,            ^
include/linux/device/driver.h:267:3: note: expanded from macro 'module_driver'
}      ^
include/linux/module.h:139:7: note: expanded from macro '   module_exit'
void cleanup_module(void) __copy(exitfn) __attribute__((alias(#exitfn)));
^
4 errors generated.

vim +/__inittest +1797 drivers/i2c/busses/i2c-npcm7xx.c

  1796	
> 1797	module_init(npcm_i2c_init);
> 1798	module_exit(npcm_i2c_exit);
  1799	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74080 bytes --]