Re: [PATCH v2 3/9] usb: cdns3: imx: add glue layer runtime pm implementation

From: Peter Chen <peter.chen@nxp.com>
To: kbuild test robot <lkp@intel.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
	"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
	"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"pawell@cadence.com" <pawell@cadence.com>,
	"rogerq@ti.com" <rogerq@ti.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	Jun Li <jun.li@nxp.com>
Subject: Re: [PATCH v2 3/9] usb: cdns3: imx: add glue layer runtime pm implementation
Date: Mon, 25 May 2020 06:31:10 +0000	[thread overview]
Message-ID: <20200525063134.GD16948@b29397-desktop> (raw)
In-Reply-To: <202005251215.nsp7iG6y%lkp@intel.com>

On 20-05-25 12:53:11, kbuild test robot wrote:
> Hi Peter,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on usb/usb-testing]
> [also build test WARNING on balbi-usb/testing/next next-20200522]
> [cannot apply to shawnguo/for-next v5.7-rc7]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstackoverflow.com%2Fa%2F37406982&amp;data=02%7C01%7Cpeter.chen%40nxp.com%7Cd98349851abc4e0abf1408d8006799d7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637259792390096024&amp;sdata=yRFR26%2FjlA8dg0wS4xGplfPvXtG8tYa1qb2lroSsq0Y%3D&amp;reserved=0]
> 
> url:    https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FPeter-Chen%2Fusb-some-PM-changes-for-cdns3-and-xhci-plat%2F20200524-072451&amp;data=02%7C01%7Cpeter.chen%40nxp.com%7Cd98349851abc4e0abf1408d8006799d7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637259792390096024&amp;sdata=mJmxpr0897Sk415jiIGMg0Q7jIxAO93t%2FvUoJxAOXIg%3D&amp;reserved=0
> base:   https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fgregkh%2Fusb.git&amp;data=02%7C01%7Cpeter.chen%40nxp.com%7Cd98349851abc4e0abf1408d8006799d7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637259792390096024&amp;sdata=nrCKZGGd4%2FFUKaIGm1PTn2OzeJ3XbSZvb9sn7GHgFBw%3D&amp;reserved=0 usb-testing
> config: s390-randconfig-s002-20200524 (attached as .config)
> compiler: s390-linux-gcc (GCC) 9.3.0
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.1-240-gf0fe1cd9-dirty
>         # save the attached .config to linux build tree
>         make W=1 C=1 ARCH=s390 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
> 
> >> drivers/usb/cdns3/cdns3-imx.c:150:12: warning: 'cdns_imx_platform_suspend' used but never defined

Will fix it at next revision, thanks.

Peter
> 150 | static int cdns_imx_platform_suspend(struct device *dev,
> |            ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> vim +/cdns_imx_platform_suspend +150 drivers/usb/cdns3/cdns3-imx.c
> 
>    149	
>  > 150	static int cdns_imx_platform_suspend(struct device *dev,
>    151		bool suspend, bool wakeup);
>    152	static struct cdns3_platform_data cdns_imx_pdata = {
>    153		.platform_suspend = cdns_imx_platform_suspend,
>    154	};
>    155	
> 

-- 

Thanks,
Peter Chen