All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: mpe@ellerman.id.au, benh@kernel.crashing.org,
	akpm@linux-foundation.org, peterz@infradead.org,
	mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, pbonzini@redhat.com, sfr@canb.auug.org.au,
	rppt@linux.ibm.com, aneesh.kumar@linux.ibm.com,
	msuchanek@suse.de, kvm-ppc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, kvm@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	John Hubbard <jhubbard@nvidia.com>
Subject: Re: [linux-next PATCH] mm/gup.c: Convert to use get_user_{page|pages}_fast_only()
Date: Tue, 26 May 2020 17:59:04 +1000	[thread overview]
Message-ID: <20200526075904.GE282305@thinks.paulus.ozlabs.org> (raw)
In-Reply-To: <1590396812-31277-1-git-send-email-jrdr.linux@gmail.com>

On Mon, May 25, 2020 at 02:23:32PM +0530, Souptick Joarder wrote:
> API __get_user_pages_fast() renamed to get_user_pages_fast_only()
> to align with pin_user_pages_fast_only().
> 
> As part of this we will get rid of write parameter.
> Instead caller will pass FOLL_WRITE to get_user_pages_fast_only().
> This will not change any existing functionality of the API.
> 
> All the callers are changed to pass FOLL_WRITE.
> 
> Also introduce get_user_page_fast_only(), and use it in a few
> places that hard-code nr_pages to 1.
> 
> Updated the documentation of the API.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

The arch/powerpc/kvm bits look reasonable.

Reviewed-by: Paul Mackerras <paulus@ozlabs.org>

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: mark.rutland@arm.com, kvm@vger.kernel.org, peterz@infradead.org,
	linux-mm@kvack.org, jolsa@redhat.com, sfr@canb.auug.org.au,
	Matthew Wilcox <willy@infradead.org>,
	rppt@linux.ibm.com, alexander.shishkin@linux.intel.com,
	mingo@redhat.com, msuchanek@suse.de,
	John Hubbard <jhubbard@nvidia.com>,
	kvm-ppc@vger.kernel.org, acme@kernel.org, namhyung@kernel.org,
	linux-kernel@vger.kernel.org, aneesh.kumar@linux.ibm.com,
	pbonzini@redhat.com, akpm@linux-foundation.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [linux-next PATCH] mm/gup.c: Convert to use get_user_{page|pages}_fast_only()
Date: Tue, 26 May 2020 17:59:04 +1000	[thread overview]
Message-ID: <20200526075904.GE282305@thinks.paulus.ozlabs.org> (raw)
In-Reply-To: <1590396812-31277-1-git-send-email-jrdr.linux@gmail.com>

On Mon, May 25, 2020 at 02:23:32PM +0530, Souptick Joarder wrote:
> API __get_user_pages_fast() renamed to get_user_pages_fast_only()
> to align with pin_user_pages_fast_only().
> 
> As part of this we will get rid of write parameter.
> Instead caller will pass FOLL_WRITE to get_user_pages_fast_only().
> This will not change any existing functionality of the API.
> 
> All the callers are changed to pass FOLL_WRITE.
> 
> Also introduce get_user_page_fast_only(), and use it in a few
> places that hard-code nr_pages to 1.
> 
> Updated the documentation of the API.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

The arch/powerpc/kvm bits look reasonable.

Reviewed-by: Paul Mackerras <paulus@ozlabs.org>

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: mpe@ellerman.id.au, benh@kernel.crashing.org,
	akpm@linux-foundation.org, peterz@infradead.org,
	mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, pbonzini@redhat.com, sfr@canb.auug.org.au,
	rppt@linux.ibm.com, aneesh.kumar@linux.ibm.com,
	msuchanek@suse.de, kvm-ppc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, kvm@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	John Hubbard <jhubbard@nvidia.com>
Subject: Re: [linux-next PATCH] mm/gup.c: Convert to use get_user_{page|pages}_fast_only()
Date: Tue, 26 May 2020 07:59:04 +0000	[thread overview]
Message-ID: <20200526075904.GE282305@thinks.paulus.ozlabs.org> (raw)
In-Reply-To: <1590396812-31277-1-git-send-email-jrdr.linux@gmail.com>

On Mon, May 25, 2020 at 02:23:32PM +0530, Souptick Joarder wrote:
> API __get_user_pages_fast() renamed to get_user_pages_fast_only()
> to align with pin_user_pages_fast_only().
> 
> As part of this we will get rid of write parameter.
> Instead caller will pass FOLL_WRITE to get_user_pages_fast_only().
> This will not change any existing functionality of the API.
> 
> All the callers are changed to pass FOLL_WRITE.
> 
> Also introduce get_user_page_fast_only(), and use it in a few
> places that hard-code nr_pages to 1.
> 
> Updated the documentation of the API.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

The arch/powerpc/kvm bits look reasonable.

Reviewed-by: Paul Mackerras <paulus@ozlabs.org>

  reply	other threads:[~2020-05-26  7:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25  8:45 [linux-next PATCH] mm/gup.c: Convert to use get_user_{page|pages}_fast_only() Souptick Joarder
2020-05-25  8:53 ` Souptick Joarder
2020-05-25  8:53 ` Souptick Joarder
2020-05-26  7:59 ` Paul Mackerras [this message]
2020-05-26  7:59   ` Paul Mackerras
2020-05-26  7:59   ` Paul Mackerras
2020-05-26 10:40   ` Souptick Joarder
2020-05-26 10:52     ` Souptick Joarder
2020-05-26 10:40     ` Souptick Joarder
2020-05-26 10:40     ` Souptick Joarder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200526075904.GE282305@thinks.paulus.ozlabs.org \
    --to=paulus@ozlabs.org \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=jhubbard@nvidia.com \
    --cc=jolsa@redhat.com \
    --cc=jrdr.linux@gmail.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=msuchanek@suse.de \
    --cc=namhyung@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rppt@linux.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.