* [PATCH] staging: wlan-ng: Fix number of characters warning style.
@ 2020-05-25 22:10 Igor Ribeiro Barbosa Duarte
2020-05-26 5:59 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Igor Ribeiro Barbosa Duarte @ 2020-05-25 22:10 UTC (permalink / raw)
To: gregkh; +Cc: devel, igor.ribeiro.duarte
Fix checkpatch error "WARNING: line over 80 characters" at cfg80211.c:451
Signed-off-by: Igor Ribeiro Barbosa Duarte <igor.ribeiro.duarte@gmail.com>
---
drivers/staging/wlan-ng/cfg80211.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index fac38c8..a911bcd 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -447,9 +447,10 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
/* Set the channel */
if (channel) {
chan = ieee80211_frequency_to_channel(channel->center_freq);
- result = prism2_domibset_uint32(wlandev,
- DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
- chan);
+ result = prism2_domibset_uint32
+ (wlandev,
+ DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
+ chan);
if (result)
goto exit;
}
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wlan-ng: Fix number of characters warning style.
2020-05-25 22:10 [PATCH] staging: wlan-ng: Fix number of characters warning style Igor Ribeiro Barbosa Duarte
@ 2020-05-26 5:59 ` Greg KH
2020-05-26 15:27 ` Igor Ribeiro Barbosa Duarte
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-05-26 5:59 UTC (permalink / raw)
To: Igor Ribeiro Barbosa Duarte; +Cc: devel
On Mon, May 25, 2020 at 07:10:25PM -0300, Igor Ribeiro Barbosa Duarte wrote:
> Fix checkpatch error "WARNING: line over 80 characters" at cfg80211.c:451
>
> Signed-off-by: Igor Ribeiro Barbosa Duarte <igor.ribeiro.duarte@gmail.com>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index fac38c8..a911bcd 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -447,9 +447,10 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
> /* Set the channel */
> if (channel) {
> chan = ieee80211_frequency_to_channel(channel->center_freq);
> - result = prism2_domibset_uint32(wlandev,
> - DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
> - chan);
> + result = prism2_domibset_uint32
> + (wlandev,
> + DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
> + chan);
The original really is easier to read and understand, don't you think
so?
Checkpatch is a hint, it doesn't always have to be followed exactly.
Perhaps that crazy #define could be shortened, or use a more
conventional name?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wlan-ng: Fix number of characters warning style.
2020-05-26 5:59 ` Greg KH
@ 2020-05-26 15:27 ` Igor Ribeiro Barbosa Duarte
0 siblings, 0 replies; 3+ messages in thread
From: Igor Ribeiro Barbosa Duarte @ 2020-05-26 15:27 UTC (permalink / raw)
To: Greg KH; +Cc: devel, igor.ribeiro.duarte
On Tue, May 26, 2020 at 07:59:32AM +0200, Greg KH wrote:
> On Mon, May 25, 2020 at 07:10:25PM -0300, Igor Ribeiro Barbosa Duarte wrote:
> > Fix checkpatch error "WARNING: line over 80 characters" at cfg80211.c:451
> >
> > Signed-off-by: Igor Ribeiro Barbosa Duarte <igor.ribeiro.duarte@gmail.com>
> > ---
> > drivers/staging/wlan-ng/cfg80211.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> > index fac38c8..a911bcd 100644
> > --- a/drivers/staging/wlan-ng/cfg80211.c
> > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > @@ -447,9 +447,10 @@ static int prism2_connect(struct wiphy *wiphy, struct net_device *dev,
> > /* Set the channel */
> > if (channel) {
> > chan = ieee80211_frequency_to_channel(channel->center_freq);
> > - result = prism2_domibset_uint32(wlandev,
> > - DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
> > - chan);
> > + result = prism2_domibset_uint32
> > + (wlandev,
> > + DIDMIB_DOT11PHY_DSSSTABLE_CURRENTCHANNEL,
> > + chan);
>
> The original really is easier to read and understand, don't you think
> so?
>
> Checkpatch is a hint, it doesn't always have to be followed exactly.
> Perhaps that crazy #define could be shortened, or use a more
> conventional name?
>
> thanks,
>
> greg k-h
Right, I'll check this. Thank you.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-26 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25 22:10 [PATCH] staging: wlan-ng: Fix number of characters warning style Igor Ribeiro Barbosa Duarte
2020-05-26 5:59 ` Greg KH
2020-05-26 15:27 ` Igor Ribeiro Barbosa Duarte
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.