All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8
@ 2020-05-26 15:30 Guenter Roeck
  2020-05-26 15:40 ` Nick Desaulniers
  0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2020-05-26 15:30 UTC (permalink / raw)
  To: Will Deacon
  Cc: Brian Cain, linux-hexagon, linux-kernel, Thomas Gleixner,
	Masahiro Yamada, Nick Desaulniers, Peter Zijlstra, Arnd Bergmann

On Mon, May 11, 2020 at 09:41:37PM +0100, Will Deacon wrote:
> It is very rare to see versions of GCC prior to 4.8 being used to build
> the mainline kernel. These old compilers are also known to have codegen
> issues which can lead to silent miscompilation:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> 
> Raise the minimum GCC version to 4.8 for building the kernel and remove
> some tautological Kconfig dependencies as a consequence.

My hexagon compiler is v4.6.1, and I have been unable to find a more
recent version. Does anyone happen to have a pointer to a hexagon toolchain
with gcc 4.8 or later ?

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8
  2020-05-26 15:30 [PATCH] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8 Guenter Roeck
@ 2020-05-26 15:40 ` Nick Desaulniers
  2020-05-26 16:03   ` Guenter Roeck
  2020-05-26 21:57     ` Brian Cain
  0 siblings, 2 replies; 6+ messages in thread
From: Nick Desaulniers @ 2020-05-26 15:40 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Will Deacon, Brian Cain, linux-hexagon, LKML, Thomas Gleixner,
	Masahiro Yamada, Peter Zijlstra, Arnd Bergmann

On Tue, May 26, 2020 at 8:30 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Mon, May 11, 2020 at 09:41:37PM +0100, Will Deacon wrote:
> > It is very rare to see versions of GCC prior to 4.8 being used to build
> > the mainline kernel. These old compilers are also known to have codegen
> > issues which can lead to silent miscompilation:
> >
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> >
> > Raise the minimum GCC version to 4.8 for building the kernel and remove
> > some tautological Kconfig dependencies as a consequence.
>
> My hexagon compiler is v4.6.1, and I have been unable to find a more
> recent version. Does anyone happen to have a pointer to a hexagon toolchain
> with gcc 4.8 or later ?

IIUC, hexagon moved to LLVM, though that target still has issues
building the kernel.
https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aopen+is%3Aissue+label%3A%22%5BARCH%5D+hexagon%22
-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8
  2020-05-26 15:40 ` Nick Desaulniers
@ 2020-05-26 16:03   ` Guenter Roeck
  2020-05-26 16:08     ` Nick Desaulniers
  2020-05-26 21:57     ` Brian Cain
  1 sibling, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2020-05-26 16:03 UTC (permalink / raw)
  To: Nick Desaulniers
  Cc: Will Deacon, Brian Cain, linux-hexagon, LKML, Thomas Gleixner,
	Masahiro Yamada, Peter Zijlstra, Arnd Bergmann

Hi Nick,

On 5/26/20 8:40 AM, Nick Desaulniers wrote:
> On Tue, May 26, 2020 at 8:30 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On Mon, May 11, 2020 at 09:41:37PM +0100, Will Deacon wrote:
>>> It is very rare to see versions of GCC prior to 4.8 being used to build
>>> the mainline kernel. These old compilers are also known to have codegen
>>> issues which can lead to silent miscompilation:
>>>
>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
>>>
>>> Raise the minimum GCC version to 4.8 for building the kernel and remove
>>> some tautological Kconfig dependencies as a consequence.
>>
>> My hexagon compiler is v4.6.1, and I have been unable to find a more
>> recent version. Does anyone happen to have a pointer to a hexagon toolchain
>> with gcc 4.8 or later ?
> 
> IIUC, hexagon moved to LLVM, though that target still has issues
> building the kernel.
> https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aopen+is%3Aissue+label%3A%22%5BARCH%5D+hexagon%22
> 

That won't help me for my build tests. It is bad enough having to maintain
one compiler. I don't want to add another one to the mix, and I'll happily
leave llvm build tests for ClangBuiltLinux. Guess I'll have to stop hexagon
test builds starting with 5.8.

Guenter

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8
  2020-05-26 16:03   ` Guenter Roeck
@ 2020-05-26 16:08     ` Nick Desaulniers
  0 siblings, 0 replies; 6+ messages in thread
From: Nick Desaulniers @ 2020-05-26 16:08 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Will Deacon, Brian Cain, linux-hexagon, LKML, Thomas Gleixner,
	Masahiro Yamada, Peter Zijlstra, Arnd Bergmann

On Tue, May 26, 2020 at 9:03 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Hi Nick,
>
> On 5/26/20 8:40 AM, Nick Desaulniers wrote:
> > On Tue, May 26, 2020 at 8:30 AM Guenter Roeck <linux@roeck-us.net> wrote:
> >>
> >> On Mon, May 11, 2020 at 09:41:37PM +0100, Will Deacon wrote:
> >>> It is very rare to see versions of GCC prior to 4.8 being used to build
> >>> the mainline kernel. These old compilers are also known to have codegen
> >>> issues which can lead to silent miscompilation:
> >>>
> >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> >>>
> >>> Raise the minimum GCC version to 4.8 for building the kernel and remove
> >>> some tautological Kconfig dependencies as a consequence.
> >>
> >> My hexagon compiler is v4.6.1, and I have been unable to find a more
> >> recent version. Does anyone happen to have a pointer to a hexagon toolchain
> >> with gcc 4.8 or later ?
> >
> > IIUC, hexagon moved to LLVM, though that target still has issues
> > building the kernel.
> > https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aopen+is%3Aissue+label%3A%22%5BARCH%5D+hexagon%22
> >
>
> That won't help me for my build tests. It is bad enough having to maintain
> one compiler. I don't want to add another one to the mix, and I'll happily
> leave llvm build tests for ClangBuiltLinux. Guess I'll have to stop hexagon

:( We could use the additional test coverage.

> test builds starting with 5.8.
>
> Guenter



-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8
  2020-05-26 15:40 ` Nick Desaulniers
@ 2020-05-26 21:57     ` Brian Cain
  2020-05-26 21:57     ` Brian Cain
  1 sibling, 0 replies; 6+ messages in thread
From: Brian Cain @ 2020-05-26 21:57 UTC (permalink / raw)
  To: 'Nick Desaulniers', 'Guenter Roeck'
  Cc: 'Will Deacon', linux-hexagon, 'LKML',
	'Thomas Gleixner', 'Masahiro Yamada',
	'Peter Zijlstra', 'Arnd Bergmann',
	sidneym

> -----Original Message-----
> From: linux-hexagon-owner@vger.kernel.org <linux-hexagon-
> owner@vger.kernel.org> On Behalf Of Nick Desaulniers
...
> On Tue, May 26, 2020 at 8:30 AM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On Mon, May 11, 2020 at 09:41:37PM +0100, Will Deacon wrote:
> > > It is very rare to see versions of GCC prior to 4.8 being used to
> > > build the mainline kernel. These old compilers are also known to
> > > have codegen issues which can lead to silent miscompilation:
> > >
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> > >
> > > Raise the minimum GCC version to 4.8 for building the kernel and
> > > remove some tautological Kconfig dependencies as a consequence.
> >
> > My hexagon compiler is v4.6.1, and I have been unable to find a more
> > recent version. Does anyone happen to have a pointer to a hexagon
> > toolchain with gcc 4.8 or later ?
> 
> IIUC, hexagon moved to LLVM, though that target still has issues building the
> kernel.
> https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aopen+is%3Aissue+lab
> el%3A%22%5BARCH%5D+hexagon%22

Indeed, we did move to llvm.  The build works with the clang_rt-builtins lib.  But that issue indicates that it's an unnecessary wart to require that.  From what I understand, other arches contribute these builtins content to the kernel build, so we'll do the same.

I'll prioritize this update.

-Brian


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8
@ 2020-05-26 21:57     ` Brian Cain
  0 siblings, 0 replies; 6+ messages in thread
From: Brian Cain @ 2020-05-26 21:57 UTC (permalink / raw)
  To: 'Nick Desaulniers', 'Guenter Roeck'
  Cc: 'Will Deacon', linux-hexagon, 'LKML',
	'Thomas Gleixner', 'Masahiro Yamada',
	'Peter Zijlstra', 'Arnd Bergmann',
	sidneym

> -----Original Message-----
> From: linux-hexagon-owner@vger.kernel.org <linux-hexagon-
> owner@vger.kernel.org> On Behalf Of Nick Desaulniers
...
> On Tue, May 26, 2020 at 8:30 AM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On Mon, May 11, 2020 at 09:41:37PM +0100, Will Deacon wrote:
> > > It is very rare to see versions of GCC prior to 4.8 being used to
> > > build the mainline kernel. These old compilers are also known to
> > > have codegen issues which can lead to silent miscompilation:
> > >
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> > >
> > > Raise the minimum GCC version to 4.8 for building the kernel and
> > > remove some tautological Kconfig dependencies as a consequence.
> >
> > My hexagon compiler is v4.6.1, and I have been unable to find a more
> > recent version. Does anyone happen to have a pointer to a hexagon
> > toolchain with gcc 4.8 or later ?
> 
> IIUC, hexagon moved to LLVM, though that target still has issues building the
> kernel.
> https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aopen+is%3Aissue+lab
> el%3A%22%5BARCH%5D+hexagon%22

Indeed, we did move to llvm.  The build works with the clang_rt-builtins lib.  But that issue indicates that it's an unnecessary wart to require that.  From what I understand, other arches contribute these builtins content to the kernel build, so we'll do the same.

I'll prioritize this update.

-Brian


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-05-26 21:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 15:30 [PATCH] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8 Guenter Roeck
2020-05-26 15:40 ` Nick Desaulniers
2020-05-26 16:03   ` Guenter Roeck
2020-05-26 16:08     ` Nick Desaulniers
2020-05-26 21:57   ` Brian Cain
2020-05-26 21:57     ` Brian Cain

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.