All of lore.kernel.org
 help / color / mirror / Atom feed
* Warnings on Edison
@ 2020-05-19 16:47 Simon Glass
  2020-05-20  8:17 ` Andy Shevchenko
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Glass @ 2020-05-19 16:47 UTC (permalink / raw)
  To: u-boot

Hi Andy,

When I build edison on master I recently started seeing this warning:

+board/intel/edison/dsdt.asl.tmp    210:         Name (SSCN, Package ()
+Warning  4089 -                Object is not referenced ^
+
+board/intel/edison/dsdt.asl.tmp    214:         Name (FMCN, Package ()
+board/intel/edison/dsdt.asl.tmp    218:         Name (HSCN, Package ()
+board/intel/edison/dsdt.asl.tmp    239:         Name (SSCN, Package ()
+board/intel/edison/dsdt.asl.tmp    243:         Name (FMCN, Package ()
+board/intel/edison/dsdt.asl.tmp    247:         Name (HSCN, Package ()
+board/intel/edison/dsdt.asl.tmp    291:             Method (GPLD, 1,
Serialized) {
+Warning  4089 -                      Object is not referenced ^

Do you have any thoughts on how to fix it?

Regards,
SImon

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Warnings on Edison
  2020-05-19 16:47 Warnings on Edison Simon Glass
@ 2020-05-20  8:17 ` Andy Shevchenko
  2020-05-20 13:06   ` Tom Rini
  2020-05-26  8:27   ` Bin Meng
  0 siblings, 2 replies; 9+ messages in thread
From: Andy Shevchenko @ 2020-05-20  8:17 UTC (permalink / raw)
  To: u-boot

On Tue, May 19, 2020 at 10:47:27AM -0600, Simon Glass wrote:
> Hi Andy,
> 
> When I build edison on master I recently started seeing this warning:
> 
> +board/intel/edison/dsdt.asl.tmp    210:         Name (SSCN, Package ()
> +Warning  4089 -                Object is not referenced ^
> +
> +board/intel/edison/dsdt.asl.tmp    214:         Name (FMCN, Package ()
> +board/intel/edison/dsdt.asl.tmp    218:         Name (HSCN, Package ()
> +board/intel/edison/dsdt.asl.tmp    239:         Name (SSCN, Package ()
> +board/intel/edison/dsdt.asl.tmp    243:         Name (FMCN, Package ()
> +board/intel/edison/dsdt.asl.tmp    247:         Name (HSCN, Package ()
> +board/intel/edison/dsdt.asl.tmp    291:             Method (GPLD, 1,
> Serialized) {
> +Warning  4089 -                      Object is not referenced ^

Can't reproduce.
ASL+ Optimizing Compiler/Disassembler version 20190509

> Do you have any thoughts on how to fix it?

Yes, file a bug in ACPICA bugzilla.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Warnings on Edison
  2020-05-20  8:17 ` Andy Shevchenko
@ 2020-05-20 13:06   ` Tom Rini
  2020-05-20 13:22     ` Simon Glass
  2020-05-26  8:27   ` Bin Meng
  1 sibling, 1 reply; 9+ messages in thread
From: Tom Rini @ 2020-05-20 13:06 UTC (permalink / raw)
  To: u-boot

On Wed, May 20, 2020 at 11:17:17AM +0300, Andy Shevchenko wrote:
> On Tue, May 19, 2020 at 10:47:27AM -0600, Simon Glass wrote:
> > Hi Andy,
> > 
> > When I build edison on master I recently started seeing this warning:
> > 
> > +board/intel/edison/dsdt.asl.tmp    210:         Name (SSCN, Package ()
> > +Warning  4089 -                Object is not referenced ^
> > +
> > +board/intel/edison/dsdt.asl.tmp    214:         Name (FMCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    218:         Name (HSCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    239:         Name (SSCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    243:         Name (FMCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    247:         Name (HSCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    291:             Method (GPLD, 1,
> > Serialized) {
> > +Warning  4089 -                      Object is not referenced ^
> 
> Can't reproduce.
> ASL+ Optimizing Compiler/Disassembler version 20190509

Ah, that explains it then I bet.  Ubuntu/bionic is:
ASL+ Optimizing Compiler/Disassembler version 20180105

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200520/6eea8e29/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Warnings on Edison
  2020-05-20 13:06   ` Tom Rini
@ 2020-05-20 13:22     ` Simon Glass
  2020-05-20 13:35       ` Tom Rini
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Glass @ 2020-05-20 13:22 UTC (permalink / raw)
  To: u-boot

Hi Tom,

On Wed, 20 May 2020 at 07:06, Tom Rini <trini@konsulko.com> wrote:
>
> On Wed, May 20, 2020 at 11:17:17AM +0300, Andy Shevchenko wrote:
> > On Tue, May 19, 2020 at 10:47:27AM -0600, Simon Glass wrote:
> > > Hi Andy,
> > >
> > > When I build edison on master I recently started seeing this warning:
> > >
> > > +board/intel/edison/dsdt.asl.tmp    210:         Name (SSCN, Package ()
> > > +Warning  4089 -                Object is not referenced ^
> > > +
> > > +board/intel/edison/dsdt.asl.tmp    214:         Name (FMCN, Package ()
> > > +board/intel/edison/dsdt.asl.tmp    218:         Name (HSCN, Package ()
> > > +board/intel/edison/dsdt.asl.tmp    239:         Name (SSCN, Package ()
> > > +board/intel/edison/dsdt.asl.tmp    243:         Name (FMCN, Package ()
> > > +board/intel/edison/dsdt.asl.tmp    247:         Name (HSCN, Package ()
> > > +board/intel/edison/dsdt.asl.tmp    291:             Method (GPLD, 1,
> > > Serialized) {
> > > +Warning  4089 -                      Object is not referenced ^
> >
> > Can't reproduce.
> > ASL+ Optimizing Compiler/Disassembler version 20190509
>
> Ah, that explains it then I bet.  Ubuntu/bionic is:
> ASL+ Optimizing Compiler/Disassembler version 20180105

I must have installed something newer, 20180810. I have not upgraded
to 2020.04 yet. A bit nervous about what will change.

Regards,
Simon

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Warnings on Edison
  2020-05-20 13:22     ` Simon Glass
@ 2020-05-20 13:35       ` Tom Rini
  2020-05-20 14:16         ` Andy Shevchenko
  0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2020-05-20 13:35 UTC (permalink / raw)
  To: u-boot

On Wed, May 20, 2020 at 07:22:26AM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Wed, 20 May 2020 at 07:06, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Wed, May 20, 2020 at 11:17:17AM +0300, Andy Shevchenko wrote:
> > > On Tue, May 19, 2020 at 10:47:27AM -0600, Simon Glass wrote:
> > > > Hi Andy,
> > > >
> > > > When I build edison on master I recently started seeing this warning:
> > > >
> > > > +board/intel/edison/dsdt.asl.tmp    210:         Name (SSCN, Package ()
> > > > +Warning  4089 -                Object is not referenced ^
> > > > +
> > > > +board/intel/edison/dsdt.asl.tmp    214:         Name (FMCN, Package ()
> > > > +board/intel/edison/dsdt.asl.tmp    218:         Name (HSCN, Package ()
> > > > +board/intel/edison/dsdt.asl.tmp    239:         Name (SSCN, Package ()
> > > > +board/intel/edison/dsdt.asl.tmp    243:         Name (FMCN, Package ()
> > > > +board/intel/edison/dsdt.asl.tmp    247:         Name (HSCN, Package ()
> > > > +board/intel/edison/dsdt.asl.tmp    291:             Method (GPLD, 1,
> > > > Serialized) {
> > > > +Warning  4089 -                      Object is not referenced ^
> > >
> > > Can't reproduce.
> > > ASL+ Optimizing Compiler/Disassembler version 20190509
> >
> > Ah, that explains it then I bet.  Ubuntu/bionic is:
> > ASL+ Optimizing Compiler/Disassembler version 20180105
> 
> I must have installed something newer, 20180810. I have not upgraded
> to 2020.04 yet. A bit nervous about what will change.

To be clear, I see the warning on bionic too.  If we can easily install
just a new iasl in CI (and locally as needed) via deb, that would be
good, otherwise if it's just a warning maybe we live with it, so long as
Edison still works.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200520/961303a2/attachment.sig>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Warnings on Edison
  2020-05-20 13:35       ` Tom Rini
@ 2020-05-20 14:16         ` Andy Shevchenko
  2020-05-22 17:59           ` Ferry Toth
  0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2020-05-20 14:16 UTC (permalink / raw)
  To: u-boot

On Wed, May 20, 2020 at 09:35:34AM -0400, Tom Rini wrote:

...

> as Edison still works.

I believe no-one who is building it from sources for Edison uses that old
ACPICA tools.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Warnings on Edison
  2020-05-20 14:16         ` Andy Shevchenko
@ 2020-05-22 17:59           ` Ferry Toth
  0 siblings, 0 replies; 9+ messages in thread
From: Ferry Toth @ 2020-05-22 17:59 UTC (permalink / raw)
  To: u-boot

Op 20-05-2020 om 16:16 schreef Andy Shevchenko:
> On Wed, May 20, 2020 at 09:35:34AM -0400, Tom Rini wrote:
> 
> ...
> 
>> as Edison still works.
> 
> I believe no-one who is building it from sources for Edison uses that old
> ACPICA tools.
> 
Building with Yocto we are on 20190215
https://github.com/westeri/meta-acpi/tree/master/recipes-bsp/acpica

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Warnings on Edison
  2020-05-20  8:17 ` Andy Shevchenko
  2020-05-20 13:06   ` Tom Rini
@ 2020-05-26  8:27   ` Bin Meng
  2020-05-26 16:00     ` Andy Shevchenko
  1 sibling, 1 reply; 9+ messages in thread
From: Bin Meng @ 2020-05-26  8:27 UTC (permalink / raw)
  To: u-boot

Hi Andy,

On Wed, May 20, 2020 at 4:17 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, May 19, 2020 at 10:47:27AM -0600, Simon Glass wrote:
> > Hi Andy,
> >
> > When I build edison on master I recently started seeing this warning:
> >
> > +board/intel/edison/dsdt.asl.tmp    210:         Name (SSCN, Package ()
> > +Warning  4089 -                Object is not referenced ^
> > +
> > +board/intel/edison/dsdt.asl.tmp    214:         Name (FMCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    218:         Name (HSCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    239:         Name (SSCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    243:         Name (FMCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    247:         Name (HSCN, Package ()
> > +board/intel/edison/dsdt.asl.tmp    291:             Method (GPLD, 1,
> > Serialized) {
> > +Warning  4089 -                      Object is not referenced ^
>
> Can't reproduce.
> ASL+ Optimizing Compiler/Disassembler version 20190509
>
> > Do you have any thoughts on how to fix it?
>
> Yes, file a bug in ACPICA bugzilla.

board/intel/edison/dsdt.asl.tmp     28: Device (PCI0)
Warning  3073 -                    Multiple types ^  (Device object
requires either a _HID or _ADR, but not both)

board/intel/edison/dsdt.asl.tmp    292:                 Name (PCKG, Package () {
Remark   2173 -                                                 ^
Creation of named objects within a method is highly inefficient, use
globals or method local variables instead (\_SB.PCI0.DWC3.RHUB.GPLD)

board/intel/edison/dsdt.asl.tmp    338:                 Name (RBUF,
ResourceTemplate()
Remark   2173 -                                                 ^
Creation of named objects within a method is highly inefficient, use
globals or method local variables instead (\_SB.PCI0.HSU0.BTH0._CRS)

board/intel/edison/dsdt.asl.tmp    369:         Dev  CC
arch/x86/lib/reloc_ia32_efi.o
ice (PMIC)
Warning  3073 -                            Multiple types ^  (Device
object requires either a _HID or _ADR, but not both)

board/intel/edison/dsdt.asl.tmp    385:                 Name (RBUF,
ResourceTemplate()
Remark   2173 -                                                 ^
Creation of named objects within a method is highly inefficient, use
globals or method local variables instead (\_SB.PCI0.IPC1.PMIC._CRS)

board/intel/edison/dsdt.asl.tmp    428:     Device (GDMA)
Warning  3073 -                        Multiple types ^  (Device
object requires either a _HID or _ADR, but not both)

board/intel/edison/dsdt.asl.tmp    439:             Name (RBUF,
ResourceTemplate ()
Remark   2173 -                                             ^ Creation
of named objects within a method is highly ineffi

This is seen with

$ iasl -v

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20200430
Copyright (c) 2000 - 2020 Intel Corporation

Regards,
Bin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Warnings on Edison
  2020-05-26  8:27   ` Bin Meng
@ 2020-05-26 16:00     ` Andy Shevchenko
  0 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2020-05-26 16:00 UTC (permalink / raw)
  To: u-boot

On Tue, May 26, 2020 at 04:27:51PM +0800, Bin Meng wrote:
> On Wed, May 20, 2020 at 4:17 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, May 19, 2020 at 10:47:27AM -0600, Simon Glass wrote:

....

> board/intel/edison/dsdt.asl.tmp    428:     Device (GDMA)
> Warning  3073 -                        Multiple types ^  (Device
> object requires either a _HID or _ADR, but not both)

Thanks for the report, I have fixed all, except above one. I need to understand
if we can drop one of them safely. This is due to matching with CSRT which has
ACPI HID, but device itself is PCI-ish.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-05-26 16:00 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 16:47 Warnings on Edison Simon Glass
2020-05-20  8:17 ` Andy Shevchenko
2020-05-20 13:06   ` Tom Rini
2020-05-20 13:22     ` Simon Glass
2020-05-20 13:35       ` Tom Rini
2020-05-20 14:16         ` Andy Shevchenko
2020-05-22 17:59           ` Ferry Toth
2020-05-26  8:27   ` Bin Meng
2020-05-26 16:00     ` Andy Shevchenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.