From: David Miller <davem@davemloft.net>
To: brgl@bgdev.pl
Cc: john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, kuba@kernel.org,
matthias.bgg@gmail.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
fparent@baylibre.com, stephane.leprovost@mediatek.com,
pedro.tsai@mediatek.com, andrew.perepech@mediatek.com,
bgolaszewski@baylibre.com, natechancellor@gmail.com
Subject: Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling
Date: Wed, 27 May 2020 11:25:15 -0700 (PDT) [thread overview]
Message-ID: <20200527.112515.1714930146142742523.davem@davemloft.net> (raw)
In-Reply-To: <20200527092404.3567-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Wed, 27 May 2020 11:24:04 +0200
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The dma_addr field in desc_data must not be overwritten until after the
> new skb is mapped. Currently we do replace it with uninitialized value
> in error path. This change fixes it by moving the assignment before the
> label to which we jump after mapping or allocation errors.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Applied, please use "[PATCH net-next]" to clearly indicate the target
GIT tree next time.
Thank you.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: brgl@bgdev.pl
Cc: stephane.leprovost@mediatek.com, bgolaszewski@baylibre.com,
netdev@vger.kernel.org, sean.wang@mediatek.com,
linux-kernel@vger.kernel.org, fparent@baylibre.com,
pedro.tsai@mediatek.com, linux-mediatek@lists.infradead.org,
andrew.perepech@mediatek.com, john@phrozen.org,
matthias.bgg@gmail.com, kuba@kernel.org,
natechancellor@gmail.com, Mark-MC.Lee@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling
Date: Wed, 27 May 2020 11:25:15 -0700 (PDT) [thread overview]
Message-ID: <20200527.112515.1714930146142742523.davem@davemloft.net> (raw)
In-Reply-To: <20200527092404.3567-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Wed, 27 May 2020 11:24:04 +0200
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The dma_addr field in desc_data must not be overwritten until after the
> new skb is mapped. Currently we do replace it with uninitialized value
> in error path. This change fixes it by moving the assignment before the
> label to which we jump after mapping or allocation errors.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Applied, please use "[PATCH net-next]" to clearly indicate the target
GIT tree next time.
Thank you.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: brgl@bgdev.pl
Cc: stephane.leprovost@mediatek.com, bgolaszewski@baylibre.com,
netdev@vger.kernel.org, sean.wang@mediatek.com,
linux-kernel@vger.kernel.org, fparent@baylibre.com,
pedro.tsai@mediatek.com, linux-mediatek@lists.infradead.org,
andrew.perepech@mediatek.com, john@phrozen.org,
matthias.bgg@gmail.com, kuba@kernel.org,
natechancellor@gmail.com, Mark-MC.Lee@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling
Date: Wed, 27 May 2020 11:25:15 -0700 (PDT) [thread overview]
Message-ID: <20200527.112515.1714930146142742523.davem@davemloft.net> (raw)
In-Reply-To: <20200527092404.3567-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Wed, 27 May 2020 11:24:04 +0200
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The dma_addr field in desc_data must not be overwritten until after the
> new skb is mapped. Currently we do replace it with uninitialized value
> in error path. This change fixes it by moving the assignment before the
> label to which we jump after mapping or allocation errors.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Applied, please use "[PATCH net-next]" to clearly indicate the target
GIT tree next time.
Thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-27 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 9:24 [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling Bartosz Golaszewski
2020-05-27 9:24 ` Bartosz Golaszewski
2020-05-27 9:24 ` Bartosz Golaszewski
2020-05-27 15:54 ` Nathan Chancellor
2020-05-27 15:54 ` Nathan Chancellor
2020-05-27 15:54 ` Nathan Chancellor
2020-05-27 18:25 ` David Miller [this message]
2020-05-27 18:25 ` David Miller
2020-05-27 18:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527.112515.1714930146142742523.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew.perepech@mediatek.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=fparent@baylibre.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pedro.tsai@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=stephane.leprovost@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.