* [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused
@ 2020-05-27 13:34 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2020-05-27 13:34 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
David S. Miller, Jakub Kicinski, Bartosz Golaszewski
Cc: Arnd Bergmann, netdev, linux-kernel, linux-mediatek,
Matthias Brugger, linux-arm-kernel
Without CONFIG_PM, the compiler warns about two unused functions:
drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function]
drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,-Wunused-function]
Mark these as __maybe_unused.
Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/mediatek/mtk_star_emac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
index b18ce47c4f2e..3223567fe1cb 100644
--- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
+++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
@@ -1469,7 +1469,7 @@ static int mtk_star_mdio_init(struct net_device *ndev)
return ret;
}
-static int mtk_star_suspend(struct device *dev)
+static __maybe_unused int mtk_star_suspend(struct device *dev)
{
struct mtk_star_priv *priv;
struct net_device *ndev;
@@ -1485,7 +1485,7 @@ static int mtk_star_suspend(struct device *dev)
return 0;
}
-static int mtk_star_resume(struct device *dev)
+static __maybe_unused int mtk_star_resume(struct device *dev)
{
struct mtk_star_priv *priv;
struct net_device *ndev;
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused
@ 2020-05-27 13:34 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2020-05-27 13:34 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
David S. Miller, Jakub Kicinski, Bartosz Golaszewski
Cc: Arnd Bergmann, netdev, linux-kernel, linux-mediatek,
Matthias Brugger, linux-arm-kernel
Without CONFIG_PM, the compiler warns about two unused functions:
drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function]
drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,-Wunused-function]
Mark these as __maybe_unused.
Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/mediatek/mtk_star_emac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
index b18ce47c4f2e..3223567fe1cb 100644
--- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
+++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
@@ -1469,7 +1469,7 @@ static int mtk_star_mdio_init(struct net_device *ndev)
return ret;
}
-static int mtk_star_suspend(struct device *dev)
+static __maybe_unused int mtk_star_suspend(struct device *dev)
{
struct mtk_star_priv *priv;
struct net_device *ndev;
@@ -1485,7 +1485,7 @@ static int mtk_star_suspend(struct device *dev)
return 0;
}
-static int mtk_star_resume(struct device *dev)
+static __maybe_unused int mtk_star_resume(struct device *dev)
{
struct mtk_star_priv *priv;
struct net_device *ndev;
--
2.26.2
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused
2020-05-27 13:34 ` Arnd Bergmann
(?)
@ 2020-05-27 13:37 ` Bartosz Golaszewski
-1 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2020-05-27 13:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
David S. Miller, Jakub Kicinski, Matthias Brugger, netdev,
arm-soc, linux-mediatek, LKML
śr., 27 maj 2020 o 15:35 Arnd Bergmann <arnd@arndb.de> napisał(a):
>
> Without CONFIG_PM, the compiler warns about two unused functions:
>
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function]
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,-Wunused-function]
>
> Mark these as __maybe_unused.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/mediatek/mtk_star_emac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index b18ce47c4f2e..3223567fe1cb 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -1469,7 +1469,7 @@ static int mtk_star_mdio_init(struct net_device *ndev)
> return ret;
> }
>
> -static int mtk_star_suspend(struct device *dev)
> +static __maybe_unused int mtk_star_suspend(struct device *dev)
> {
> struct mtk_star_priv *priv;
> struct net_device *ndev;
> @@ -1485,7 +1485,7 @@ static int mtk_star_suspend(struct device *dev)
> return 0;
> }
>
> -static int mtk_star_resume(struct device *dev)
> +static __maybe_unused int mtk_star_resume(struct device *dev)
> {
> struct mtk_star_priv *priv;
> struct net_device *ndev;
> --
> 2.26.2
>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused
@ 2020-05-27 13:37 ` Bartosz Golaszewski
0 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2020-05-27 13:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Felix Fietkau, netdev, Sean Wang, LKML, Mark Lee, linux-mediatek,
John Crispin, Matthias Brugger, Jakub Kicinski, David S. Miller,
arm-soc
śr., 27 maj 2020 o 15:35 Arnd Bergmann <arnd@arndb.de> napisał(a):
>
> Without CONFIG_PM, the compiler warns about two unused functions:
>
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function]
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,-Wunused-function]
>
> Mark these as __maybe_unused.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/mediatek/mtk_star_emac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index b18ce47c4f2e..3223567fe1cb 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -1469,7 +1469,7 @@ static int mtk_star_mdio_init(struct net_device *ndev)
> return ret;
> }
>
> -static int mtk_star_suspend(struct device *dev)
> +static __maybe_unused int mtk_star_suspend(struct device *dev)
> {
> struct mtk_star_priv *priv;
> struct net_device *ndev;
> @@ -1485,7 +1485,7 @@ static int mtk_star_suspend(struct device *dev)
> return 0;
> }
>
> -static int mtk_star_resume(struct device *dev)
> +static __maybe_unused int mtk_star_resume(struct device *dev)
> {
> struct mtk_star_priv *priv;
> struct net_device *ndev;
> --
> 2.26.2
>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused
@ 2020-05-27 13:37 ` Bartosz Golaszewski
0 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2020-05-27 13:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Felix Fietkau, netdev, Sean Wang, LKML, Mark Lee, linux-mediatek,
John Crispin, Matthias Brugger, Jakub Kicinski, David S. Miller,
arm-soc
śr., 27 maj 2020 o 15:35 Arnd Bergmann <arnd@arndb.de> napisał(a):
>
> Without CONFIG_PM, the compiler warns about two unused functions:
>
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function]
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,-Wunused-function]
>
> Mark these as __maybe_unused.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/mediatek/mtk_star_emac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index b18ce47c4f2e..3223567fe1cb 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -1469,7 +1469,7 @@ static int mtk_star_mdio_init(struct net_device *ndev)
> return ret;
> }
>
> -static int mtk_star_suspend(struct device *dev)
> +static __maybe_unused int mtk_star_suspend(struct device *dev)
> {
> struct mtk_star_priv *priv;
> struct net_device *ndev;
> @@ -1485,7 +1485,7 @@ static int mtk_star_suspend(struct device *dev)
> return 0;
> }
>
> -static int mtk_star_resume(struct device *dev)
> +static __maybe_unused int mtk_star_resume(struct device *dev)
> {
> struct mtk_star_priv *priv;
> struct net_device *ndev;
> --
> 2.26.2
>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused
2020-05-27 13:34 ` Arnd Bergmann
(?)
@ 2020-05-27 18:33 ` David Miller
-1 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2020-05-27 18:33 UTC (permalink / raw)
To: arnd
Cc: nbd, john, sean.wang, Mark-MC.Lee, kuba, bgolaszewski,
matthias.bgg, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 27 May 2020 15:34:45 +0200
> Without CONFIG_PM, the compiler warns about two unused functions:
>
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function]
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,-Wunused-function]
>
> Mark these as __maybe_unused.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused
@ 2020-05-27 18:33 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2020-05-27 18:33 UTC (permalink / raw)
To: arnd
Cc: nbd, netdev, sean.wang, linux-kernel, bgolaszewski,
linux-mediatek, john, matthias.bgg, kuba, Mark-MC.Lee,
linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 27 May 2020 15:34:45 +0200
> Without CONFIG_PM, the compiler warns about two unused functions:
>
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function]
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,-Wunused-function]
>
> Mark these as __maybe_unused.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] [net-next] mtk-star-emac: mark PM functions as __maybe_unused
@ 2020-05-27 18:33 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2020-05-27 18:33 UTC (permalink / raw)
To: arnd
Cc: nbd, netdev, sean.wang, linux-kernel, bgolaszewski,
linux-mediatek, john, matthias.bgg, kuba, Mark-MC.Lee,
linux-arm-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 27 May 2020 15:34:45 +0200
> Without CONFIG_PM, the compiler warns about two unused functions:
>
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1472:12: error: unused function 'mtk_star_suspend' [-Werror,-Wunused-function]
> drivers/net/ethernet/mediatek/mtk_star_emac.c:1488:12: error: unused function 'mtk_star_resume' [-Werror,-Wunused-function]
>
> Mark these as __maybe_unused.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread