From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
kuba@kernel.org, tglx@linutronix.de,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] bridge: multicast: work around clang bug
Date: Wed, 27 May 2020 11:35:24 -0700 (PDT) [thread overview]
Message-ID: <20200527.113524.946608619523725892.davem@davemloft.net> (raw)
In-Reply-To: <20200527135124.1082844-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 27 May 2020 15:51:13 +0200
> Clang-10 and clang-11 run into a corner case of the register
> allocator on 32-bit ARM, leading to excessive stack usage from
> register spilling:
>
> net/bridge/br_multicast.c:2422:6: error: stack frame size of 1472 bytes in function 'br_multicast_get_stats' [-Werror,-Wframe-larger-than=]
>
> Work around this by marking one of the internal functions as
> noinline_for_stack.
>
> Link: https://bugs.llvm.org/show_bug.cgi?id=45802#c9
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: nikolay@cumulusnetworks.com, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
kuba@kernel.org, tglx@linutronix.de
Subject: Re: [Bridge] [PATCH] bridge: multicast: work around clang bug
Date: Wed, 27 May 2020 11:35:24 -0700 (PDT) [thread overview]
Message-ID: <20200527.113524.946608619523725892.davem@davemloft.net> (raw)
In-Reply-To: <20200527135124.1082844-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 27 May 2020 15:51:13 +0200
> Clang-10 and clang-11 run into a corner case of the register
> allocator on 32-bit ARM, leading to excessive stack usage from
> register spilling:
>
> net/bridge/br_multicast.c:2422:6: error: stack frame size of 1472 bytes in function 'br_multicast_get_stats' [-Werror,-Wframe-larger-than=]
>
> Work around this by marking one of the internal functions as
> noinline_for_stack.
>
> Link: https://bugs.llvm.org/show_bug.cgi?id=45802#c9
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
next prev parent reply other threads:[~2020-05-27 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:51 [PATCH] bridge: multicast: work around clang bug Arnd Bergmann
2020-05-27 13:51 ` [Bridge] " Arnd Bergmann
2020-05-27 18:35 ` David Miller [this message]
2020-05-27 18:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527.113524.946608619523725892.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=bridge@lists.linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.