[PATCH] drm/amdgpu: Improve the MTYPE comments

[PATCH] drm/amdgpu: Improve the MTYPE comments

[Yong Zhao]

Use words insteads of acronym for better understanding.

Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>
---
 include/uapi/drm/amdgpu_drm.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index d65f9b4ba05c..0072ddb59747 100644
--- a/include/uapi/drm/amdgpu_drm.h
+++ b/include/uapi/drm/amdgpu_drm.h
@@ -564,15 +564,15 @@ struct drm_amdgpu_gem_op {
 #define AMDGPU_VM_MTYPE_MASK		(0xf << 5)
 /* Default MTYPE. Pre-AI must use this.  Recommended for newer ASICs. */
 #define AMDGPU_VM_MTYPE_DEFAULT		(0 << 5)
-/* Use NC MTYPE instead of default MTYPE */
+/* Use Non Coherent MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_NC		(1 << 5)
-/* Use WC MTYPE instead of default MTYPE */
+/* Use Write Combine MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_WC		(2 << 5)
-/* Use CC MTYPE instead of default MTYPE */
+/* Use Cache Coherent MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_CC		(3 << 5)
-/* Use UC MTYPE instead of default MTYPE */
+/* Use UnCached MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_UC		(4 << 5)
-/* Use RW MTYPE instead of default MTYPE */
+/* Use Read Write MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_RW		(5 << 5)
 
 struct drm_amdgpu_gem_va {
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: Improve the MTYPE comments

[Deucher, Alexander]

[-- Attachment #1.1: Type: text/plain, Size: 2283 bytes --]

[AMD Public Use]

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Yong Zhao <Yong.Zhao@amd.com>
Sent: Tuesday, May 26, 2020 8:57 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Zhao, Yong <Yong.Zhao@amd.com>
Subject: [PATCH] drm/amdgpu: Improve the MTYPE comments

Use words insteads of acronym for better understanding.

Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>
---
 include/uapi/drm/amdgpu_drm.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index d65f9b4ba05c..0072ddb59747 100644
--- a/include/uapi/drm/amdgpu_drm.h
+++ b/include/uapi/drm/amdgpu_drm.h
@@ -564,15 +564,15 @@ struct drm_amdgpu_gem_op {
 #define AMDGPU_VM_MTYPE_MASK            (0xf << 5)
 /* Default MTYPE. Pre-AI must use this.  Recommended for newer ASICs. */
 #define AMDGPU_VM_MTYPE_DEFAULT         (0 << 5)
-/* Use NC MTYPE instead of default MTYPE */
+/* Use Non Coherent MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_NC              (1 << 5)
-/* Use WC MTYPE instead of default MTYPE */
+/* Use Write Combine MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_WC              (2 << 5)
-/* Use CC MTYPE instead of default MTYPE */
+/* Use Cache Coherent MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_CC              (3 << 5)
-/* Use UC MTYPE instead of default MTYPE */
+/* Use UnCached MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_UC              (4 << 5)
-/* Use RW MTYPE instead of default MTYPE */
+/* Use Read Write MTYPE instead of default MTYPE */
 #define AMDGPU_VM_MTYPE_RW              (5 << 5)

 struct drm_amdgpu_gem_va {
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7C03cfa3ceeaba4d63650c08d801d8fd40%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637261378796371099&amp;sdata=kxt8S5LusNmcfRDbv9vgxYlMjPoaA6C3AJIHkXTOq5A%3D&amp;reserved=0

[-- Attachment #1.2: Type: text/html, Size: 4265 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: Improve the MTYPE comments

[Christian König]

Am 27.05.20 um 02:57 schrieb Yong Zhao:
> Use words insteads of acronym for better understanding.
>
> Signed-off-by: Yong Zhao <Yong.Zhao@amd.com>

Good idea, Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   include/uapi/drm/amdgpu_drm.h | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
> index d65f9b4ba05c..0072ddb59747 100644
> --- a/include/uapi/drm/amdgpu_drm.h
> +++ b/include/uapi/drm/amdgpu_drm.h
> @@ -564,15 +564,15 @@ struct drm_amdgpu_gem_op {
>   #define AMDGPU_VM_MTYPE_MASK		(0xf << 5)
>   /* Default MTYPE. Pre-AI must use this.  Recommended for newer ASICs. */
>   #define AMDGPU_VM_MTYPE_DEFAULT		(0 << 5)
> -/* Use NC MTYPE instead of default MTYPE */
> +/* Use Non Coherent MTYPE instead of default MTYPE */
>   #define AMDGPU_VM_MTYPE_NC		(1 << 5)
> -/* Use WC MTYPE instead of default MTYPE */
> +/* Use Write Combine MTYPE instead of default MTYPE */
>   #define AMDGPU_VM_MTYPE_WC		(2 << 5)
> -/* Use CC MTYPE instead of default MTYPE */
> +/* Use Cache Coherent MTYPE instead of default MTYPE */
>   #define AMDGPU_VM_MTYPE_CC		(3 << 5)
> -/* Use UC MTYPE instead of default MTYPE */
> +/* Use UnCached MTYPE instead of default MTYPE */
>   #define AMDGPU_VM_MTYPE_UC		(4 << 5)
> -/* Use RW MTYPE instead of default MTYPE */
> +/* Use Read Write MTYPE instead of default MTYPE */
>   #define AMDGPU_VM_MTYPE_RW		(5 << 5)
>   
>   struct drm_amdgpu_gem_va {

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx