* linux-next build error (8) @ 2020-03-18 16:57 syzbot 2020-03-18 20:54 ` Dmitry Vyukov [not found] ` <3e1a0d59-4959-6250-9f81-3d6f75687c73@I-love.SAKURA.ne.jp> 0 siblings, 2 replies; 25+ messages in thread From: syzbot @ 2020-03-18 16:57 UTC (permalink / raw) To: linux-kernel, syzkaller-bugs Hello, syzbot found the following crash on: HEAD commit: 47780d78 Add linux-next specific files for 20200318 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 compiler: gcc (GCC) 9.0.0 20181231 (experimental) Unfortunately, I don't have any reproducer for this crash yet. IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-18 16:57 linux-next build error (8) syzbot @ 2020-03-18 20:54 ` Dmitry Vyukov 2020-03-18 21:41 ` Paul E. McKenney [not found] ` <3e1a0d59-4959-6250-9f81-3d6f75687c73@I-love.SAKURA.ne.jp> 1 sibling, 1 reply; 25+ messages in thread From: Dmitry Vyukov @ 2020-03-18 20:54 UTC (permalink / raw) To: syzbot, Paul E. McKenney, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu Cc: LKML, syzkaller-bugs On Wed, Mar 18, 2020 at 5:57 PM syzbot <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit: 47780d78 Add linux-next specific files for 20200318 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > Unfortunately, I don't have any reproducer for this crash yet. > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > > kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? +rcu maintainers > --- > This bug is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this bug report. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-18 20:54 ` Dmitry Vyukov @ 2020-03-18 21:41 ` Paul E. McKenney 2020-03-19 7:13 ` Dmitry Vyukov 0 siblings, 1 reply; 25+ messages in thread From: Paul E. McKenney @ 2020-03-18 21:41 UTC (permalink / raw) To: Dmitry Vyukov Cc: syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: > On Wed, Mar 18, 2020 at 5:57 PM syzbot > <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit: 47780d78 Add linux-next specific files for 20200318 > > git tree: linux-next > > console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > > dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > > > > kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? > > +rcu maintainers The kbuild test robot beat you to it, and apologies for the hassle. Fixed in -rcu on current "dev" branch. Thanx, Paul > > --- > > This bug is generated by a bot. It may contain errors. > > See https://goo.gl/tpsmEJ for more information about syzbot. > > syzbot engineers can be reached at syzkaller@googlegroups.com. > > > > syzbot will keep track of this bug report. See: > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-18 21:41 ` Paul E. McKenney @ 2020-03-19 7:13 ` Dmitry Vyukov 2020-03-19 15:04 ` Paul E. McKenney 2020-03-20 13:08 ` Dan Carpenter 0 siblings, 2 replies; 25+ messages in thread From: Dmitry Vyukov @ 2020-03-19 7:13 UTC (permalink / raw) To: Paul E. McKenney Cc: syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On Wed, Mar 18, 2020 at 10:41 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: > > On Wed, Mar 18, 2020 at 5:57 PM syzbot > > <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > > > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit: 47780d78 Add linux-next specific files for 20200318 > > > git tree: linux-next > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > > > dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > > > > > > kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? > > > > +rcu maintainers > > The kbuild test robot beat you to it, and apologies for the hassle. > Fixed in -rcu on current "dev" branch. If the kernel dev process would only have a way to avoid dups from all test systems... Now we need to spend time and deal with it. What has fixed it? ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-19 7:13 ` Dmitry Vyukov @ 2020-03-19 15:04 ` Paul E. McKenney 2020-03-20 15:38 ` Dmitry Vyukov 2020-03-20 13:08 ` Dan Carpenter 1 sibling, 1 reply; 25+ messages in thread From: Paul E. McKenney @ 2020-03-19 15:04 UTC (permalink / raw) To: Dmitry Vyukov Cc: syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On Thu, Mar 19, 2020 at 08:13:35AM +0100, Dmitry Vyukov wrote: > On Wed, Mar 18, 2020 at 10:41 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > > > On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: > > > On Wed, Mar 18, 2020 at 5:57 PM syzbot > > > <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > > > > > > > > Hello, > > > > > > > > syzbot found the following crash on: > > > > > > > > HEAD commit: 47780d78 Add linux-next specific files for 20200318 > > > > git tree: linux-next > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > > > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > > Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > > > > > > > > kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? > > > > > > +rcu maintainers > > > > The kbuild test robot beat you to it, and apologies for the hassle. > > Fixed in -rcu on current "dev" branch. > > If the kernel dev process would only have a way to avoid dups from all > test systems... I do significant testing before pushing to -next, but triggering this one requires a combination of Kconfig options that are incompatible with rcutorture. :-/ I suppose one strategy would be to give kbuild test robot some time before passing to -next, but they seem to sometimes get too far behind for me to be willing to wait that long. So my current approach is to push my "dev" branch, run moderate rcutorture testing (three hours per scenario other than TREE10, which gets only one hour), and if that passes, push to -next. I suppose that I could push to -next only commits that are at least three days old or some such. But I get in trouble pushing to -next too slowly as often as I get in trouble pushing too quickly, so I suspect that my current approach is in roughly the right place. > Now we need to spend time and deal with it. What has fixed it? It is fixed by commit c6ef38e4d595 ("rcu-tasks: Add RCU tasks to rcutorture writer stall output") and some of its predecessors. Perhaps more useful to you, this commit is included in next-20200319 from the -next tree. ;-) Thanx, Paul ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-19 15:04 ` Paul E. McKenney @ 2020-03-20 15:38 ` Dmitry Vyukov 2020-03-20 16:26 ` Paul E. McKenney 0 siblings, 1 reply; 25+ messages in thread From: Dmitry Vyukov @ 2020-03-20 15:38 UTC (permalink / raw) To: Paul E. McKenney Cc: syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On Thu, Mar 19, 2020 at 4:04 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > On Thu, Mar 19, 2020 at 08:13:35AM +0100, Dmitry Vyukov wrote: > > On Wed, Mar 18, 2020 at 10:41 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > > > > > On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: > > > > On Wed, Mar 18, 2020 at 5:57 PM syzbot > > > > <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > > > > > > > > > > Hello, > > > > > > > > > > syzbot found the following crash on: > > > > > > > > > > HEAD commit: 47780d78 Add linux-next specific files for 20200318 > > > > > git tree: linux-next > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > > > > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > > > > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > > > Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > > > > > > > > > > kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? > > > > > > > > +rcu maintainers > > > > > > The kbuild test robot beat you to it, and apologies for the hassle. > > > Fixed in -rcu on current "dev" branch. > > > > If the kernel dev process would only have a way to avoid dups from all > > test systems... > > I do significant testing before pushing to -next, but triggering this > one requires a combination of Kconfig options that are incompatible > with rcutorture. :-/ > > I suppose one strategy would be to give kbuild test robot some time before > passing to -next, but they seem to sometimes get too far behind for me to > be willing to wait that long. So my current approach is to push my "dev" > branch, run moderate rcutorture testing (three hours per scenario other > than TREE10, which gets only one hour), and if that passes, push to -next. > > I suppose that I could push to -next only commits that are at least three > days old or some such. But I get in trouble pushing to -next too slowly > as often as I get in trouble pushing too quickly, so I suspect that my > current approach is in roughly the right place. > > > Now we need to spend time and deal with it. What has fixed it? > > It is fixed by commit c6ef38e4d595 ("rcu-tasks: Add RCU tasks to > rcutorture writer stall output") and some of its predecessors. > > Perhaps more useful to you, this commit is included in next-20200319 > from the -next tree. ;-) Let's tell syzbot about the fix: #syz fix: rcu-tasks: Add RCU tasks to rcutorture writer stall output I think what you are doing is the best possible option in the current situation. I don't think requiring all human maintainers to do more manual repetitive work, which is not well defined and even without a way to really require something from them is scalable nor reliable nor the right approach. We would consume something like LKGR [1] if it existed for the kernel. But it would require tighter integration of testing systems with kernel dev processes, or of course throwing more manual labor at it to track all uncoordinated testing systems and publishing LKGR tags. [1] https://chromium.googlesource.com/chromiumos/docs/+/master/glossary.md ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-20 15:38 ` Dmitry Vyukov @ 2020-03-20 16:26 ` Paul E. McKenney 2020-03-20 16:34 ` Randy Dunlap 0 siblings, 1 reply; 25+ messages in thread From: Paul E. McKenney @ 2020-03-20 16:26 UTC (permalink / raw) To: Dmitry Vyukov Cc: syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On Fri, Mar 20, 2020 at 04:38:54PM +0100, Dmitry Vyukov wrote: > On Thu, Mar 19, 2020 at 4:04 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > > > On Thu, Mar 19, 2020 at 08:13:35AM +0100, Dmitry Vyukov wrote: > > > On Wed, Mar 18, 2020 at 10:41 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > > > > > > > On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: > > > > > On Wed, Mar 18, 2020 at 5:57 PM syzbot > > > > > <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > > > > > > > > > > > > Hello, > > > > > > > > > > > > syzbot found the following crash on: > > > > > > > > > > > > HEAD commit: 47780d78 Add linux-next specific files for 20200318 > > > > > > git tree: linux-next > > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > > > > > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > > > > > > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > > > > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > > > > Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > > > > > > > > > > > > kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? > > > > > > > > > > +rcu maintainers > > > > > > > > The kbuild test robot beat you to it, and apologies for the hassle. > > > > Fixed in -rcu on current "dev" branch. > > > > > > If the kernel dev process would only have a way to avoid dups from all > > > test systems... > > > > I do significant testing before pushing to -next, but triggering this > > one requires a combination of Kconfig options that are incompatible > > with rcutorture. :-/ > > > > I suppose one strategy would be to give kbuild test robot some time before > > passing to -next, but they seem to sometimes get too far behind for me to > > be willing to wait that long. So my current approach is to push my "dev" > > branch, run moderate rcutorture testing (three hours per scenario other > > than TREE10, which gets only one hour), and if that passes, push to -next. > > > > I suppose that I could push to -next only commits that are at least three > > days old or some such. But I get in trouble pushing to -next too slowly > > as often as I get in trouble pushing too quickly, so I suspect that my > > current approach is in roughly the right place. > > > > > Now we need to spend time and deal with it. What has fixed it? > > > > It is fixed by commit c6ef38e4d595 ("rcu-tasks: Add RCU tasks to > > rcutorture writer stall output") and some of its predecessors. > > > > Perhaps more useful to you, this commit is included in next-20200319 > > from the -next tree. ;-) > > Let's tell syzbot about the fix: > > #syz fix: rcu-tasks: Add RCU tasks to rcutorture writer stall output > > I think what you are doing is the best possible option in the current situation. > I don't think requiring all human maintainers to do more manual > repetitive work, which is not well defined and even without a way to > really require something from them is scalable nor reliable nor the > right approach. Thank you, and I do greatly appreciate the automation! > We would consume something like LKGR [1] if it existed for the kernel. > But it would require tighter integration of testing systems with > kernel dev processes, or of course throwing more manual labor at it to > track all uncoordinated testing systems and publishing LKGR tags. > > [1] https://chromium.googlesource.com/chromiumos/docs/+/master/glossary.md At my end, it is pretty quick and easy to detect duplicate notifications of the same bug, so the current situation isn't causing me undue distress. Thanx, Paul ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-20 16:26 ` Paul E. McKenney @ 2020-03-20 16:34 ` Randy Dunlap 2020-03-20 17:04 ` Paul E. McKenney 0 siblings, 1 reply; 25+ messages in thread From: Randy Dunlap @ 2020-03-20 16:34 UTC (permalink / raw) To: paulmck, Dmitry Vyukov Cc: syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On 3/20/20 9:26 AM, Paul E. McKenney wrote: > On Fri, Mar 20, 2020 at 04:38:54PM +0100, Dmitry Vyukov wrote: >> On Thu, Mar 19, 2020 at 4:04 PM Paul E. McKenney <paulmck@kernel.org> wrote: >>> >>> On Thu, Mar 19, 2020 at 08:13:35AM +0100, Dmitry Vyukov wrote: >>>> On Wed, Mar 18, 2020 at 10:41 PM Paul E. McKenney <paulmck@kernel.org> wrote: >>>>> >>>>> On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: >>>>>> On Wed, Mar 18, 2020 at 5:57 PM syzbot >>>>>> <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: >>>>>>> >>>>>>> Hello, >>>>>>> >>>>>>> syzbot found the following crash on: >>>>>>> >>>>>>> HEAD commit: 47780d78 Add linux-next specific files for 20200318 >>>>>>> git tree: linux-next >>>>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 >>>>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a >>>>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 >>>>>>> compiler: gcc (GCC) 9.0.0 20181231 (experimental) >>>>>>> >>>>>>> Unfortunately, I don't have any reproducer for this crash yet. >>>>>>> >>>>>>> IMPORTANT: if you fix the bug, please add the following tag to the commit: >>>>>>> Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com >>>>>>> >>>>>>> kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? >>>>>> >>>>>> +rcu maintainers >>>>> >>>>> The kbuild test robot beat you to it, and apologies for the hassle. >>>>> Fixed in -rcu on current "dev" branch. >>>> >>>> If the kernel dev process would only have a way to avoid dups from all >>>> test systems... >>> >>> I do significant testing before pushing to -next, but triggering this >>> one requires a combination of Kconfig options that are incompatible >>> with rcutorture. :-/ >>> >>> I suppose one strategy would be to give kbuild test robot some time before >>> passing to -next, but they seem to sometimes get too far behind for me to >>> be willing to wait that long. So my current approach is to push my "dev" >>> branch, run moderate rcutorture testing (three hours per scenario other >>> than TREE10, which gets only one hour), and if that passes, push to -next. >>> >>> I suppose that I could push to -next only commits that are at least three >>> days old or some such. But I get in trouble pushing to -next too slowly >>> as often as I get in trouble pushing too quickly, so I suspect that my >>> current approach is in roughly the right place. >>> >>>> Now we need to spend time and deal with it. What has fixed it? >>> >>> It is fixed by commit c6ef38e4d595 ("rcu-tasks: Add RCU tasks to >>> rcutorture writer stall output") and some of its predecessors. >>> >>> Perhaps more useful to you, this commit is included in next-20200319 >>> from the -next tree. ;-) >> >> Let's tell syzbot about the fix: >> >> #syz fix: rcu-tasks: Add RCU tasks to rcutorture writer stall output >> >> I think what you are doing is the best possible option in the current situation. >> I don't think requiring all human maintainers to do more manual >> repetitive work, which is not well defined and even without a way to >> really require something from them is scalable nor reliable nor the >> right approach. > > Thank you, and I do greatly appreciate the automation! > >> We would consume something like LKGR [1] if it existed for the kernel. >> But it would require tighter integration of testing systems with >> kernel dev processes, or of course throwing more manual labor at it to >> track all uncoordinated testing systems and publishing LKGR tags. >> >> [1] https://chromium.googlesource.com/chromiumos/docs/+/master/glossary.md > > At my end, it is pretty quick and easy to detect duplicate notifications > of the same bug, so the current situation isn't causing me undue distress. Yeah, I saw the same build error and did-not-report it since it was already reported. :) -- ~Randy ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-20 16:34 ` Randy Dunlap @ 2020-03-20 17:04 ` Paul E. McKenney 0 siblings, 0 replies; 25+ messages in thread From: Paul E. McKenney @ 2020-03-20 17:04 UTC (permalink / raw) To: Randy Dunlap Cc: Dmitry Vyukov, syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On Fri, Mar 20, 2020 at 09:34:13AM -0700, Randy Dunlap wrote: > On 3/20/20 9:26 AM, Paul E. McKenney wrote: > > On Fri, Mar 20, 2020 at 04:38:54PM +0100, Dmitry Vyukov wrote: > >> On Thu, Mar 19, 2020 at 4:04 PM Paul E. McKenney <paulmck@kernel.org> wrote: > >>> > >>> On Thu, Mar 19, 2020 at 08:13:35AM +0100, Dmitry Vyukov wrote: > >>>> On Wed, Mar 18, 2020 at 10:41 PM Paul E. McKenney <paulmck@kernel.org> wrote: > >>>>> > >>>>> On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: > >>>>>> On Wed, Mar 18, 2020 at 5:57 PM syzbot > >>>>>> <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > >>>>>>> > >>>>>>> Hello, > >>>>>>> > >>>>>>> syzbot found the following crash on: > >>>>>>> > >>>>>>> HEAD commit: 47780d78 Add linux-next specific files for 20200318 > >>>>>>> git tree: linux-next > >>>>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > >>>>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > >>>>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > >>>>>>> compiler: gcc (GCC) 9.0.0 20181231 (experimental) > >>>>>>> > >>>>>>> Unfortunately, I don't have any reproducer for this crash yet. > >>>>>>> > >>>>>>> IMPORTANT: if you fix the bug, please add the following tag to the commit: > >>>>>>> Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > >>>>>>> > >>>>>>> kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? > >>>>>> > >>>>>> +rcu maintainers > >>>>> > >>>>> The kbuild test robot beat you to it, and apologies for the hassle. > >>>>> Fixed in -rcu on current "dev" branch. > >>>> > >>>> If the kernel dev process would only have a way to avoid dups from all > >>>> test systems... > >>> > >>> I do significant testing before pushing to -next, but triggering this > >>> one requires a combination of Kconfig options that are incompatible > >>> with rcutorture. :-/ > >>> > >>> I suppose one strategy would be to give kbuild test robot some time before > >>> passing to -next, but they seem to sometimes get too far behind for me to > >>> be willing to wait that long. So my current approach is to push my "dev" > >>> branch, run moderate rcutorture testing (three hours per scenario other > >>> than TREE10, which gets only one hour), and if that passes, push to -next. > >>> > >>> I suppose that I could push to -next only commits that are at least three > >>> days old or some such. But I get in trouble pushing to -next too slowly > >>> as often as I get in trouble pushing too quickly, so I suspect that my > >>> current approach is in roughly the right place. > >>> > >>>> Now we need to spend time and deal with it. What has fixed it? > >>> > >>> It is fixed by commit c6ef38e4d595 ("rcu-tasks: Add RCU tasks to > >>> rcutorture writer stall output") and some of its predecessors. > >>> > >>> Perhaps more useful to you, this commit is included in next-20200319 > >>> from the -next tree. ;-) > >> > >> Let's tell syzbot about the fix: > >> > >> #syz fix: rcu-tasks: Add RCU tasks to rcutorture writer stall output > >> > >> I think what you are doing is the best possible option in the current situation. > >> I don't think requiring all human maintainers to do more manual > >> repetitive work, which is not well defined and even without a way to > >> really require something from them is scalable nor reliable nor the > >> right approach. > > > > Thank you, and I do greatly appreciate the automation! > > > >> We would consume something like LKGR [1] if it existed for the kernel. > >> But it would require tighter integration of testing systems with > >> kernel dev processes, or of course throwing more manual labor at it to > >> track all uncoordinated testing systems and publishing LKGR tags. > >> > >> [1] https://chromium.googlesource.com/chromiumos/docs/+/master/glossary.md > > > > At my end, it is pretty quick and easy to detect duplicate notifications > > of the same bug, so the current situation isn't causing me undue distress. > > Yeah, I saw the same build error and did-not-report it since it was > already reported. :) Much appreciated! ;-) Thanx, Paul ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-19 7:13 ` Dmitry Vyukov 2020-03-19 15:04 ` Paul E. McKenney @ 2020-03-20 13:08 ` Dan Carpenter 2020-03-20 15:42 ` Dmitry Vyukov 1 sibling, 1 reply; 25+ messages in thread From: Dan Carpenter @ 2020-03-20 13:08 UTC (permalink / raw) To: Dmitry Vyukov Cc: Paul E. McKenney, syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On Thu, Mar 19, 2020 at 08:13:35AM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: > On Wed, Mar 18, 2020 at 10:41 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > > > On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: > > > On Wed, Mar 18, 2020 at 5:57 PM syzbot > > > <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > > > > > > > > Hello, > > > > > > > > syzbot found the following crash on: > > > > > > > > HEAD commit: 47780d78 Add linux-next specific files for 20200318 > > > > git tree: linux-next > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > > > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > > Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > > > > > > > > kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? > > > > > > +rcu maintainers > > > > The kbuild test robot beat you to it, and apologies for the hassle. > > Fixed in -rcu on current "dev" branch. > > If the kernel dev process would only have a way to avoid dups from all > test systems... We could make a mailing list for recording it, and then just grep the mailbox for the file and function. Or we could just assume that kbuild is going to find almost all the build errors. regards, dan carpenter ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-03-20 13:08 ` Dan Carpenter @ 2020-03-20 15:42 ` Dmitry Vyukov 0 siblings, 0 replies; 25+ messages in thread From: Dmitry Vyukov @ 2020-03-20 15:42 UTC (permalink / raw) To: Dan Carpenter Cc: Paul E. McKenney, syzbot, Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, rcu, LKML, syzkaller-bugs On Fri, Mar 20, 2020 at 2:11 PM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > On Thu, Mar 19, 2020 at 08:13:35AM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: > > On Wed, Mar 18, 2020 at 10:41 PM Paul E. McKenney <paulmck@kernel.org> wrote: > > > > > > On Wed, Mar 18, 2020 at 09:54:07PM +0100, Dmitry Vyukov wrote: > > > > On Wed, Mar 18, 2020 at 5:57 PM syzbot > > > > <syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com> wrote: > > > > > > > > > > Hello, > > > > > > > > > > syzbot found the following crash on: > > > > > > > > > > HEAD commit: 47780d78 Add linux-next specific files for 20200318 > > > > > git tree: linux-next > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14228745e00000 > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=b68b7b89ad96c62a > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 > > > > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > > > > > > > > > Unfortunately, I don't have any reproducer for this crash yet. > > > > > > > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > > > > Reported-by: syzbot+792dec47d693ccdc05a0@syzkaller.appspotmail.com > > > > > > > > > > kernel/rcu/tasks.h:1070:37: error: 'rcu_tasks_rude' undeclared (first use in this function); did you mean 'rcu_tasks_qs'? > > > > > > > > +rcu maintainers > > > > > > The kbuild test robot beat you to it, and apologies for the hassle. > > > Fixed in -rcu on current "dev" branch. > > > > If the kernel dev process would only have a way to avoid dups from all > > test systems... > > We could make a mailing list for recording it, and then just grep the > mailbox for the file and function. As far as I understand Paul was already aware of the breakage and both reports. Also how do we make all kernel testing out there to respect this new list?.... > Or we could just assume that kbuild is going to find almost all the > build errors. Paul mentioned that they don't sometimes ("but they seem to sometimes get too far behind for me to be willing to wait that long"). Lots of people mentioned this on the last LPC as well. It's not completely transparent and not part of the kernel project to rely on it (how do we add new configs? how do we urgently repair it? etc). ^ permalink raw reply [flat|nested] 25+ messages in thread
[parent not found: <3e1a0d59-4959-6250-9f81-3d6f75687c73@I-love.SAKURA.ne.jp>]
* Re: linux-next build error (8) [not found] ` <3e1a0d59-4959-6250-9f81-3d6f75687c73@I-love.SAKURA.ne.jp> @ 2020-05-26 12:09 ` Dmitry Vyukov 2020-05-26 12:19 ` Qian Cai 2020-05-26 23:33 ` Stephen Rothwell 0 siblings, 2 replies; 25+ messages in thread From: Dmitry Vyukov @ 2020-05-26 12:09 UTC (permalink / raw) To: Tetsuo Handa, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs Cc: syzbot, syzkaller-bugs On Fri, May 22, 2020 at 6:29 AM Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote: > > Hello. > > This report is already reporting next problem. Since the location seems to be > different, this might be caused by OOM due to too much parallel compilation. > Maybe syzbot can detect "gcc: fatal error: Killed signal terminated program cc1" > sequence and retry with reduced "make -j$NUM" settings. > > gcc: fatal error: Killed signal terminated program cc1 > compilation terminated. > scripts/Makefile.build:272: recipe for target 'fs/xfs/libxfs/xfs_btree.o' failed > make[2]: *** [fs/xfs/libxfs/xfs_btree.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... +linux-next and XFS maintainers Interesting. This seems to repeat reliably and this machine is not known for any misbehavior and it always happens on all XFS files. Did XFS get something that crashes gcc's? CC drivers/hid/hid-uclogic-rdesc.o CC drivers/hid/hid-uclogic-params.o CC drivers/hid/hid-led.o CC drivers/hid/hid-zpff.o CC drivers/hid/hid-zydacron.o CC drivers/hid/wacom_wac.o CC drivers/hid/wacom_sys.o CC drivers/hid/hid-waltop.o CC drivers/hid/hid-wiimote-core.o CC drivers/hid/hid-wiimote-debug.o CC drivers/hid/hid-wiimote-modules.o CC drivers/hid/usbhid/hid-core.o CC drivers/hid/usbhid/hid-pidff.o CC drivers/hid/usbhid/hiddev.o AR drivers/gpu/drm/i915/built-in.a AR drivers/gpu/drm/built-in.a AR drivers/gpu/built-in.a gcc: fatal error: Killed signal terminated program cc1 compilation terminated. scripts/Makefile.build:272: recipe for target 'fs/xfs/xfs_file.o' failed make[2]: *** [fs/xfs/xfs_file.o] Error 1 AR drivers/hid/usbhid/built-in.a gcc: fatal error: Killed signal terminated program cc1 compilation terminated. scripts/Makefile.build:272: recipe for target 'fs/xfs/xfs_fsmap.o' failed make[2]: *** [fs/xfs/xfs_fsmap.o] Error 1 AR drivers/hid/built-in.a AR drivers/built-in.a gcc: fatal error: Killed signal terminated program cc1 compilation terminated. scripts/Makefile.build:272: recipe for target 'fs/xfs/xfs_filestream.o' failed make[2]: *** [fs/xfs/xfs_filestream.o] Error 1 gcc: fatal error: Killed signal terminated program cc1 compilation terminated. scripts/Makefile.build:272: recipe for target 'fs/xfs/xfs_icache.o' failed make[2]: *** [fs/xfs/xfs_icache.o] Error 1 AR fs/ocfs2/built-in.a gcc: fatal error: Killed signal terminated program cc1 compilation terminated. scripts/Makefile.build:272: recipe for target 'fs/xfs/xfs_iops.o' failed make[2]: *** [fs/xfs/xfs_iops.o] Error 1 gcc: fatal error: Killed signal terminated program cc1 compilation terminated. scripts/Makefile.build:272: recipe for target 'fs/xfs/xfs_mount.o' failed make[2]: *** [fs/xfs/xfs_mount.o] Error 1 gcc: fatal error: Killed signal terminated program cc1 compilation terminated. scripts/Makefile.build:272: recipe for target 'fs/xfs/xfs_inode.o' failed make[2]: *** [fs/xfs/xfs_inode.o] Error 1 scripts/Makefile.build:494: recipe for target 'fs/xfs' failed make[1]: *** [fs/xfs] Error 2 Makefile:1736: recipe for target 'fs' failed make: *** [fs] Error 2 ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 12:09 ` Dmitry Vyukov @ 2020-05-26 12:19 ` Qian Cai 2020-05-26 12:28 ` Dmitry Vyukov 2020-05-26 23:33 ` Stephen Rothwell 1 sibling, 1 reply; 25+ messages in thread From: Qian Cai @ 2020-05-26 12:19 UTC (permalink / raw) To: Dmitry Vyukov Cc: Tetsuo Handa, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs > On May 26, 2020, at 8:09 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > > +linux-next and XFS maintainers > > Interesting. This seems to repeat reliably and this machine is not > known for any misbehavior and it always happens on all XFS files. > Did XFS get something that crashes gcc's? Are you still seeing this in today’s linux-next? There was an issue had already been sorted out. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 12:19 ` Qian Cai @ 2020-05-26 12:28 ` Dmitry Vyukov 2020-05-26 12:41 ` Qian Cai 0 siblings, 1 reply; 25+ messages in thread From: Dmitry Vyukov @ 2020-05-26 12:28 UTC (permalink / raw) To: Qian Cai Cc: Tetsuo Handa, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs On Tue, May 26, 2020 at 2:19 PM Qian Cai <cai@lca.pw> wrote: > > On May 26, 2020, at 8:09 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > > > > +linux-next and XFS maintainers > > > > Interesting. This seems to repeat reliably and this machine is not > > known for any misbehavior and it always happens on all XFS files. > > Did XFS get something that crashes gcc's? > > Are you still seeing this in today’s linux-next? There was an issue had already been sorted out. syzbot seen this on these commits/dates: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 Crashes (4): Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro ci-upstream-linux-next-kasan-gce-root 2020/05/22 01:23 linux-next e8f32747 5afa2ddd .config log report ci-upstream-linux-next-kasan-gce-root 2020/05/21 15:01 linux-next e8f32747 1f30020f .config log report ci-upstream-linux-next-kasan-gce-root 2020/05/19 18:24 linux-next fb57b1fa 6d882fd2 .config log report ci-upstream-linux-next-kasan-gce-root 2020/03/18 16:19 linux-next 47780d78 0a96a13c .config log report ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 12:28 ` Dmitry Vyukov @ 2020-05-26 12:41 ` Qian Cai 2020-05-26 12:44 ` Tetsuo Handa 2020-05-26 13:26 ` Dmitry Vyukov 0 siblings, 2 replies; 25+ messages in thread From: Qian Cai @ 2020-05-26 12:41 UTC (permalink / raw) To: Dmitry Vyukov Cc: Tetsuo Handa, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs > On May 26, 2020, at 8:28 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > > Crashes (4): > Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro > ci-upstream-linux-next-kasan-gce-root 2020/05/22 01:23 linux-next > e8f32747 5afa2ddd .config log report > ci-upstream-linux-next-kasan-gce-root 2020/05/21 15:01 linux-next > e8f32747 1f30020f .config log report > ci-upstream-linux-next-kasan-gce-root 2020/05/19 18:24 linux-next > fb57b1fa 6d882fd2 .config log report > ci-upstream-linux-next-kasan-gce-root 2020/03/18 16:19 linux-next > 47780d78 0a96a13c .config log report You’ll probably need to use an known good kernel version. For example, a stock kernel or any of a mainline -rc / GA kernel to compile next-20200526 and then test from there. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 12:41 ` Qian Cai @ 2020-05-26 12:44 ` Tetsuo Handa 2020-05-26 12:50 ` Qian Cai 2020-05-26 13:26 ` Dmitry Vyukov 1 sibling, 1 reply; 25+ messages in thread From: Tetsuo Handa @ 2020-05-26 12:44 UTC (permalink / raw) To: Qian Cai Cc: Dmitry Vyukov, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs On 2020/05/26 21:41, Qian Cai wrote: > > >> On May 26, 2020, at 8:28 AM, Dmitry Vyukov <dvyukov@google.com> wrote: >> >> Crashes (4): >> Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro >> ci-upstream-linux-next-kasan-gce-root 2020/05/22 01:23 linux-next >> e8f32747 5afa2ddd .config log report >> ci-upstream-linux-next-kasan-gce-root 2020/05/21 15:01 linux-next >> e8f32747 1f30020f .config log report >> ci-upstream-linux-next-kasan-gce-root 2020/05/19 18:24 linux-next >> fb57b1fa 6d882fd2 .config log report >> ci-upstream-linux-next-kasan-gce-root 2020/03/18 16:19 linux-next >> 47780d78 0a96a13c .config log report > > You’ll probably need to use an known good kernel version. For example, a stock kernel or any of a mainline -rc / GA kernel to compile next-20200526 and then test from there. > The last occurrence was next-20200521. Do you know the commit which fixed this problem (so that we can confirm the problem was already fixed) ? ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 12:44 ` Tetsuo Handa @ 2020-05-26 12:50 ` Qian Cai 2020-05-26 12:59 ` Tetsuo Handa 0 siblings, 1 reply; 25+ messages in thread From: Qian Cai @ 2020-05-26 12:50 UTC (permalink / raw) To: Tetsuo Handa Cc: Dmitry Vyukov, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs > On May 26, 2020, at 8:45 AM, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote: > > The last occurrence was next-20200521. Do you know the commit which fixed > this problem (so that we can confirm the problem was already fixed) ? Not on top of my head, but I did confirm the issue was fixed since next-20200525. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 12:50 ` Qian Cai @ 2020-05-26 12:59 ` Tetsuo Handa 0 siblings, 0 replies; 25+ messages in thread From: Tetsuo Handa @ 2020-05-26 12:59 UTC (permalink / raw) To: Qian Cai Cc: Dmitry Vyukov, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs On 2020/05/26 21:50, Qian Cai wrote: > > >> On May 26, 2020, at 8:45 AM, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote: >> >> The last occurrence was next-20200521. Do you know the commit which fixed >> this problem (so that we can confirm the problem was already fixed) ? > > Not on top of my head, but I did confirm the issue was fixed since next-20200525. > Then, we can ignore this problem. Thank you. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 12:41 ` Qian Cai 2020-05-26 12:44 ` Tetsuo Handa @ 2020-05-26 13:26 ` Dmitry Vyukov 2020-05-26 13:49 ` Qian Cai 1 sibling, 1 reply; 25+ messages in thread From: Dmitry Vyukov @ 2020-05-26 13:26 UTC (permalink / raw) To: Qian Cai Cc: Tetsuo Handa, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs On Tue, May 26, 2020 at 2:41 PM Qian Cai <cai@lca.pw> wrote: > > > > > On May 26, 2020, at 8:28 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > > > > Crashes (4): > > Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro > > ci-upstream-linux-next-kasan-gce-root 2020/05/22 01:23 linux-next > > e8f32747 5afa2ddd .config log report > > ci-upstream-linux-next-kasan-gce-root 2020/05/21 15:01 linux-next > > e8f32747 1f30020f .config log report > > ci-upstream-linux-next-kasan-gce-root 2020/05/19 18:24 linux-next > > fb57b1fa 6d882fd2 .config log report > > ci-upstream-linux-next-kasan-gce-root 2020/03/18 16:19 linux-next > > 47780d78 0a96a13c .config log report > > You’ll probably need to use an known good kernel version. For example, a stock kernel or any of a mainline -rc / GA kernel to compile next-20200526 and then test from there. People also argued for the opposite -- finding bugs only on rc's is too late. I think Linus also did not want bugs from entering the mainline tree. Ideally, all kernel patches tested on CI for simpler bugs before entering any tree. And then fuzzing finds only harder to hit bugs. syzbot is a really poor CI and it wasn't built to be a one. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 13:26 ` Dmitry Vyukov @ 2020-05-26 13:49 ` Qian Cai 2020-05-26 14:04 ` Dmitry Vyukov 0 siblings, 1 reply; 25+ messages in thread From: Qian Cai @ 2020-05-26 13:49 UTC (permalink / raw) To: Dmitry Vyukov Cc: Tetsuo Handa, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs On Tue, May 26, 2020 at 03:26:40PM +0200, Dmitry Vyukov wrote: > On Tue, May 26, 2020 at 2:41 PM Qian Cai <cai@lca.pw> wrote: > > > > > > > > > On May 26, 2020, at 8:28 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > > > > > > Crashes (4): > > > Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro > > > ci-upstream-linux-next-kasan-gce-root 2020/05/22 01:23 linux-next > > > e8f32747 5afa2ddd .config log report > > > ci-upstream-linux-next-kasan-gce-root 2020/05/21 15:01 linux-next > > > e8f32747 1f30020f .config log report > > > ci-upstream-linux-next-kasan-gce-root 2020/05/19 18:24 linux-next > > > fb57b1fa 6d882fd2 .config log report > > > ci-upstream-linux-next-kasan-gce-root 2020/03/18 16:19 linux-next > > > 47780d78 0a96a13c .config log report > > > > You’ll probably need to use an known good kernel version. For > > example, a stock kernel or any of a mainline -rc / GA kernel to > > compile next-20200526 and then test from there. > > People also argued for the opposite -- finding bugs only on rc's is > too late. I think Linus also did not want bugs from entering the > mainline tree. > > Ideally, all kernel patches tested on CI for simpler bugs before > entering any tree. And then fuzzing finds only harder to hit bugs. > syzbot is a really poor CI and it wasn't built to be a one. I had only suggested it as a way to workaround/confirm this bug which will cause abormal memory usage for compilation workloads. Once you get a working next-0526 kernel, you should be able to use that to compile future -next trees. I would also agree that our maintainers should make the quality bar higher for linux-next commits, so I could get some vacations. ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 13:49 ` Qian Cai @ 2020-05-26 14:04 ` Dmitry Vyukov 0 siblings, 0 replies; 25+ messages in thread From: Dmitry Vyukov @ 2020-05-26 14:04 UTC (permalink / raw) To: Qian Cai Cc: Tetsuo Handa, Linux-Next Mailing List, Stephen Rothwell, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs On Tue, May 26, 2020 at 3:50 PM Qian Cai <cai@lca.pw> wrote: > > > > On May 26, 2020, at 8:28 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > > > > > > > > Crashes (4): > > > > Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro > > > > ci-upstream-linux-next-kasan-gce-root 2020/05/22 01:23 linux-next > > > > e8f32747 5afa2ddd .config log report > > > > ci-upstream-linux-next-kasan-gce-root 2020/05/21 15:01 linux-next > > > > e8f32747 1f30020f .config log report > > > > ci-upstream-linux-next-kasan-gce-root 2020/05/19 18:24 linux-next > > > > fb57b1fa 6d882fd2 .config log report > > > > ci-upstream-linux-next-kasan-gce-root 2020/03/18 16:19 linux-next > > > > 47780d78 0a96a13c .config log report > > > > > > You’ll probably need to use an known good kernel version. For > > > example, a stock kernel or any of a mainline -rc / GA kernel to > > > compile next-20200526 and then test from there. > > > > People also argued for the opposite -- finding bugs only on rc's is > > too late. I think Linus also did not want bugs from entering the > > mainline tree. > > > > Ideally, all kernel patches tested on CI for simpler bugs before > > entering any tree. And then fuzzing finds only harder to hit bugs. > > syzbot is a really poor CI and it wasn't built to be a one. > > I had only suggested it as a way to workaround/confirm this bug which > will cause abormal memory usage for compilation workloads. Once you get > a working next-0526 kernel, you should be able to use that to compile > future -next trees. > > I would also agree that our maintainers should make the quality bar > higher for linux-next commits, so I could get some vacations. :) true ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 12:09 ` Dmitry Vyukov 2020-05-26 12:19 ` Qian Cai @ 2020-05-26 23:33 ` Stephen Rothwell 2020-05-27 5:41 ` Dmitry Vyukov 1 sibling, 1 reply; 25+ messages in thread From: Stephen Rothwell @ 2020-05-26 23:33 UTC (permalink / raw) To: Dmitry Vyukov Cc: Tetsuo Handa, Linux-Next Mailing List, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs [-- Attachment #1: Type: text/plain, Size: 1030 bytes --] Hi Dmitry, On Tue, 26 May 2020 14:09:28 +0200 Dmitry Vyukov <dvyukov@google.com> wrote: > > On Fri, May 22, 2020 at 6:29 AM Tetsuo Handa > <penguin-kernel@i-love.sakura.ne.jp> wrote: > > > > Hello. > > > > This report is already reporting next problem. Since the location seems to be > > different, this might be caused by OOM due to too much parallel compilation. > > Maybe syzbot can detect "gcc: fatal error: Killed signal terminated program cc1" > > sequence and retry with reduced "make -j$NUM" settings. > > > > gcc: fatal error: Killed signal terminated program cc1 > > compilation terminated. > > scripts/Makefile.build:272: recipe for target 'fs/xfs/libxfs/xfs_btree.o' failed > > make[2]: *** [fs/xfs/libxfs/xfs_btree.o] Error 1 > > make[2]: *** Waiting for unfinished jobs.... > > +linux-next and XFS maintainers What version of linux-next is this? There was a problem last week with some changes in the tip tree that caused large memory usage. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-26 23:33 ` Stephen Rothwell @ 2020-05-27 5:41 ` Dmitry Vyukov 2020-05-27 6:25 ` Stephen Rothwell 0 siblings, 1 reply; 25+ messages in thread From: Dmitry Vyukov @ 2020-05-27 5:41 UTC (permalink / raw) To: Stephen Rothwell Cc: Tetsuo Handa, Linux-Next Mailing List, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs On Wed, May 27, 2020 at 1:33 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi Dmitry, > > On Tue, 26 May 2020 14:09:28 +0200 Dmitry Vyukov <dvyukov@google.com> wrote: > > > > On Fri, May 22, 2020 at 6:29 AM Tetsuo Handa > > <penguin-kernel@i-love.sakura.ne.jp> wrote: > > > > > > Hello. > > > > > > This report is already reporting next problem. Since the location seems to be > > > different, this might be caused by OOM due to too much parallel compilation. > > > Maybe syzbot can detect "gcc: fatal error: Killed signal terminated program cc1" > > > sequence and retry with reduced "make -j$NUM" settings. > > > > > > gcc: fatal error: Killed signal terminated program cc1 > > > compilation terminated. > > > scripts/Makefile.build:272: recipe for target 'fs/xfs/libxfs/xfs_btree.o' failed > > > make[2]: *** [fs/xfs/libxfs/xfs_btree.o] Error 1 > > > make[2]: *** Waiting for unfinished jobs.... > > > > +linux-next and XFS maintainers > > What version of linux-next is this? There was a problem last week with > some changes in the tip tree that caused large memory usage. Hi Stephen, Detailed info about each syzbot crash is always available over the dashboard link: https://syzkaller.appspot.com/bug?extid=792dec47d693ccdc05a0 Crashes (4): Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro ci-upstream-linux-next-kasan-gce-root 2020/05/22 01:23 linux-next e8f32747 5afa2ddd .config log report ci-upstream-linux-next-kasan-gce-root 2020/05/21 15:01 linux-next e8f32747 1f30020f .config log report ci-upstream-linux-next-kasan-gce-root 2020/05/19 18:24 linux-next fb57b1fa 6d882fd2 .config log report ci-upstream-linux-next-kasan-gce-root 2020/03/18 16:19 linux-next 47780d78 0a96a13c .config log report ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-27 5:41 ` Dmitry Vyukov @ 2020-05-27 6:25 ` Stephen Rothwell 2020-05-27 6:38 ` Dmitry Vyukov 0 siblings, 1 reply; 25+ messages in thread From: Stephen Rothwell @ 2020-05-27 6:25 UTC (permalink / raw) To: Dmitry Vyukov Cc: Tetsuo Handa, Linux-Next Mailing List, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs [-- Attachment #1: Type: text/plain, Size: 634 bytes --] Hi Dmitry, On Wed, 27 May 2020 07:41:15 +0200 Dmitry Vyukov <dvyukov@google.com> wrote: > > On Wed, May 27, 2020 at 1:33 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > What version of linux-next is this? There was a problem last week with > > some changes in the tip tree that caused large memory usage. > > Hi Stephen, > > Detailed info about each syzbot crash is always available over the > dashboard link: Thanks. As others have said, this has been taken care of - the problematic commits were dropped from next-2020522 and the fixes appeared in next-20200525. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: linux-next build error (8) 2020-05-27 6:25 ` Stephen Rothwell @ 2020-05-27 6:38 ` Dmitry Vyukov 0 siblings, 0 replies; 25+ messages in thread From: Dmitry Vyukov @ 2020-05-27 6:38 UTC (permalink / raw) To: Stephen Rothwell Cc: Tetsuo Handa, Linux-Next Mailing List, Darrick J. Wong, linux-xfs, syzbot, syzkaller-bugs On Wed, May 27, 2020 at 8:25 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi Dmitry, > > On Wed, 27 May 2020 07:41:15 +0200 Dmitry Vyukov <dvyukov@google.com> wrote: > > > > On Wed, May 27, 2020 at 1:33 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > What version of linux-next is this? There was a problem last week with > > > some changes in the tip tree that caused large memory usage. > > > > Hi Stephen, > > > > Detailed info about each syzbot crash is always available over the > > dashboard link: > > Thanks. As others have said, this has been taken care of - the > problematic commits were dropped from next-2020522 and the fixes > appeared in next-20200525. OK, let's close this then, otherwise this is open since March, new failures are piling up, we are not getting notifications about new ones, and it turns into an unuseful mess. #syz invalid ^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2020-05-27 6:38 UTC | newest] Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-18 16:57 linux-next build error (8) syzbot 2020-03-18 20:54 ` Dmitry Vyukov 2020-03-18 21:41 ` Paul E. McKenney 2020-03-19 7:13 ` Dmitry Vyukov 2020-03-19 15:04 ` Paul E. McKenney 2020-03-20 15:38 ` Dmitry Vyukov 2020-03-20 16:26 ` Paul E. McKenney 2020-03-20 16:34 ` Randy Dunlap 2020-03-20 17:04 ` Paul E. McKenney 2020-03-20 13:08 ` Dan Carpenter 2020-03-20 15:42 ` Dmitry Vyukov [not found] ` <3e1a0d59-4959-6250-9f81-3d6f75687c73@I-love.SAKURA.ne.jp> 2020-05-26 12:09 ` Dmitry Vyukov 2020-05-26 12:19 ` Qian Cai 2020-05-26 12:28 ` Dmitry Vyukov 2020-05-26 12:41 ` Qian Cai 2020-05-26 12:44 ` Tetsuo Handa 2020-05-26 12:50 ` Qian Cai 2020-05-26 12:59 ` Tetsuo Handa 2020-05-26 13:26 ` Dmitry Vyukov 2020-05-26 13:49 ` Qian Cai 2020-05-26 14:04 ` Dmitry Vyukov 2020-05-26 23:33 ` Stephen Rothwell 2020-05-27 5:41 ` Dmitry Vyukov 2020-05-27 6:25 ` Stephen Rothwell 2020-05-27 6:38 ` Dmitry Vyukov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.