[mac80211-next:master 2177/2199] net/ethtool/cabletest.c:230:5: sparse: sparse: symbol 'ethnl_act_cable_test_tdr_cfg' was not declared. Should it be static?

[mac80211-next:master 2177/2199] net/ethtool/cabletest.c:230:5: sparse: sparse: symbol 'ethnl_act_cable_test_tdr_cfg' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
head:   119aadf816f5373dc82ca4109d6d5b777e00475b
commit: f2bc8ad31a7f814237bc6301d59296d76505a688 [2177/2199] net: ethtool: Allow PHY cable test TDR data to configured
config: x86_64-randconfig-s022-20200527 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-240-gf0fe1cd9-dirty
        git checkout f2bc8ad31a7f814237bc6301d59296d76505a688
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> net/ethtool/cabletest.c:230:5: sparse: sparse: symbol 'ethnl_act_cable_test_tdr_cfg' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38238 bytes --]

[mac80211-next:master 2177/2199] net/ethtool/cabletest.c:230:5: sparse: sparse: symbol 'ethnl_act_cable_test_tdr_cfg' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
head:   119aadf816f5373dc82ca4109d6d5b777e00475b
commit: f2bc8ad31a7f814237bc6301d59296d76505a688 [2177/2199] net: ethtool: Allow PHY cable test TDR data to configured
config: x86_64-randconfig-s022-20200527 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-240-gf0fe1cd9-dirty
        git checkout f2bc8ad31a7f814237bc6301d59296d76505a688
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> net/ethtool/cabletest.c:230:5: sparse: sparse: symbol 'ethnl_act_cable_test_tdr_cfg' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38238 bytes --]

[RFC PATCH mac80211-next] net: ethtool: ethnl_act_cable_test_tdr_cfg() can be static

[kbuild test robot]

Fixes: f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to configured")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 cabletest.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c
index 9991688d7d1d5..7b7a0456c15ce 100644
--- a/net/ethtool/cabletest.c
+++ b/net/ethtool/cabletest.c
@@ -227,9 +227,9 @@ cable_test_tdr_act_policy[ETHTOOL_A_CABLE_TEST_TDR_MAX + 1] = {
 };
 
 /* CABLE_TEST_TDR_ACT */
-int ethnl_act_cable_test_tdr_cfg(const struct nlattr *nest,
-				 struct genl_info *info,
-				 struct phy_tdr_config *cfg)
+static int ethnl_act_cable_test_tdr_cfg(const struct nlattr *nest,
+					struct genl_info *info,
+					struct phy_tdr_config *cfg)
 {
 	struct nlattr *tb[ETHTOOL_A_CABLE_TEST_TDR_CFG_MAX + 1];
 	int ret;

[RFC PATCH mac80211-next] net: ethtool: ethnl_act_cable_test_tdr_cfg() can be static

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]


Fixes: f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to configured")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 cabletest.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c
index 9991688d7d1d5..7b7a0456c15ce 100644
--- a/net/ethtool/cabletest.c
+++ b/net/ethtool/cabletest.c
@@ -227,9 +227,9 @@ cable_test_tdr_act_policy[ETHTOOL_A_CABLE_TEST_TDR_MAX + 1] = {
 };
 
 /* CABLE_TEST_TDR_ACT */
-int ethnl_act_cable_test_tdr_cfg(const struct nlattr *nest,
-				 struct genl_info *info,
-				 struct phy_tdr_config *cfg)
+static int ethnl_act_cable_test_tdr_cfg(const struct nlattr *nest,
+					struct genl_info *info,
+					struct phy_tdr_config *cfg)
 {
 	struct nlattr *tb[ETHTOOL_A_CABLE_TEST_TDR_CFG_MAX + 1];
 	int ret;