From: Rob Herring <robh@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v2] of: Fix a refcounting bug in __of_attach_node_sysfs()
Date: Wed, 27 May 2020 12:40:40 -0600 [thread overview]
Message-ID: <20200527184040.GA2529559@bogus> (raw)
In-Reply-To: <20200520120414.GE172354@mwanda>
On Wed, 20 May 2020 15:04:14 +0300, Dan Carpenter wrote:
> The problem in this code is that if kobject_add() fails, then it should
> call of_node_put(np) to drop the reference count. I've actually moved
> the of_node_get(np) later in the function to avoid needing to do clean
> up.
>
> Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: move the of_node_get() instead of doing clean up. Also the v1 had a
> confusing typo in the commit message.
>
> drivers/of/kobj.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v2] of: Fix a refcounting bug in __of_attach_node_sysfs()
Date: Wed, 27 May 2020 18:40:40 +0000 [thread overview]
Message-ID: <20200527184040.GA2529559@bogus> (raw)
In-Reply-To: <20200520120414.GE172354@mwanda>
On Wed, 20 May 2020 15:04:14 +0300, Dan Carpenter wrote:
> The problem in this code is that if kobject_add() fails, then it should
> call of_node_put(np) to drop the reference count. I've actually moved
> the of_node_get(np) later in the function to avoid needing to do clean
> up.
>
> Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in __of_attach_node_sysfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: move the of_node_get() instead of doing clean up. Also the v1 had a
> confusing typo in the commit message.
>
> drivers/of/kobj.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2020-05-27 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 11:30 [PATCH] of: drop a reference on error in __of_attach_node_sysfs() Dan Carpenter
2020-05-18 11:30 ` Dan Carpenter
2020-05-20 10:06 ` Michael Ellerman
2020-05-20 10:06 ` Michael Ellerman
2020-05-20 12:04 ` [PATCH v2] of: Fix a refcounting bug " Dan Carpenter
2020-05-20 12:04 ` Dan Carpenter
2020-05-27 18:40 ` Rob Herring [this message]
2020-05-27 18:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527184040.GA2529559@bogus \
--to=robh@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.