From: Alim Akhtar <alim.akhtar@samsung.com> To: robh@kernel.org Cc: devicetree@vger.kernel.org, linux-scsi@vger.kernel.org, krzk@kernel.org, avri.altman@wdc.com, martin.petersen@oracle.com, kwmad.kim@samsung.com, stanley.chu@mediatek.com, cang@codeaurora.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com> Subject: [PATCH v10 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Date: Thu, 28 May 2020 06:46:53 +0530 [thread overview] Message-ID: <20200528011658.71590-6-alim.akhtar@samsung.com> (raw) In-Reply-To: <20200528011658.71590-1-alim.akhtar@samsung.com> From: Kiwoong Kim <kwmad.kim@samsung.com> Some controller like Exynos determines if FATAL ERROR (0x7) in OCS field in UTRD occurs for values other than GOOD (0x0) in STATUS field in response upiu as well as errors that a host controller can't cover. This patch is to prevent from reporting command results in those cases. Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> Reviewed-by: Avri Altman <avri.altman@wdc.com> --- drivers/scsi/ufs/ufshcd.c | 6 ++++++ drivers/scsi/ufs/ufshcd.h | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index ba093d0d0942..33ebffa8257d 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4794,6 +4794,12 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) /* overall command status of utrd */ ocs = ufshcd_get_tr_ocs(lrbp); + if (hba->quirks & UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR) { + if (be32_to_cpu(lrbp->ucd_rsp_ptr->header.dword_1) & + MASK_RSP_UPIU_RESULT) + ocs = OCS_SUCCESS; + } + switch (ocs) { case OCS_SUCCESS: result = ufshcd_get_req_rsp(lrbp->ucd_rsp_ptr); diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index a9b9ace9fc72..e1d09c2c4302 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -541,6 +541,12 @@ enum ufshcd_quirks { * resolution of the values of PRDTO and PRDTL in UTRD as byte. */ UFSHCD_QUIRK_PRDT_BYTE_GRAN = 1 << 9, + + /* + * This quirk needs to be enabled if the host controller reports + * OCS FATAL ERROR with device error through sense data + */ + UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR = 1 << 10, }; enum ufshcd_caps { -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Alim Akhtar <alim.akhtar@samsung.com> To: robh@kernel.org Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, krzk@kernel.org, kwmad.kim@samsung.com, avri.altman@wdc.com, cang@codeaurora.org, Alim Akhtar <alim.akhtar@samsung.com>, stanley.chu@mediatek.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v10 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Date: Thu, 28 May 2020 06:46:53 +0530 [thread overview] Message-ID: <20200528011658.71590-6-alim.akhtar@samsung.com> (raw) In-Reply-To: <20200528011658.71590-1-alim.akhtar@samsung.com> From: Kiwoong Kim <kwmad.kim@samsung.com> Some controller like Exynos determines if FATAL ERROR (0x7) in OCS field in UTRD occurs for values other than GOOD (0x0) in STATUS field in response upiu as well as errors that a host controller can't cover. This patch is to prevent from reporting command results in those cases. Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> Reviewed-by: Avri Altman <avri.altman@wdc.com> --- drivers/scsi/ufs/ufshcd.c | 6 ++++++ drivers/scsi/ufs/ufshcd.h | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index ba093d0d0942..33ebffa8257d 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4794,6 +4794,12 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) /* overall command status of utrd */ ocs = ufshcd_get_tr_ocs(lrbp); + if (hba->quirks & UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR) { + if (be32_to_cpu(lrbp->ucd_rsp_ptr->header.dword_1) & + MASK_RSP_UPIU_RESULT) + ocs = OCS_SUCCESS; + } + switch (ocs) { case OCS_SUCCESS: result = ufshcd_get_req_rsp(lrbp->ucd_rsp_ptr); diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index a9b9ace9fc72..e1d09c2c4302 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -541,6 +541,12 @@ enum ufshcd_quirks { * resolution of the values of PRDTO and PRDTL in UTRD as byte. */ UFSHCD_QUIRK_PRDT_BYTE_GRAN = 1 << 9, + + /* + * This quirk needs to be enabled if the host controller reports + * OCS FATAL ERROR with device error through sense data + */ + UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR = 1 << 10, }; enum ufshcd_caps { -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-28 1:32 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20200528013223epcas5p2be85fa8803326b49a905fb7225992cad@epcas5p2.samsung.com> 2020-05-28 1:16 ` [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013226epcas5p1c73527c71424679443c10daf8bf561df@epcas5p1.samsung.com> 2020-05-28 1:16 ` [PATCH v10 01/10] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013228epcas5p4641c271e319aaefc78d7bbd22b23c30f@epcas5p4.samsung.com> 2020-05-28 1:16 ` [PATCH v10 02/10] scsi: ufs: add quirk to disallow reset of interrupt aggregation Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013230epcas5p37b2d1980cfccf593242bef11e2076eb8@epcas5p3.samsung.com> 2020-05-28 1:16 ` [PATCH v10 03/10] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013232epcas5p32fecbbebc06909ff1fa7136481891dc1@epcas5p3.samsung.com> 2020-05-28 1:16 ` [PATCH v10 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013234epcas5p2fe5412e2775ff9b28a1b29e8e30ab69c@epcas5p2.samsung.com> 2020-05-28 1:16 ` Alim Akhtar [this message] 2020-05-28 1:16 ` [PATCH v10 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Alim Akhtar [not found] ` <CGME20200528013236epcas5p3cc936778eabd07450fbb7f03a17fe757@epcas5p3.samsung.com> 2020-05-28 1:16 ` [PATCH v10 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013238epcas5p3c00d834dbb0b26cc683f293385d77178@epcas5p3.samsung.com> 2020-05-28 1:16 ` [PATCH v10 07/10] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013240epcas5p38d53c6e320065b40bda434c49efad57a@epcas5p3.samsung.com> 2020-05-28 1:16 ` [PATCH v10 08/10] dt-bindings: ufs: Add bindings for Samsung ufs host Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013243epcas5p460a041d543b9acfbaa923f38709740b0@epcas5p4.samsung.com> 2020-05-28 1:16 ` [PATCH v10 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar [not found] ` <CGME20200528013245epcas5p37851891649512882c7b1ffb5f903c506@epcas5p3.samsung.com> 2020-05-28 1:16 ` [PATCH v10 10/10] arm64: dts: Add node for ufs exynos7 Alim Akhtar 2020-05-28 1:16 ` Alim Akhtar 2020-05-29 8:05 ` Krzysztof Kozlowski 2020-05-29 8:05 ` Krzysztof Kozlowski 2020-06-01 1:30 ` Alim Akhtar 2020-06-01 1:30 ` Alim Akhtar 2020-06-01 1:40 ` [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI Alim Akhtar 2020-06-01 1:40 ` Alim Akhtar 2020-06-03 2:31 ` Martin K. Petersen 2020-06-03 2:31 ` Martin K. Petersen 2020-06-08 2:45 ` Alim Akhtar 2020-06-08 2:45 ` Alim Akhtar 2020-06-08 2:52 ` Kishon Vijay Abraham I 2020-06-08 2:52 ` Kishon Vijay Abraham I 2020-06-11 15:18 ` Alim Akhtar 2020-06-11 15:18 ` Alim Akhtar 2020-06-20 1:59 ` Alim Akhtar 2020-06-20 1:59 ` Alim Akhtar 2020-06-24 10:21 ` Vinod Koul 2020-06-24 10:21 ` Vinod Koul 2020-06-24 16:57 ` Alim Akhtar 2020-06-24 16:57 ` Alim Akhtar 2020-06-24 17:30 ` Vinod Koul 2020-06-24 17:30 ` Vinod Koul 2020-06-25 0:21 ` Alim Akhtar 2020-06-25 0:21 ` Alim Akhtar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200528011658.71590-6-alim.akhtar@samsung.com \ --to=alim.akhtar@samsung.com \ --cc=avri.altman@wdc.com \ --cc=cang@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=krzk@kernel.org \ --cc=kwmad.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=robh@kernel.org \ --cc=stanley.chu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.