All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaskaran Singh <jaskaransingh7654321@gmail.com>
To: cocci@systeme.lip6.fr
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: [Cocci] [PATCH v2 20/25] parsing_c: parser: Place parameter attributes in C AST
Date: Thu, 28 May 2020 17:54:22 +0530	[thread overview]
Message-ID: <20200528122428.4212-21-jaskaransingh7654321@gmail.com> (raw)
In-Reply-To: <20200528122428.4212-1-jaskaransingh7654321@gmail.com>

Parameter attributes are needed so as to not break the nocast test case
when attributes are fully supported. Add parameter attributes to the C
AST.

Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com>
---
 parsing_c/parser_c.mly | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/parsing_c/parser_c.mly b/parsing_c/parser_c.mly
index 57528dfc..cd997aaa 100644
--- a/parsing_c/parser_c.mly
+++ b/parsing_c/parser_c.mly
@@ -857,7 +857,7 @@ new_argument:
      { let ty = addTypeD ($1,nullDecl) in
        let ((returnType,hasreg), iihasreg) = fixDeclSpecForParam ty in
        Right (ArgType { p_namei = None; p_type = returnType;
-			p_register = hasreg, iihasreg;
+                        p_register = hasreg, iihasreg; p_attr = [];
 		      } )
      }
  | new_argument TOCro expr TCCro
@@ -1447,23 +1447,28 @@ parameter_decl2:
      { p_namei = Some name;
        p_type = mk_ty NoType [];
        p_register = (false, []);
+       p_attr = [];
      }
    }
  | decl_spec declaratorp
      { LP.kr_impossible();
        let ((returnType,hasreg),iihasreg) = fixDeclSpecForParam (snd $1) in
-       let (name, ftyp) = $2 in
+       let attrs = (fst $1) @ (fst $2) in
+       let (name, ftyp) = snd $2 in
        { p_namei = Some (name);
          p_type = ftyp returnType;
          p_register = (hasreg, iihasreg);
+         p_attr = attrs;
        }
      }
  | decl_spec abstract_declaratorp
      { LP.kr_impossible();
        let ((returnType,hasreg), iihasreg) = fixDeclSpecForParam (snd $1) in
+       let attrs = (fst $1) @ (fst $2) in
        { p_namei = None;
          p_type = (snd $2) returnType;
          p_register = hasreg, iihasreg;
+         p_attr = attrs;
        }
      }
  | decl_spec
@@ -1472,6 +1477,7 @@ parameter_decl2:
        { p_namei = None;
          p_type = returnType;
          p_register = hasreg, iihasreg;
+         p_attr = fst $1;
        }
      }
 
@@ -1484,11 +1490,11 @@ parameter_decl: parameter_decl2 { et "param" ();  $1 }
 
 declaratorp:
  | declarator  { let (attr,dec) = $1 in (* attr gets ignored *)
-                 LP.add_ident (str_of_name (fst dec)); dec }
+                 LP.add_ident (str_of_name (fst dec)); attr, dec }
  /*(* gccext: *)*/
  | declarator attributes
                { let (attr,dec) = $1 in (* attr gets ignored *)
-                 LP.add_ident (str_of_name (fst dec)); dec }
+                 LP.add_ident (str_of_name (fst dec)); attr, dec }
 
 abstract_declaratorp:
  | abstract_declarator { $1 }
-- 
2.21.1

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

WARNING: multiple messages have this Message-ID (diff)
From: Jaskaran Singh <jaskaransingh7654321@gmail.com>
To: cocci@systeme.lip6.fr
Cc: julia.lawall@inria.fr, jaskaransingh7654321@gmail.com,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: [Linux-kernel-mentees] [PATCH v2 20/25] parsing_c: parser: Place parameter attributes in C AST
Date: Thu, 28 May 2020 17:54:22 +0530	[thread overview]
Message-ID: <20200528122428.4212-21-jaskaransingh7654321@gmail.com> (raw)
In-Reply-To: <20200528122428.4212-1-jaskaransingh7654321@gmail.com>

Parameter attributes are needed so as to not break the nocast test case
when attributes are fully supported. Add parameter attributes to the C
AST.

Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com>
---
 parsing_c/parser_c.mly | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/parsing_c/parser_c.mly b/parsing_c/parser_c.mly
index 57528dfc..cd997aaa 100644
--- a/parsing_c/parser_c.mly
+++ b/parsing_c/parser_c.mly
@@ -857,7 +857,7 @@ new_argument:
      { let ty = addTypeD ($1,nullDecl) in
        let ((returnType,hasreg), iihasreg) = fixDeclSpecForParam ty in
        Right (ArgType { p_namei = None; p_type = returnType;
-			p_register = hasreg, iihasreg;
+                        p_register = hasreg, iihasreg; p_attr = [];
 		      } )
      }
  | new_argument TOCro expr TCCro
@@ -1447,23 +1447,28 @@ parameter_decl2:
      { p_namei = Some name;
        p_type = mk_ty NoType [];
        p_register = (false, []);
+       p_attr = [];
      }
    }
  | decl_spec declaratorp
      { LP.kr_impossible();
        let ((returnType,hasreg),iihasreg) = fixDeclSpecForParam (snd $1) in
-       let (name, ftyp) = $2 in
+       let attrs = (fst $1) @ (fst $2) in
+       let (name, ftyp) = snd $2 in
        { p_namei = Some (name);
          p_type = ftyp returnType;
          p_register = (hasreg, iihasreg);
+         p_attr = attrs;
        }
      }
  | decl_spec abstract_declaratorp
      { LP.kr_impossible();
        let ((returnType,hasreg), iihasreg) = fixDeclSpecForParam (snd $1) in
+       let attrs = (fst $1) @ (fst $2) in
        { p_namei = None;
          p_type = (snd $2) returnType;
          p_register = hasreg, iihasreg;
+         p_attr = attrs;
        }
      }
  | decl_spec
@@ -1472,6 +1477,7 @@ parameter_decl2:
        { p_namei = None;
          p_type = returnType;
          p_register = hasreg, iihasreg;
+         p_attr = fst $1;
        }
      }
 
@@ -1484,11 +1490,11 @@ parameter_decl: parameter_decl2 { et "param" ();  $1 }
 
 declaratorp:
  | declarator  { let (attr,dec) = $1 in (* attr gets ignored *)
-                 LP.add_ident (str_of_name (fst dec)); dec }
+                 LP.add_ident (str_of_name (fst dec)); attr, dec }
  /*(* gccext: *)*/
  | declarator attributes
                { let (attr,dec) = $1 in (* attr gets ignored *)
-                 LP.add_ident (str_of_name (fst dec)); dec }
+                 LP.add_ident (str_of_name (fst dec)); attr, dec }
 
 abstract_declaratorp:
  | abstract_declarator { $1 }
-- 
2.21.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  parent reply	other threads:[~2020-05-28 12:25 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 12:24 [Cocci] [PATCH v2 00/25] cocci: Improve C parsing of attributes Jaskaran Singh
2020-05-28 12:24 ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 01/25] parsing_c: parse_c: Ignore TMacroAttr and TMacroEndAttr in passed tokens Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 02/25] parsing_c: parsing_hacks: Label end attributes correctly Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 03/25] parsing_c: parsing_hacks: Commentize attributes before qualif/type Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 04/25] parsing_c: parser: Add rule for multiple end attributes Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 05/25] parsing_c: parser: Add expression statement attributes Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 06/25] parsing_c: parser: Add attribute production in spec_qualif_list Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 07/25] parsing_c: parser: Add init_declarator_attrs rule Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 08/25] parsing_c: parser: Add field declaration end attributes production Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 09/25] parsing_c: parser: Handle struct/union/enum end attributes Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 10/25] parsing_c: parser: Add MacroDecl end attributes production Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 11/25] parsing_c: parser: cpp_other " Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 12/25] parsing_c: cpp_token_c: Introduce MACROANNOTATION hint Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 13/25] cocci: standard.h: Annotate attributes with MACROANNOTATION Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 14/25] parsing_c: visitor_c: Add vk_attribute and vk_attribute_s Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 15/25] parsing_c: lib_parsing_c: Add ii_of_attr Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 16/25] engine: Add distrf_attr to PARAM functor Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 17/25] engine: cocci_vs_c: Add allminus argument to attribute_list Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 18/25] parsing_c: parser: Make abstract_declarator pass attributes Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 19/25] cocci: Add parameter attributes to C AST Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` Jaskaran Singh [this message]
2020-05-28 12:24   ` [Linux-kernel-mentees] [PATCH v2 20/25] parsing_c: parser: Place parameter attributes in " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 21/25] parsing_c: visitor_c: Visit parameter attributes Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 22/25] parsing_c: unparse_hrule: Add parameter attributes in record Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 23/25] parsing_c: type_c: Add parameter attributes to record Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 24/25] engine: cocci_vs_c: "Match" parameter attributes Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 12:24 ` [Cocci] [PATCH v2 25/25] engine: c_vs_c: Match " Jaskaran Singh
2020-05-28 12:24   ` [Linux-kernel-mentees] " Jaskaran Singh
2020-05-28 13:29 ` [Cocci] [PATCH v3 20/25] parsing_c: parser: Place parameter attributes in C AST Jaskaran Singh
2020-05-28 13:29   ` [Linux-kernel-mentees] " Jaskaran Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528122428.4212-21-jaskaransingh7654321@gmail.com \
    --to=jaskaransingh7654321@gmail.com \
    --cc=cocci@systeme.lip6.fr \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.