* [PATCH kvm-unit-tests] access: disable phys-bits=36 for now
@ 2020-05-28 12:47 Paolo Bonzini
2020-05-28 16:29 ` Vitaly Kuznetsov
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2020-05-28 12:47 UTC (permalink / raw)
To: kvm; +Cc: Vitaly Kuznetsov
Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet,
it should not be enabled. Otherwise, all the pde.36 and pte.36
fail and the test takes so long that it times out.
Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
x86/unittests.cfg | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index bf0d02e..d658bc8 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed
[access]
file = access.flat
arch = x86_64
-extra_params = -cpu host,phys-bits=36
+extra_params = -cpu host
[smap]
file = smap.flat
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH kvm-unit-tests] access: disable phys-bits=36 for now
2020-05-28 12:47 [PATCH kvm-unit-tests] access: disable phys-bits=36 for now Paolo Bonzini
@ 2020-05-28 16:29 ` Vitaly Kuznetsov
2020-05-28 21:45 ` Sean Christopherson
0 siblings, 1 reply; 5+ messages in thread
From: Vitaly Kuznetsov @ 2020-05-28 16:29 UTC (permalink / raw)
To: Paolo Bonzini, kvm
Paolo Bonzini <pbonzini@redhat.com> writes:
> Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet,
> it should not be enabled. Otherwise, all the pde.36 and pte.36
> fail and the test takes so long that it times out.
>
> Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> x86/unittests.cfg | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index bf0d02e..d658bc8 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed
> [access]
> file = access.flat
> arch = x86_64
> -extra_params = -cpu host,phys-bits=36
> +extra_params = -cpu host
>
> [smap]
> file = smap.flat
Works both VMX and SVM, thanks!
Tested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH kvm-unit-tests] access: disable phys-bits=36 for now
2020-05-28 16:29 ` Vitaly Kuznetsov
@ 2020-05-28 21:45 ` Sean Christopherson
2020-05-29 8:48 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Sean Christopherson @ 2020-05-28 21:45 UTC (permalink / raw)
To: Vitaly Kuznetsov; +Cc: Paolo Bonzini, kvm
On Thu, May 28, 2020 at 06:29:44PM +0200, Vitaly Kuznetsov wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet,
> > it should not be enabled. Otherwise, all the pde.36 and pte.36
> > fail and the test takes so long that it times out.
> >
> > Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > x86/unittests.cfg | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > index bf0d02e..d658bc8 100644
> > --- a/x86/unittests.cfg
> > +++ b/x86/unittests.cfg
> > @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed
> > [access]
> > file = access.flat
> > arch = x86_64
> > -extra_params = -cpu host,phys-bits=36
> > +extra_params = -cpu host
> >
> > [smap]
> > file = smap.flat
>
> Works both VMX and SVM, thanks!
What's the status of the "guest-MAXPHYADDR < host-MAXPHYADDR" work? I ask
because the AC_PTE_BIT51 and AC_PDE_BIT51 subtests are broken on CPUs with
52 bit PAs. Is it worth sending a patch to temporarily disable those tests
if MAXPHYADDR=52?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH kvm-unit-tests] access: disable phys-bits=36 for now
2020-05-28 21:45 ` Sean Christopherson
@ 2020-05-29 8:48 ` Paolo Bonzini
2020-05-29 12:22 ` Mohammed Gamal
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2020-05-29 8:48 UTC (permalink / raw)
To: Sean Christopherson, Vitaly Kuznetsov; +Cc: kvm, Mohammed Gamal
On 28/05/20 23:45, Sean Christopherson wrote:
> On Thu, May 28, 2020 at 06:29:44PM +0200, Vitaly Kuznetsov wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet,
>>> it should not be enabled. Otherwise, all the pde.36 and pte.36
>>> fail and the test takes so long that it times out.
>>>
>>> Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> x86/unittests.cfg | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
>>> index bf0d02e..d658bc8 100644
>>> --- a/x86/unittests.cfg
>>> +++ b/x86/unittests.cfg
>>> @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed
>>> [access]
>>> file = access.flat
>>> arch = x86_64
>>> -extra_params = -cpu host,phys-bits=36
>>> +extra_params = -cpu host
>>>
>>> [smap]
>>> file = smap.flat
>>
>> Works both VMX and SVM, thanks!
>
> What's the status of the "guest-MAXPHYADDR < host-MAXPHYADDR" work?
Mohammed was working on it, we should have it in 5.9.
> I ask because the AC_PTE_BIT51 and AC_PDE_BIT51 subtests are broken
> on CPUs with 52 bit PAs. Is it worth sending a patch to temporarily
> disable those tests if MAXPHYADDR=52?
It's a QEMU bug that it does not enable host_phys_bits=on by default for
"-cpu host". For now I'll tweak this patch to add it manually.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH kvm-unit-tests] access: disable phys-bits=36 for now
2020-05-29 8:48 ` Paolo Bonzini
@ 2020-05-29 12:22 ` Mohammed Gamal
0 siblings, 0 replies; 5+ messages in thread
From: Mohammed Gamal @ 2020-05-29 12:22 UTC (permalink / raw)
To: Paolo Bonzini, Sean Christopherson, Vitaly Kuznetsov; +Cc: kvm
On Fri, 2020-05-29 at 10:48 +0200, Paolo Bonzini wrote:
> On 28/05/20 23:45, Sean Christopherson wrote:
> > On Thu, May 28, 2020 at 06:29:44PM +0200, Vitaly Kuznetsov wrote:
> > > Paolo Bonzini <pbonzini@redhat.com> writes:
> > >
> > > > Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream
> > > > yet,
> > > > it should not be enabled. Otherwise, all the pde.36 and pte.36
> > > > fail and the test takes so long that it times out.
> > > >
> > > > Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > > ---
> > > > x86/unittests.cfg | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > > > index bf0d02e..d658bc8 100644
> > > > --- a/x86/unittests.cfg
> > > > +++ b/x86/unittests.cfg
> > > > @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-
> > > > deadline -append tscdeadline_immed
> > > > [access]
> > > > file = access.flat
> > > > arch = x86_64
> > > > -extra_params = -cpu host,phys-bits=36
> > > > +extra_params = -cpu host
> > > >
> > > > [smap]
> > > > file = smap.flat
> > >
> > > Works both VMX and SVM, thanks!
> >
> > What's the status of the "guest-MAXPHYADDR < host-MAXPHYADDR" work?
>
> Mohammed was working on it, we should have it in 5.9.
>
> > I ask because the AC_PTE_BIT51 and AC_PDE_BIT51 subtests are broken
> > on CPUs with 52 bit PAs. Is it worth sending a patch to
> > temporarily
> > disable those tests if MAXPHYADDR=52?
> It's a QEMU bug that it does not enable host_phys_bits=on by default
> for
> "-cpu host". For now I'll tweak this patch to add it manually.
>
> Paolo
>
I actually did send a fix earlier
https://www.spinics.net/lists/kvm/msg215716.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-29 12:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 12:47 [PATCH kvm-unit-tests] access: disable phys-bits=36 for now Paolo Bonzini
2020-05-28 16:29 ` Vitaly Kuznetsov
2020-05-28 21:45 ` Sean Christopherson
2020-05-29 8:48 ` Paolo Bonzini
2020-05-29 12:22 ` Mohammed Gamal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.