* [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN
@ 2020-05-28 14:15 Manikandan Elumalai
2020-05-28 17:34 ` Vijay Khemka
2020-05-29 12:49 ` Patrick Williams
0 siblings, 2 replies; 4+ messages in thread
From: Manikandan Elumalai @ 2020-05-28 14:15 UTC (permalink / raw)
To: linux-aspeed, linux-kernel, openbmc
Cc: sdasari, patrickw3, vijaykhemka, manikandan.e
The adm1278 temperature sysfs attribute need it for one of the our openbmc platform .
This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it.
---
drivers/hwmon/pmbus/adm1275.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
index 5caa37fb..47b293d 100644
--- a/drivers/hwmon/pmbus/adm1275.c
+++ b/drivers/hwmon/pmbus/adm1275.c
@@ -681,6 +681,21 @@ static int adm1275_probe(struct i2c_client *client,
}
}
+ config = i2c_smbus_read_byte_data(client, ADM1275_PMON_CONFIG);
+ if (config < 0)
+ return config;
+
+ /* Enable TEMP1 by defult */
+ config |= ADM1278_TEMP1_EN;
+ ret = i2c_smbus_write_byte_data(client,
+ ADM1275_PMON_CONFIG,
+ config);
+ if (ret < 0) {
+ dev_err(&client->dev,
+ "Failed to enable temperature config\n");
+ return -ENODEV;
+ }
+
if (config & ADM1278_TEMP1_EN)
info->func[0] |=
PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN
2020-05-28 14:15 [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN Manikandan Elumalai
@ 2020-05-28 17:34 ` Vijay Khemka
2020-05-29 9:48 ` Manikandan
2020-05-29 12:49 ` Patrick Williams
1 sibling, 1 reply; 4+ messages in thread
From: Vijay Khemka @ 2020-05-28 17:34 UTC (permalink / raw)
To: Manikandan Elumalai, linux-aspeed, linux-kernel, openbmc
Cc: Sai Dasari, Patrick Williams, manikandan.e
On 5/28/20, 7:15 AM, "Manikandan Elumalai" <manikandan.hcl.ers.epl@gmail.com> wrote:
The adm1278 temperature sysfs attribute need it for one of the our openbmc platform .
This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it.
There is no Signed-off-by.
---
drivers/hwmon/pmbus/adm1275.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
index 5caa37fb..47b293d 100644
--- a/drivers/hwmon/pmbus/adm1275.c
+++ b/drivers/hwmon/pmbus/adm1275.c
@@ -681,6 +681,21 @@ static int adm1275_probe(struct i2c_client *client,
}
}
+ config = i2c_smbus_read_byte_data(client, ADM1275_PMON_CONFIG);
+ if (config < 0)
+ return config;
+
+ /* Enable TEMP1 by defult */
+ config |= ADM1278_TEMP1_EN;
+ ret = i2c_smbus_write_byte_data(client,
+ ADM1275_PMON_CONFIG,
+ config);
+ if (ret < 0) {
+ dev_err(&client->dev,
+ "Failed to enable temperature config\n");
+ return -ENODEV;
+ }
+
if (config & ADM1278_TEMP1_EN)
This check becomes irrelevant as you are enabling it above then rather than
enabling it just remove this check.
info->func[0] |=
PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP;
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN
2020-05-28 17:34 ` Vijay Khemka
@ 2020-05-29 9:48 ` Manikandan
0 siblings, 0 replies; 4+ messages in thread
From: Manikandan @ 2020-05-29 9:48 UTC (permalink / raw)
To: Vijay Khemka
Cc: linux-aspeed, linux-kernel, openbmc, sdasari, patrickw3,
vijaykhemka, manikandan.e
On Thu, May 28, 2020 at 05:34:22PM +0000, Vijay Khemka wrote:
>
>
> On 5/28/20, 7:15 AM, "Manikandan Elumalai" <manikandan.hcl.ers.epl@gmail.com> wrote:
>
>
> The adm1278 temperature sysfs attribute need it for one of the our openbmc platform .
> This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it.
>
> There is no Signed-off-by.
>
> ---
> drivers/hwmon/pmbus/adm1275.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
> index 5caa37fb..47b293d 100644
> --- a/drivers/hwmon/pmbus/adm1275.c
> +++ b/drivers/hwmon/pmbus/adm1275.c
> @@ -681,6 +681,21 @@ static int adm1275_probe(struct i2c_client *client,
> }
> }
>
> + config = i2c_smbus_read_byte_data(client, ADM1275_PMON_CONFIG);
> + if (config < 0)
> + return config;
> +
> + /* Enable TEMP1 by defult */
> + config |= ADM1278_TEMP1_EN;
> + ret = i2c_smbus_write_byte_data(client,
> + ADM1275_PMON_CONFIG,
> + config);
> + if (ret < 0) {
> + dev_err(&client->dev,
> + "Failed to enable temperature config\n");
> + return -ENODEV;
> + }
> +
> if (config & ADM1278_TEMP1_EN)
>
> This check becomes irrelevant as you are enabling it above then rather than
> enabling it just remove this check.
Thanks for review Vijay. I will submit changes in v2.
>
> info->func[0] |=
> PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP;
> --
> 2.7.4
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN
2020-05-28 14:15 [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN Manikandan Elumalai
2020-05-28 17:34 ` Vijay Khemka
@ 2020-05-29 12:49 ` Patrick Williams
1 sibling, 0 replies; 4+ messages in thread
From: Patrick Williams @ 2020-05-29 12:49 UTC (permalink / raw)
To: Manikandan Elumalai
Cc: linux-aspeed, linux-kernel, openbmc, manikandan.e, patrickw3,
vijaykhemka, Guenter Roeck, linux-hwmon
[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]
On Thu, May 28, 2020 at 07:45:23PM +0530, Manikandan Elumalai wrote:
Hi Manikandan,
Adding the PMBus maintainers...
>
> The adm1278 temperature sysfs attribute need it for one of the our openbmc platform .
> This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it.
Vijay already mentioned the Signed-off-by here.
Since this is a kernel patch and your first time contributing one, please
read through:
https://www.kernel.org/doc/html/latest/process/1.Intro.html
and the MAINTAINERS file. Another thing you've missed is using the
get_maintainer.pl script to find out who you're suppose to CC. It is
fine to have additional CCs but we're missing the pmbus maintainer on
this patch.
>
> ---
> drivers/hwmon/pmbus/adm1275.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
> index 5caa37fb..47b293d 100644
> --- a/drivers/hwmon/pmbus/adm1275.c
> +++ b/drivers/hwmon/pmbus/adm1275.c
> @@ -681,6 +681,21 @@ static int adm1275_probe(struct i2c_client *client,
> }
> }
>
> + config = i2c_smbus_read_byte_data(client, ADM1275_PMON_CONFIG);
> + if (config < 0)
> + return config;
> +
> + /* Enable TEMP1 by defult */
> + config |= ADM1278_TEMP1_EN;
> + ret = i2c_smbus_write_byte_data(client,
> + ADM1275_PMON_CONFIG,
> + config);
> + if (ret < 0) {
> + dev_err(&client->dev,
> + "Failed to enable temperature config\n");
> + return -ENODEV;
> + }
> +
This code might work for your design, but likely doesn't work for
everyone and isn't likely to be accepted in its current state. I think
you need some kind of detection logic here to know if TEMP1_EN *should*
be enabled. Do we need a device-tree entry for this?
> if (config & ADM1278_TEMP1_EN)
> info->func[0] |=
> PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP;
> --
> 2.7.4
>
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-29 12:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 14:15 [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN Manikandan Elumalai
2020-05-28 17:34 ` Vijay Khemka
2020-05-29 9:48 ` Manikandan
2020-05-29 12:49 ` Patrick Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.