All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: Laurent.pinchart@ideasonboard.com, kernel@collabora.com,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net,
	tomi.valkeinen@ti.com, airlied@linux.ie, shawnguo@kernel.org
Subject: Re: [PATCH v2 1/4] ARM: dts: dove: Make the DT compliant with the ti,tfp410 binding
Date: Thu, 28 May 2020 11:37:55 -0600	[thread overview]
Message-ID: <20200528173755.GA113289@bogus> (raw)
In-Reply-To: <20200514143612.2094-2-ricardo.canuelo@collabora.com>

On Thu, May 14, 2020 at 04:36:09PM +0200, Ricardo Cañuelo wrote:
> Define a 'ports' node for 'dvi: video@39' and use the proper naming for
> the powerdown-gpios property to make it compliant with the ti,tfp410
> binding.
> 
> This fills the minimum requirements to meet the binding requirements,
> port endpoints are not defined.

Just make 'ports' optional. This isn't really any better unless you add 
endpoints too.

> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
> ---
>  arch/arm/boot/dts/dove-sbc-a510.dts | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts b/arch/arm/boot/dts/dove-sbc-a510.dts
> index 2bb85a9b7614..32804c981625 100644
> --- a/arch/arm/boot/dts/dove-sbc-a510.dts
> +++ b/arch/arm/boot/dts/dove-sbc-a510.dts
> @@ -132,7 +132,18 @@
>  	dvi: video@39 {
>  		compatible = "ti,tfp410";
>  		reg = <0x39>;
> -		powerdown-gpio = <&gpio_ext 3 GPIO_ACTIVE_LOW>;
> +		powerdown-gpios = <&gpio_ext 3 GPIO_ACTIVE_LOW>;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			port@0 {
> +				reg = <0>;
> +			};
> +			port@1 {
> +				reg = <1>;
> +			};
> +		};
>  	};
>  };
>  
> -- 
> 2.18.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
	airlied@linux.ie, dri-devel@lists.freedesktop.org,
	tomi.valkeinen@ti.com, Laurent.pinchart@ideasonboard.com,
	kernel@collabora.com, shawnguo@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ARM: dts: dove: Make the DT compliant with the ti,tfp410 binding
Date: Thu, 28 May 2020 11:37:55 -0600	[thread overview]
Message-ID: <20200528173755.GA113289@bogus> (raw)
In-Reply-To: <20200514143612.2094-2-ricardo.canuelo@collabora.com>

On Thu, May 14, 2020 at 04:36:09PM +0200, Ricardo Cañuelo wrote:
> Define a 'ports' node for 'dvi: video@39' and use the proper naming for
> the powerdown-gpios property to make it compliant with the ti,tfp410
> binding.
> 
> This fills the minimum requirements to meet the binding requirements,
> port endpoints are not defined.

Just make 'ports' optional. This isn't really any better unless you add 
endpoints too.

> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
> ---
>  arch/arm/boot/dts/dove-sbc-a510.dts | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts b/arch/arm/boot/dts/dove-sbc-a510.dts
> index 2bb85a9b7614..32804c981625 100644
> --- a/arch/arm/boot/dts/dove-sbc-a510.dts
> +++ b/arch/arm/boot/dts/dove-sbc-a510.dts
> @@ -132,7 +132,18 @@
>  	dvi: video@39 {
>  		compatible = "ti,tfp410";
>  		reg = <0x39>;
> -		powerdown-gpio = <&gpio_ext 3 GPIO_ACTIVE_LOW>;
> +		powerdown-gpios = <&gpio_ext 3 GPIO_ACTIVE_LOW>;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			port@0 {
> +				reg = <0>;
> +			};
> +			port@1 {
> +				reg = <1>;
> +			};
> +		};
>  	};
>  };
>  
> -- 
> 2.18.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
	airlied@linux.ie, dri-devel@lists.freedesktop.org,
	tomi.valkeinen@ti.com, Laurent.pinchart@ideasonboard.com,
	kernel@collabora.com, shawnguo@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ARM: dts: dove: Make the DT compliant with the ti,tfp410 binding
Date: Thu, 28 May 2020 11:37:55 -0600	[thread overview]
Message-ID: <20200528173755.GA113289@bogus> (raw)
In-Reply-To: <20200514143612.2094-2-ricardo.canuelo@collabora.com>

On Thu, May 14, 2020 at 04:36:09PM +0200, Ricardo Cañuelo wrote:
> Define a 'ports' node for 'dvi: video@39' and use the proper naming for
> the powerdown-gpios property to make it compliant with the ti,tfp410
> binding.
> 
> This fills the minimum requirements to meet the binding requirements,
> port endpoints are not defined.

Just make 'ports' optional. This isn't really any better unless you add 
endpoints too.

> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
> ---
>  arch/arm/boot/dts/dove-sbc-a510.dts | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts b/arch/arm/boot/dts/dove-sbc-a510.dts
> index 2bb85a9b7614..32804c981625 100644
> --- a/arch/arm/boot/dts/dove-sbc-a510.dts
> +++ b/arch/arm/boot/dts/dove-sbc-a510.dts
> @@ -132,7 +132,18 @@
>  	dvi: video@39 {
>  		compatible = "ti,tfp410";
>  		reg = <0x39>;
> -		powerdown-gpio = <&gpio_ext 3 GPIO_ACTIVE_LOW>;
> +		powerdown-gpios = <&gpio_ext 3 GPIO_ACTIVE_LOW>;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			port@0 {
> +				reg = <0>;
> +			};
> +			port@1 {
> +				reg = <1>;
> +			};
> +		};
>  	};
>  };
>  
> -- 
> 2.18.0
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-05-28 17:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 14:36 [PATCH v2 0/4] dt-bindings: display: ti,tfp410.txt: convert to yaml Ricardo Cañuelo
2020-05-14 14:36 ` Ricardo Cañuelo
2020-05-14 14:36 ` Ricardo Cañuelo
2020-05-14 14:36 ` [PATCH v2 1/4] ARM: dts: dove: Make the DT compliant with the ti,tfp410 binding Ricardo Cañuelo
2020-05-14 14:36   ` [PATCH v2 1/4] ARM: dts: dove: Make the DT compliant with the ti, tfp410 binding Ricardo Cañuelo
2020-05-14 14:36   ` Ricardo Cañuelo
2020-05-28 17:37   ` Rob Herring [this message]
2020-05-28 17:37     ` [PATCH v2 1/4] ARM: dts: dove: Make the DT compliant with the ti,tfp410 binding Rob Herring
2020-05-28 17:37     ` Rob Herring
2020-05-28 21:12     ` Laurent Pinchart
2020-05-28 21:12       ` Laurent Pinchart
2020-05-28 21:12       ` Laurent Pinchart
2020-05-14 14:36 ` [PATCH v2 2/4] ARM: dts: ims53: Group port definitions for the dvi-converter Ricardo Cañuelo
2020-05-14 14:36   ` Ricardo Cañuelo
2020-05-14 14:36   ` Ricardo Cañuelo
2020-05-20  2:57   ` Shawn Guo
2020-05-20  2:57     ` Shawn Guo
2020-05-20  2:57     ` Shawn Guo
2020-05-14 14:36 ` [PATCH v2 3/4] dt-bindings: display: ti,tfp410.txt: convert to yaml Ricardo Cañuelo
2020-05-14 14:36   ` Ricardo Cañuelo
2020-05-14 14:36   ` Ricardo Cañuelo
2020-05-28 21:43   ` Laurent Pinchart
2020-05-28 21:43     ` Laurent Pinchart
2020-05-28 21:43     ` Laurent Pinchart
2020-05-14 14:36 ` [PATCH v2 4/4] drm/bridge: tfp410: Fix setup and hold time calculation Ricardo Cañuelo
2020-05-14 14:36   ` Ricardo Cañuelo
2020-05-14 14:36   ` Ricardo Cañuelo
2020-05-28 21:46   ` Laurent Pinchart
2020-05-28 21:46     ` Laurent Pinchart
2020-05-28 21:46     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528173755.GA113289@bogus \
    --to=robh@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason@lakedaemon.net \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=ricardo.canuelo@collabora.com \
    --cc=shawnguo@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.